[Lldb-commits] [lldb] [lldb] Implement ${target.file} format variable (PR #123431)

2025-01-17 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/123431 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: I assumed that watchpoints during reverse execution would not work without further changes, but when I actually tried it, at least the simplest cases do seem to work as-is --- once I fixed the `lldbreverse` code to report watchpoint stops properly. So I've merged those fixes

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From 4b0279adaa055182d93f6d27d04af23fc03492c9 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH 1/3] [lldb] Implement basic support for reverse-continue

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From 4b0279adaa055182d93f6d27d04af23fc03492c9 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH 1/3] [lldb] Implement basic support for reverse-continue

[Lldb-commits] [lldb] b62e558 - [lldb][test] Remove compiler version check and use regex (#123393)

2025-01-17 Thread via lldb-commits
Author: Wanyi Date: 2025-01-17T22:27:34-05:00 New Revision: b62e55803c52ca04093a0eea361407e849dc23e1 URL: https://github.com/llvm/llvm-project/commit/b62e55803c52ca04093a0eea361407e849dc23e1 DIFF: https://github.com/llvm/llvm-project/commit/b62e55803c52ca04093a0eea361407e849dc23e1.diff LOG: [l

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
https://github.com/kusmour closed https://github.com/llvm/llvm-project/pull/123393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Moving this out of Draft as I think I've addressed all the RFC feedback and I'd like to get some input on the code. I've broken out the changes that can stand on their own into separate PRs. The only outstanding blocker that I'm aware of is the use of an ansi escape code

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Add a statusline to command-line LLDB to display progress events and other information related to the current state of the debugger. The statusline is a dedicated area displayed the bottom of the scre

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From f35884731d0f4bb4a420d2ee802378cc0e1d24fb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:18:13 -0800 Subject: [PATCH 1/3] [lldb] Implement ${taret.file} format variable Imp

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/121860 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement ${taret.file} format variable (PR #123431)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/123431 >From c5474b3a1f0f2ed78f799e8b907ef2f2aa5d97e1 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:18:13 -0800 Subject: [PATCH] [lldb] Implement ${taret.file} format variable Impleme

[Lldb-commits] [lldb] [lldb] Implement ${taret.file} format variable (PR #123431)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I want to include the target name in the Statusline (https://github.com/llvm/llvm-project/pull/121860) format string. https://github.com/llvm/llvm-project/pull/123431 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] [lldb] Implement ${taret.file} format variable (PR #123431)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Implements a format variable to print the basename and full path to the current target. --- Full diff: https://github.com/llvm/llvm-project/pull/123431.diff 4 Files Affected: - (modified) lldb/do

[Lldb-commits] [lldb] [lldb] Implement ${taret.file} format variable (PR #123431)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/123431 Implements a format variable to print the basename and full path to the current target. >From bbc53e89594de2528a7fca3cf0a80055f1acb526 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 20

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From cd4630d53068c8630351cc1bc3b281fc749d7b0a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH] [lldb] Implement statusline MIME-Version: 1.0 Content-T

[Lldb-commits] [lldb] [lldb] Support format string in the prompt (PR #123430)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I need the same functionality for the Statusline (https://github.com/llvm/llvm-project/pull/121860) so I've factored this out into its own PR. https://github.com/llvm/llvm-project/pull/123430 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb] Support format string in the prompt (PR #123430)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Implement ansi::StripAnsiTerminalCodes and fix a long standing bug where using format strings in lldb's prompt resulted in an incorrect prompt column width. --- Full diff: https://github.com/llvm/ll

[Lldb-commits] [lldb] [lldb] Support format string in the prompt (PR #123430)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/123430 Implement ansi::StripAnsiTerminalCodes and fix a long standing bug where using format strings in lldb's prompt resulted in an incorrect prompt column width. >From 10e89226a485d73acfb07ad6d72f3004d270a2f5 M

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread via lldb-commits
jimingham wrote: Let's give @labath a chance to give his final signoff, then this should be good to go. https://github.com/llvm/llvm-project/pull/112079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From d024e9fb724fde3dd5d810dca4bc7ab129c48658 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH 1/2] [lldb] Implement basic support for reverse-continue

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > Looks like you have to change some formatting somewhere, Fixed. https://github.com/llvm/llvm-project/pull/112079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From d024e9fb724fde3dd5d810dca4bc7ab129c48658 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH 1/2] [lldb] Implement basic support for reverse-continue

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > I still feel like it would be better to have a way to ask up front if the > process supports reverse continue and shortcut attempts to do so as early as > possible (e.g. if you ask a command to reverse continue and the process > doesn't support it, we should return with an

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread via lldb-commits
jimingham wrote: > > I'm not so familiar with the parts of the testsuite this builds on, so it > > would be great if someone more familiar with that part would give that a > > look. > > I think Pavel has already done this. If Pavel's good with the test part, I'm happy with the rest of the cha

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > I'm not so familiar with the parts of the testsuite this builds on, so it > would be great if someone more familiar with that part would give that a look. I think Pavel has already done this. https://github.com/llvm/llvm-project/pull/112079 _

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/112079 >From d024e9fb724fde3dd5d810dca4bc7ab129c48658 Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH 1/2] [lldb] Implement basic support for reverse-continue

[Lldb-commits] [lldb] LLDB Statusline (PR #121860)

2025-01-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From d2fdaec2cd06127d2b07e9e2a8ed68400cfd1a5d Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 13 Jan 2025 10:58:31 -0800 Subject: [PATCH] [lldb] Implement statusline MIME-Version: 1.0 Content-T

[Lldb-commits] [lldb] 8f18f36 - [lldb] Skip unreliable test under ASAN

2025-01-17 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2025-01-17T13:27:11-08:00 New Revision: 8f18f36b4906872ee0838ade2c0367c77b6f5bc0 URL: https://github.com/llvm/llvm-project/commit/8f18f36b4906872ee0838ade2c0367c77b6f5bc0 DIFF: https://github.com/llvm/llvm-project/commit/8f18f36b4906872ee0838ade2c0367c77b6f5bc0.diff

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > Better to wait until you can say "lldb can now be used as a client for RR" ? Technically that is already true --- with stock LLDB and latest rr you can debug an rr replay, which is useful. You just don't get the reverse-execution superpower. https://github.com/llvm/llvm-pr

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
https://github.com/GeorgeHuyubo approved this pull request. https://github.com/llvm/llvm-project/pull/123393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/123393 >From 944e3c809f27a47c1984938e30e8d338e66d34be Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Fri, 17 Jan 2025 12:01:56 -0800 Subject: [PATCH] [lldb][test] Remove compiler version check and use regex --- .../Te

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 6b048aeaf837e0e16fece94610f0871d17cefe4c...1d4160e68221ff90a7d01ab58f88eeb599882ef9 lldb

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/123393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes The test checks specific compiler version to determine the output. However, the compiler version string is always set to 15.0.0 for our local build. Remove this check and use regex match instead. --- Full diff: htt

[Lldb-commits] [lldb] [lldb][test] Remove compiler version check and use regex (PR #123393)

2025-01-17 Thread via lldb-commits
https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/123393 The test checks specific compiler version to determine the output. However, the compiler version string is always set to 15.0.0 for our local build. Remove this check and use regex match instead. >From 1d4160e

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/119052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 6b048ae - [LLDB] Add SBProgress so Python scripts can also report progress (#119052)

2025-01-17 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-01-17T12:00:31-08:00 New Revision: 6b048aeaf837e0e16fece94610f0871d17cefe4c URL: https://github.com/llvm/llvm-project/commit/6b048aeaf837e0e16fece94610f0871d17cefe4c DIFF: https://github.com/llvm/llvm-project/commit/6b048aeaf837e0e16fece94610f0871d17cefe4c.diff

[Lldb-commits] [lldb] [lldb-dap] Implement `runInTerminal` for Windows (PR #121269)

2025-01-17 Thread John Harrison via lldb-commits
ashgti wrote: Is the process stopped? I think lldb is waiting for the process to be in a stopped state. In posix terms a `SIGSTOP`, although I'm not as familiar with the win32 equiv (DebugActiveProcess maybe). https://github.com/llvm/llvm-project/pull/121269 ___

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread via lldb-commits
jimingham wrote: I still feel like it would be better to have a way to ask up front if the process supports reverse continue and shortcut attempts to do so as early as possible (e.g. if you ask a command to reverse continue and the process doesn't support it, we should return with an error rig

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread via lldb-commits
@@ -3265,18 +3275,25 @@ Status Process::PrivateResume() { // (suspended/running/stepping). Threads should also check their resume // signal in lldb::Thread::GetResumeSignal() to see if they are supposed to // start back up with a signal. -if (m_thread_list.WillR

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread via lldb-commits
@@ -370,6 +370,31 @@ bool SymbolContext::GetAddressRange(uint32_t scope, uint32_t range_idx, return false; } +Address SymbolContext::GetAddress(uint32_t scope, + bool use_inline_block_range) const { + if ((scope & eSymbolContextLineEntry) &

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread via lldb-commits
@@ -192,6 +192,33 @@ class SymbolContext { bool GetAddressRange(uint32_t scope, uint32_t range_idx, bool use_inline_block_range, AddressRange &range) const; + /// Get the address represented by this symbol context. + /// + /// The exact meaning of t

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/119052 >From d28dedabaeb6bdc763e8226e7d669ff4eba66d50 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 6 Dec 2024 18:17:44 -0800 Subject: [PATCH 1/5] Add SBPRogress class to enable commands to async report to l

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,68 @@ +//===-- SBProgress.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [experiment] Make `fltSemantics` public (PR #123374)

2025-01-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d7e48fbf205a01fcbc109b2555b12aa0d37845a4 f595dfc75253a3ca80196f6e7f5fb38ca6d82376 --e

[Lldb-commits] [clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [experiment] Make `fltSemantics` public (PR #123374)

2025-01-17 Thread Matthias Springer via lldb-commits
https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/123374 None >From f595dfc75253a3ca80196f6e7f5fb38ca6d82376 Mon Sep 17 00:00:00 2001 From: Matthias Springer Date: Fri, 17 Jan 2025 18:08:14 +0100 Subject: [PATCH] [experiment] Make `fltSemantics` public ---

[Lldb-commits] [lldb] a4d45fe - [lldb][DWARF] Change GetAttributes parameter from SmallVector to SmallVectorImpl

2025-01-17 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-01-17T14:56:41Z New Revision: a4d45fe8462bf7042bac2edfb87e3e41e4156ba4 URL: https://github.com/llvm/llvm-project/commit/a4d45fe8462bf7042bac2edfb87e3e41e4156ba4 DIFF: https://github.com/llvm/llvm-project/commit/a4d45fe8462bf7042bac2edfb87e3e41e4156ba4.diff LOG:

[Lldb-commits] [lldb] dc1ef2c - [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (#123089)

2025-01-17 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-17T14:11:05Z New Revision: dc1ef2cc1aa2de7ef6830419de37ad93eb74d34a URL: https://github.com/llvm/llvm-project/commit/dc1ef2cc1aa2de7ef6830419de37ad93eb74d34a DIFF: https://github.com/llvm/llvm-project/commit/dc1ef2cc1aa2de7ef6830419de37ad93eb74d34a.diff LOG:

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-hexagon Author: Pavel Labath (labath) Changes Many (most?) uses of SC::GetAddressRange were not interested in the range, but in the address of the function/symbol contained inside the symbol context. They were getting that by calling the GetBas

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/123340 Many (most?) uses of SC::GetAddressRange were not interested in the range, but in the address of the function/symbol contained inside the symbol context. They were getting that by calling the GetBaseAddress on t

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ee4282259d5993dfa0b7b8937541dd6ccaadf3d5 2d6210ad9527df5147987f856e941e61d9851a97 --e

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123340 >From 2d6210ad9527df5147987f856e941e61d9851a97 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 17 Jan 2025 12:36:36 +0100 Subject: [PATCH 1/2] [lldb] Add SymbolContext::GetAddress Many (most?) uses of SC:

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -370,6 +370,31 @@ bool SymbolContext::GetAddressRange(uint32_t scope, uint32_t range_idx, return false; } +Address SymbolContext::GetAddress(uint32_t scope, + bool use_inline_block_range) const { + if ((scope & eSymbolContextLineEntry) &

[Lldb-commits] [lldb] [lldb] Add SymbolContext::GetAddress (PR #123340)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Many (most?) uses of SC::GetAddressRange were not interested in the range, but in the address of the function/symbol contained inside the symbol context. They were getting that by calling the GetBaseAddress on

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123089 >From 3b83db4a912d01b6f416e8873f9fbe8fb598ff0c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 15 Jan 2025 16:58:53 + Subject: [PATCH] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_poin

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/123261 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5153a90 - [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (#123261)

2025-01-17 Thread via lldb-commits
Author: Michael Buch Date: 2025-01-17T13:09:52Z New Revision: 5153a90453e692b834e38eec247a0c88a0678bfa URL: https://github.com/llvm/llvm-project/commit/5153a90453e692b834e38eec247a0c88a0678bfa DIFF: https://github.com/llvm/llvm-project/commit/5153a90453e692b834e38eec247a0c88a0678bfa.diff LOG:

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
Michael137 wrote: @labath the test `TestStaticVariables.py` was failing because with the new iteration order `ParseVariableDIE` would overwrite a `DW_TAG_variable`s type from `ArrayType[2]` (which is on the definition) to `ArrayType[]`. So I adjusted it to not do that https://github.com/llvm/

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/9] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] 58fc802 - [lldb] Skip TestStepUntilAPI on !x86_64, !aarch64

2025-01-17 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2025-01-17T13:07:06+01:00 New Revision: 58fc8029e91bf56811444d4a37a8f517a43bdc11 URL: https://github.com/llvm/llvm-project/commit/58fc8029e91bf56811444d4a37a8f517a43bdc11 DIFF: https://github.com/llvm/llvm-project/commit/58fc8029e91bf56811444d4a37a8f517a43bdc11.diff

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/8] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/9983 Here is the relevant piece of the build log

[Lldb-commits] [clang] [lldb] [clang][Expr] Teach IgnoreUnlessSpelledInSource about implicit calls to std::get free function (PR #122265)

2025-01-17 Thread Michael Buch via lldb-commits
Michael137 wrote: Hmm there's a clang-tidy test failing because this codepath gets hit for `UserDefinedLiteral`, which is a `CallExpr` with a single argument: ``` (lldb) p E->dump() UserDefinedLiteral 0x15402b738 'unsigned long long' |-ImplicitCastExpr 0x15402b720 'unsigned long long (*)(unsigne

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: > This string comes from the debug/lldb-server, and MacOS has a... complicated > compatibility story for the debugserver. It's not to the same level, but doesn't everyone else have this issue, potentially? Though the consequence is just that if my lldb-server is old and

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: Tests passed on Arm and AArch64. > This commit only adds support for the SBProcess::ReverseContinue() API. A > user-accessible command for this will follow in a later commit. I think this means it's not worth adding a release note just yet? Better to wait until you can sa

[Lldb-commits] [lldb] f66a5e2 - [lldb] Fix SBThread::StepOverUntil for discontinuous functions (#123046)

2025-01-17 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-17T12:13:30+01:00 New Revision: f66a5e220cbc2650a5843db854d0734d2aaa030f URL: https://github.com/llvm/llvm-project/commit/f66a5e220cbc2650a5843db854d0734d2aaa030f DIFF: https://github.com/llvm/llvm-project/commit/f66a5e220cbc2650a5843db854d0734d2aaa030f.diff

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/123046 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread Pavel Labath via lldb-commits
labath wrote: > I see you changed the MTE core file case, there is a live process test case > too, a search for `fault address:` should find it and any others. Done, and I've changed a couple of extra strings as well https://github.com/llvm/llvm-project/pull/123217

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread Pavel Labath via lldb-commits
labath wrote: > We could make MacOS adopt the Linux format, right? Not that that changes much > but just wondering if there's any reason you chose that direction. The reason I chose this direction is because I still think of MacOS as the "reference platform" for lldb, but now that I've thought

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: We could make MacOS adopt the Linux format, right? Not that that changes much but just wondering if there's any reason you chose that direction. I see you changed the MTE core file case, there is a live process test case too, a search for `fault address:` should find it an

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/123046 >From 74d436310319d17cb43ba598836b70a92c827111 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 15 Jan 2025 12:41:23 +0100 Subject: [PATCH 1/7] [lldb] Fix SBThread::StepOverUntil for discontinuous function

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
@@ -309,10 +319,10 @@ void DWARFDebugInfoEntry::GetAttributes(DWARFUnit *cu, switch (attr) { case DW_AT_sibling: case DW_AT_declaration: - if (curr_depth > 0) { + if (seen.size() > 1 && !is_first_die) { Michael137 wrote: Good point! http

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -10,7 +10,7 @@ class TestDiagnoseDereferenceFunctionReturn(TestBase): -@skipUnlessDarwin +@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples())) labath wrote: Yep https://github.com/llvm/llvm-project/pull/123217 _

[Lldb-commits] [lldb] [lldb] Enable "frame diagnose" on linux (PR #123217)

2025-01-17 Thread David Spickett via lldb-commits
@@ -10,7 +10,7 @@ class TestDiagnoseDereferenceFunctionReturn(TestBase): -@skipUnlessDarwin +@expectedFailureAll(oslist=no_match(lldbplatformutil.getDarwinOSTriples())) DavidSpickett wrote: This test previously could not run anywhere but Darwin but n

[Lldb-commits] [lldb] [lldb] Fix SBThread::StepOverUntil for discontinuous functions (PR #123046)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -859,7 +859,9 @@ SBError SBThread::StepOverUntil(lldb::SBFrame &sb_frame, addr_t step_addr = sc.line_entry.range.GetBaseAddress().GetLoadAddress(target); if (step_addr != LLDB_INVALID_ADDRESS) { -if (fun_range.ContainsLoadAddress(step_addr, targ

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/7] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/6] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
@@ -339,6 +348,39 @@ void DWARFDebugInfoEntry::GetAttributes(DWARFUnit *cu, DWARFFormValue::SkipValue(form, data, &offset, cu); } } + + return true; +} + +DWARFAttributes DWARFDebugInfoEntry::GetAttributes(const DWARFUnit *cu, +

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/5] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2025-01-17 Thread Pavel Labath via lldb-commits
labath wrote: (I'm going to remove all the labels to try to avoid pinging everyone each time you rebase) https://github.com/llvm/llvm-project/pull/102601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Don't overwrite DW_AT_object_pointer of definition with that of a declaration (PR #123089)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/123089 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/123261 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -309,10 +319,10 @@ void DWARFDebugInfoEntry::GetAttributes(DWARFUnit *cu, switch (attr) { case DW_AT_sibling: case DW_AT_declaration: - if (curr_depth > 0) { + if (seen.size() > 1 && !is_first_die) { labath wrote: ```suggestion i

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -339,6 +348,39 @@ void DWARFDebugInfoEntry::GetAttributes(DWARFUnit *cu, DWARFFormValue::SkipValue(form, data, &offset, cu); } } + + return true; +} + +DWARFAttributes DWARFDebugInfoEntry::GetAttributes(const DWARFUnit *cu, +

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #112079)

2025-01-17 Thread David Spickett via lldb-commits
DavidSpickett wrote: I will test on AArch64 Linux today. https://github.com/llvm/llvm-project/pull/112079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Change GetAttributes to always visit current DIE before recursing (PR #123261)

2025-01-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/123261 >From 69b53a2a6290733ee90e4d75521f4c2fd6bd1401 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 16 Jan 2025 15:16:36 + Subject: [PATCH 1/4] [lldb][DWARF] Change GetAttributes to always visit curren

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,35 @@ +"""Test the SBProgress API.""" + +import lldb +from lldbsuite.test.lldbtest import * + + +class SBProgressTestCase(TestBase): +def test_with_external_bit_set(self): +"""Test SBProgress events are listened to when the external bit is set.""" + +

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,68 @@ +//===-- SBProgress.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/119052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,68 @@ +//===-- SBProgress.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Add SBProgress so Python scripts can also report progress (PR #119052)

2025-01-17 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. I think this is fine. I was thinking this could be implemented purely from the python side by sending the appropriate events manually, but this doesn't work because we don't have the ability to construct the right kind of event objects. We

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Chandler Carruth (chandlerc) Changes Now that we have a dedicated abstraction for string tables, switch the option parser library's string table over to it rather than using a raw `const char*`. Also try to use the `StringTable::Offset` t

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-tablegen Author: Chandler Carruth (chandlerc) Changes Now that we have a dedicated abstraction for string tables, switch the option parser library's string table over to it rather than using a raw `const char*`. Also try to use the `StringTable::Offset

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities Author: Chandler Carruth (chandlerc) Changes Now that we have a dedicated abstraction for string tables, switch the option parser library's string table over to it rather than using a raw `const char*`. Also try to use the `String

[Lldb-commits] [clang] [lldb] [llvm] [StrTable] Switch the option parser to `llvm::StringTable` (PR #123308)

2025-01-17 Thread Chandler Carruth via lldb-commits
https://github.com/chandlerc created https://github.com/llvm/llvm-project/pull/123308 Now that we have a dedicated abstraction for string tables, switch the option parser library's string table over to it rather than using a raw `const char*`. Also try to use the `StringTable::Offset` type rat

[Lldb-commits] [lldb] [lldb][RISCV] Support optionally disabled FPR for riscv64 (PR #104547)

2025-01-17 Thread Alexey Merzlyakov via lldb-commits
AlexeyMerzlyakov wrote: Hi, @DavidSpickett. Sure, no problem, I'll make an update PR for ReleaseNotes with optionally enabled/disabled register sets soon. https://github.com/llvm/llvm-project/pull/104547 ___ lldb-commits mailing list lldb-commits@list