[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

https://github.com/labath approved this pull request. Good stuff. Thanks. https://github.com/llvm/llvm-project/pull/118565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests (PR #118530)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/118530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 442ee78 - [lldb-dap] Fix Markdown tables in README.md

Author: Jonas Devlieghere Date: 2024-12-03T20:59:02-08:00 New Revision: 442ee78cb414cd7101482bb677e62631e94e5480 URL: https://github.com/llvm/llvm-project/commit/442ee78cb414cd7101482bb677e62631e94e5480 DIFF: https://github.com/llvm/llvm-project/commit/442ee78cb414cd7101482bb677e62631e94e5480.d

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/118565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add 'FindFirstSymbolWithNameAndType()' to ModuleList. (PR #117777)

https://github.com/clayborg commented: This would be easy to test if we expose this via the public API in `SBTarget`. We don't expose a FindFirstSymbolWithNameAndType, but we can expose maybe: ``` lldb::SBSymbol SBTarget::FindFirstSymbol(const char *name, lldb::SymbolType type = eSymbolTypeAny)

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

https://github.com/ashgti approved this pull request. Super useful, especially on macOS with Xcode installed https://github.com/llvm/llvm-project/pull/118547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/118547 >From 984beaa4b26f97a925d8c3f3bc97a9e9b61511ec Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 3 Dec 2024 12:59:13 -0800 Subject: [PATCH 1/3] [lldb-dap] Support finding the lldb-dap binary Supp

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes This results in the second address listed in `Socket::GetListeningConnectionURI` to have port `:0`, which is incorrect. To fix this, correct which address is used to detect the port and update the unit tests

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/118565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] When using Socket to listen on `localhost:0` on systems supporting ting ipv4 and ipv6 the second socket to initialize will not update the listening address correctly after

https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/118565 This results in the second address listed in `Socket::GetListeningConnectionURI` to have port `:0`, which is incorrect. To fix this, correct which address is used to detect the port and update the unit tests to

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/118547 >From 984beaa4b26f97a925d8c3f3bc97a9e9b61511ec Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 3 Dec 2024 12:59:13 -0800 Subject: [PATCH 1/2] [lldb-dap] Support finding the lldb-dap binary Supp

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types"; export class LLDBDapDescriptorFactory implements vscode.DebugAdapterDescriptorFactory { - private lldbDapOptions: LLDBDapOptions; - - constructor(lldbDapOptions: LLDBDapOptions) { -this.lldbDapOptions = lldbDap

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types"; export class LLDBDapDescriptorFactory implements vscode.DebugAdapterDescriptorFactory { - private lldbDapOptions: LLDBDapOptions; - - constructor(lldbDapOptions: LLDBDapOptions) { -this.lldbDapOptions = lldbDap

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types"; export class LLDBDapDescriptorFactory implements vscode.DebugAdapterDescriptorFactory { - private lldbDapOptions: LLDBDapOptions; - - constructor(lldbDapOptions: LLDBDapOptions) { -this.lldbDapOptions = lldbDap

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -28,6 +23,70 @@ export class LLDBDapDescriptorFactory return true; } + static async findDAPExecutable(): Promise { +let executable = "lldb-dap"; +if (process.platform === "win32") { + executable = "lldb-dap.exe"; +} + +// Prefer lldb-dap from Xco

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types"; export class LLDBDapDescriptorFactory implements vscode.DebugAdapterDescriptorFactory { - private lldbDapOptions: LLDBDapOptions; - - constructor(lldbDapOptions: LLDBDapOptions) { -this.lldbDapOptions = lldbDap

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -28,6 +23,70 @@ export class LLDBDapDescriptorFactory return true; } + static async findDAPExecutable(): Promise { +let executable = "lldb-dap"; +if (process.platform === "win32") { + executable = "lldb-dap.exe"; +} walter-erquinigo

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

https://github.com/walter-erquinigo approved this pull request. beautiful https://github.com/llvm/llvm-project/pull/118547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/118547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -28,6 +23,70 @@ export class LLDBDapDescriptorFactory return true; } + static async findDAPExecutable(): Promise { walter-erquinigo wrote: This function is really not complex but a bit long. Can you split it into smaller chunks? https://github.com

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -28,6 +23,70 @@ export class LLDBDapDescriptorFactory return true; } + static async findDAPExecutable(): Promise { +let executable = "lldb-dap"; +if (process.platform === "win32") { + executable = "lldb-dap.exe"; +} + +// Prefer lldb-dap from Xco

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

@@ -28,6 +23,70 @@ export class LLDBDapDescriptorFactory return true; } + static async findDAPExecutable(): Promise { +let executable = "lldb-dap"; +if (process.platform === "win32") { + executable = "lldb-dap.exe"; +} + +// Prefer lldb-dap from Xco

[Lldb-commits] [lldb] [lldb] Update dwim-print to show expanded objc instances (PR #117500)

@@ -87,7 +87,8 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, DumpValueObjectOptions dump_options = m_varobj_options.GetAsDumpOptions( m_expr_options.m_verbosity, m_format_options.GetFormat()); - dump_options.SetHideRootName(suppress_result); + dump_opt

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

@@ -0,0 +1,19 @@ +int main(int argc, char** argv) { + struct A { +struct { + int x = 1; +}; +int y = 2; + } a; + + struct B { +// Anonymous struct inherits another struct. +struct : public A { + int z = 3; +}; +int w = 4; +A a; + } b;

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117808 >From b8c64e227b8f9f82b420cc5c2f24fbd3f75f67f5 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Tue, 26 Nov 2024 15:08:32 -0800 Subject: [PATCH 1/5] [lLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWi

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests (PR #118530)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/118530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Support finding the lldb-dap binary with `xcrun` on Darwin or in PATH on all other platforms. Unfortunately, this PR is larger than I would like because it removes the `lldbDapOptions`. I believe

[Lldb-commits] [lldb] [lldb-dap] Support finding the lldb-dap binary (PR #118547)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/118547 Support finding the lldb-dap binary with `xcrun` on Darwin or in PATH on all other platforms. Unfortunately, this PR is larger than I would like because it removes the `lldbDapOptions`. I believe these o

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/118330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3845624 - [lldb] For a host socket, add a method to print the listening address. (#118330)

Author: John Harrison Date: 2024-12-03T11:11:32-08:00 New Revision: 384562495bae44be053c1bbd40c359ef4b82d803 URL: https://github.com/llvm/llvm-project/commit/384562495bae44be053c1bbd40c359ef4b82d803 DIFF: https://github.com/llvm/llvm-project/commit/384562495bae44be053c1bbd40c359ef4b82d803.diff

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( llvm::StringRef field_name = field->getName(); if (field_name.empty()) { CompilerType field_type = GetType(field->getType()); +std::vector save_indices = c

[Lldb-commits] [lldb] f715124 - [lldb-dap] Fix the vscode-uninstall command

Author: Jonas Devlieghere Date: 2024-12-03T11:03:28-08:00 New Revision: f7151248579330df8ea68003f60b778149e0f262 URL: https://github.com/llvm/llvm-project/commit/f7151248579330df8ea68003f60b778149e0f262 DIFF: https://github.com/llvm/llvm-project/commit/f7151248579330df8ea68003f60b778149e0f262.d

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests (PR #118530)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes Specify ENABLE_THREADS := YES within test's Makefile instead of passing -lpthread explicitly via the compiler's CFLAGS options. Refactoring fix. --- Full diff: https://github.com/llvm/llvm-project

[Lldb-commits] [lldb] [lldb][tests] Fix passing pthread library to a linker for some API tests (PR #118530)

https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/118530 Specify ENABLE_THREADS := YES within test's Makefile instead of passing -lpthread explicitly via the compiler's CFLAGS options. Refactoring fix. >From 540b07e0ff0b0ecd6745837456c81bb5b95f18ab Mon Sep 17 00:

[Lldb-commits] [lldb] [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (PR #117401)

@@ -3194,16 +3194,19 @@ lldb::ValueObjectSP ValueObject::CastToBasicType(CompilerType type) { GetCompilerType().IsPointerType() || GetCompilerType().IsNullPtrType(); bool is_float = GetCompilerType().IsFloat(); bool is_integer = GetCompilerType().IsInteger(); + Exec

[Lldb-commits] [lldb] [LLDB] Fix error returns in CastToBasicType and CastToEnumType in ValueObject. (PR #117401)

https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/117401 >From b6051edba2a1ecae144ead48712fb511c204131a Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Fri, 22 Nov 2024 15:33:42 -0800 Subject: [PATCH 1/3] [LLDB] Fix error returns in CastToBasicType and CastToEnumTy

[Lldb-commits] [lldb] 0ca8a59 - [lldb][NFC] Remove unused field Platform::m_remote_url (#118411)

Author: Alex Langford Date: 2024-12-03T10:31:38-08:00 New Revision: 0ca8a593e5da5d00100db8f735b4c4babeb36eb8 URL: https://github.com/llvm/llvm-project/commit/0ca8a593e5da5d00100db8f735b4c4babeb36eb8 DIFF: https://github.com/llvm/llvm-project/commit/0ca8a593e5da5d00100db8f735b4c4babeb36eb8.diff

[Lldb-commits] [lldb] [lldb][NFC] Remove unused field Platform::m_remote_url (PR #118411)

https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/118411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -115,6 +115,18 @@ std::string TCPSocket::GetRemoteConnectionURI() const { return ""; } +std::vector TCPSocket::GetListeningConnectionURI() const { + if (m_listen_sockets.empty()) +return {}; + ashgti wrote: Applied suggestion https://github.com/llv

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -115,6 +115,18 @@ std::string TCPSocket::GetRemoteConnectionURI() const { return ""; } +std::vector TCPSocket::GetListeningConnectionURI() const { + if (m_listen_sockets.empty()) +return {}; + + std::vector URIs; + for (auto &s : m_listen_sockets)

[Lldb-commits] [lldb] Make SBMemoryRegionInfoList iterable with Python SWIG (PR #117358)

github-actions[bot] wrote: @lukejriddle Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[Lldb-commits] [lldb] Make SBMemoryRegionInfoList iterable with Python SWIG (PR #117358)

https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/117358 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2a1a024 - Make SBMemoryRegionInfoList iterable with Python SWIG (#117358)

Author: Luke Riddle Date: 2024-12-03T10:29:12-08:00 New Revision: 2a1a02461a8d4ae9f560a4215fe85a1f085b4d82 URL: https://github.com/llvm/llvm-project/commit/2a1a02461a8d4ae9f560a4215fe85a1f085b4d82 DIFF: https://github.com/llvm/llvm-project/commit/2a1a02461a8d4ae9f560a4215fe85a1f085b4d82.diff L

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -225,12 +247,29 @@ TEST_P(SocketTest, TCPListen0GetPort) { if (!HostSupportsIPv4()) return; llvm::Expected> sock = - Socket::TcpListen("10.10.12.3:0", false); + Socket::TcpListen("10.10.12.3:0", 5); ASSERT_THAT_EXPECTED(sock, llvm::Succeeded()); ASSER

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -88,6 +88,28 @@ TEST_P(SocketTest, DomainListenConnectAccept) { CreateDomainConnectedSockets(Path, &socket_a_up, &socket_b_up); } +TEST_P(SocketTest, DomainListenGetListeningConnectionURI) { + llvm::SmallString<64> Path; + std::error_code EC = + llvm::sys::fs::crea

[Lldb-commits] [lldb] [lldb] Fix the DWARF index cache when index is partial. (PR #118390)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/118390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f44bee7 - [lldb] Fix the DWARF index cache when index is partial. (#118390)

Author: Greg Clayton Date: 2024-12-03T10:09:40-08:00 New Revision: f44bee78c471df8f0a258c656a921a082d7e836a URL: https://github.com/llvm/llvm-project/commit/f44bee78c471df8f0a258c656a921a082d7e836a DIFF: https://github.com/llvm/llvm-project/commit/f44bee78c471df8f0a258c656a921a082d7e836a.diff

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/118330 >From c3226b620bc8f745b92b3aca7b189803a24db788 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Dec 2024 08:29:01 -0800 Subject: [PATCH 1/6] [lldb] For a host socket, add a method to print the listening

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -115,6 +115,18 @@ std::string TCPSocket::GetRemoteConnectionURI() const { return ""; } +std::vector TCPSocket::GetListeningConnectionURI() const { + if (m_listen_sockets.empty()) +return {}; + + std::vector URIs; + for (auto &s : m_listen_sockets)

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -225,12 +247,29 @@ TEST_P(SocketTest, TCPListen0GetPort) { if (!HostSupportsIPv4()) return; llvm::Expected> sock = - Socket::TcpListen("10.10.12.3:0", false); + Socket::TcpListen("10.10.12.3:0", 5); ASSERT_THAT_EXPECTED(sock, llvm::Succeeded()); ASSER

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -88,6 +88,28 @@ TEST_P(SocketTest, DomainListenConnectAccept) { CreateDomainConnectedSockets(Path, &socket_a_up, &socket_b_up); } +TEST_P(SocketTest, DomainListenGetListeningConnectionURI) { + llvm::SmallString<64> Path; + std::error_code EC = + llvm::sys::fs::crea

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -115,6 +115,18 @@ std::string TCPSocket::GetRemoteConnectionURI() const { return ""; } +std::vector TCPSocket::GetListeningConnectionURI() const { + if (m_listen_sockets.empty()) +return {}; + labath wrote: ```suggestion ``` The common code handles

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/labath approved this pull request. Cool. Thanks. https://github.com/llvm/llvm-project/pull/118330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/118330 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/118330 >From c3226b620bc8f745b92b3aca7b189803a24db788 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Dec 2024 08:29:01 -0800 Subject: [PATCH 1/5] [lldb] For a host socket, add a method to print the listening

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -176,8 +191,9 @@ Status TCPSocket::Listen(llvm::StringRef name, int backlog) { if (host_port->hostname == "*") host_port->hostname = "0.0.0.0"; - std::vector addresses = SocketAddress::GetAddressInfo( - host_port->hostname.c_str(), nullptr, AF_UNSPEC, SOCK_STRE

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -115,6 +121,15 @@ std::string TCPSocket::GetRemoteConnectionURI() const { return ""; } +std::string TCPSocket::GetListeningConnectionURI() const { ashgti wrote: Since the listening sockets are a `std::map` it was very straightforward to adjust this with

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 071da9261b7e94c2d2d4e9d3d4eba1f29115e8ae 0a512cb8e1883a37ef0dfe389de7c59cb1e51c03 --e

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/118330 >From c3226b620bc8f745b92b3aca7b189803a24db788 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Dec 2024 08:29:01 -0800 Subject: [PATCH 1/4] [lldb] For a host socket, add a method to print the listening

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/118330 >From c3226b620bc8f745b92b3aca7b189803a24db788 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Mon, 2 Dec 2024 08:29:01 -0800 Subject: [PATCH 1/3] [lldb] For a host socket, add a method to print the listening

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/118465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8c749ff - [lldb] Fix "exact match" debug_names type queries (#118465)

Author: Pavel Labath Date: 2024-12-03T15:18:59+01:00 New Revision: 8c749ff8aa787049cea4d4f7331493ee17565344 URL: https://github.com/llvm/llvm-project/commit/8c749ff8aa787049cea4d4f7331493ee17565344 DIFF: https://github.com/llvm/llvm-project/commit/8c749ff8aa787049cea4d4f7331493ee17565344.diff

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/117808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix crash in TypeSystemClang::GetIndexofChildMemberWithName. (PR #117808)

@@ -6754,12 +6754,12 @@ size_t TypeSystemClang::GetIndexOfChildMemberWithName( llvm::StringRef field_name = field->getName(); if (field_name.empty()) { CompilerType field_type = GetType(field->getType()); +std::vector save_indices = c

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

@@ -527,7 +527,7 @@ void DebugNamesDWARFIndex::GetTypesWithQuery( ConstString name = query.GetTypeBasename(); std::vector query_context = query.GetContextRef(); - if (query_context.size() <= 1) + if (query_context.size() <= 1 && !query.GetExactMatch()) -

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

@@ -527,7 +527,7 @@ void DebugNamesDWARFIndex::GetTypesWithQuery( ConstString name = query.GetTypeBasename(); std::vector query_context = query.GetContextRef(); - if (query_context.size() <= 1) + if (query_context.size() <= 1 && !query.GetExactMatch()) -

[Lldb-commits] [lldb] [lldb][test] Add test categories for Linux and Darwin tests (PR #116194)

dzhidzhoev wrote: Gentle ping. https://github.com/llvm/llvm-project/pull/116194 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9a4c5a5 - Revert "Re-apply [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (#117079)"

Author: Michael Buch Date: 2024-12-03T11:04:04Z New Revision: 9a4c5a59d4ec0c582f56b221a64889c077f68376 URL: https://github.com/llvm/llvm-project/commit/9a4c5a59d4ec0c582f56b221a64889c077f68376 DIFF: https://github.com/llvm/llvm-project/commit/9a4c5a59d4ec0c582f56b221a64889c077f68376.diff LOG:

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

https://github.com/Michael137 approved this pull request. LGTM, thanks for fixing! https://github.com/llvm/llvm-project/pull/118465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

@@ -527,7 +527,7 @@ void DebugNamesDWARFIndex::GetTypesWithQuery( ConstString name = query.GetTypeBasename(); std::vector query_context = query.GetContextRef(); - if (query_context.size() <= 1) + if (query_context.size() <= 1 && !query.GetExactMatch()) -

[Lldb-commits] [lldb] 51b74bb - Reapply "[lldb] Use the function block as a source for function ranges (#117996)"

Author: Pavel Labath Date: 2024-12-03T11:58:36+01:00 New Revision: 51b74bb9f6457cbe53776a2a35296189c5db52f3 URL: https://github.com/llvm/llvm-project/commit/51b74bb9f6457cbe53776a2a35296189c5db52f3 DIFF: https://github.com/llvm/llvm-project/commit/51b74bb9f6457cbe53776a2a35296189c5db52f3.diff

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes .. in the global namespace The problem was the interaction of #116989 with an optimization in GetTypesWithQuery. The optimization was only correct for non-exact matches, but that didn't matter before this PR

[Lldb-commits] [lldb] [lldb] Fix "exact match" debug_names type queries (PR #118465)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/118465 .. in the global namespace The problem was the interaction of #116989 with an optimization in GetTypesWithQuery. The optimization was only correct for non-exact matches, but that didn't matter before this PR du

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/14176 Here is the relevant piece of th

[Lldb-commits] [lldb] [lldb/DWARF] Remove duplicate type filtering (PR #116989)

labath wrote: I'm looking into this now. https://github.com/llvm/llvm-project/pull/116989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2526d5b - Revert "[lldb] Use the function block as a source for function ranges (#117996)"

Author: Pavel Labath Date: 2024-12-03T10:27:31+01:00 New Revision: 2526d5b1689389da9b194b5ec2878cfb2f4aca93 URL: https://github.com/llvm/llvm-project/commit/2526d5b1689389da9b194b5ec2878cfb2f4aca93 DIFF: https://github.com/llvm/llvm-project/commit/2526d5b1689389da9b194b5ec2878cfb2f4aca93.diff

[Lldb-commits] [lldb] ba14dac - [lldb] Use the function block as a source for function ranges (#117996)

Author: Pavel Labath Date: 2024-12-03T10:21:04+01:00 New Revision: ba14dac481564000339ba22ab867617590184f4c URL: https://github.com/llvm/llvm-project/commit/ba14dac481564000339ba22ab867617590184f4c DIFF: https://github.com/llvm/llvm-project/commit/ba14dac481564000339ba22ab867617590184f4c.diff

[Lldb-commits] [lldb] [lldb] Use the function block as a source for function ranges (PR #117996)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/117996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Remove unused field Platform::m_remote_url (PR #118411)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/118411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/117532 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 59bb9b9 - [lldb] Expose discontinuous functions through SBFunction::GetRanges (#117532)

Author: Pavel Labath Date: 2024-12-03T10:14:33+01:00 New Revision: 59bb9b915ef9137709313190395da56364b92db6 URL: https://github.com/llvm/llvm-project/commit/59bb9b915ef9137709313190395da56364b92db6 DIFF: https://github.com/llvm/llvm-project/commit/59bb9b915ef9137709313190395da56364b92db6.diff

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -115,6 +121,15 @@ std::string TCPSocket::GetRemoteConnectionURI() const { return ""; } +std::string TCPSocket::GetListeningConnectionURI() const { labath wrote: Like I said in , I

[Lldb-commits] [lldb] [lldb] For a host socket, add a method to print the listening address. (PR #118330)

@@ -176,8 +191,9 @@ Status TCPSocket::Listen(llvm::StringRef name, int backlog) { if (host_port->hostname == "*") host_port->hostname = "0.0.0.0"; - std::vector addresses = SocketAddress::GetAddressInfo( - host_port->hostname.c_str(), nullptr, AF_UNSPEC, SOCK_STRE

[Lldb-commits] [lldb] [lldb] Fix the DWARF index cache when index is partial. (PR #118390)

https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/118390 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the DWARF index cache when index is partial. (PR #118390)

@@ -0,0 +1,62 @@ +// REQUIRES: lld + +// Test if we build a mixed binary where one .o file has a .debug_names and +// another doesn't have one, that we save a full or partial index cache. +// Previous versions of LLDB would have ManualDWARFIndex.cpp that would save out +// an ind

[Lldb-commits] [lldb] [lldb] Fix the DWARF index cache when index is partial. (PR #118390)

@@ -0,0 +1,62 @@ +// REQUIRES: lld + +// Test if we build a mixed binary where one .o file has a .debug_names and +// another doesn't have one, that we save a full or partial index cache. +// Previous versions of LLDB would have ManualDWARFIndex.cpp that would save out +// an ind

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/117532 >From 03385da68038c3fd40fc085c8fb1914529116837 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 12 Nov 2024 11:30:39 +0100 Subject: [PATCH 1/2] [lldb] Expose discontinuous functions through SBFunction::Get

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

@@ -0,0 +1,182 @@ +# REQUIRES: x86 labath wrote: The (only?) easy way would be to use a compiler to generate that, but I don't like the tradeoffs that come with that: the `-fbasic-block-sections` is not supported for all (or even most) targets. Most notably, it

[Lldb-commits] [lldb] [lldb] Expose discontinuous functions through SBFunction::GetRanges (PR #117532)

@@ -444,8 +444,11 @@ class Function : public UserID, public SymbolContextScope { Function *CalculateSymbolContextFunction() override; + // DEPRECATED: Use GetAddressRanges instead. labath wrote: Sure. https://github.com/llvm/llvm-project/pull/117532