================
@@ -8,15 +11,7 @@ import { LLDBDapOptions } from "./types";
export class LLDBDapDescriptorFactory
implements vscode.DebugAdapterDescriptorFactory
{
- private lldbDapOptions: LLDBDapOptions;
-
- constructor(lldbDapOptions: LLDBDapOptions) {
- this.lldbDapOptions = lldbDapOptions;
- }
-
- static async isValidDebugAdapterPath(
- pathUri: vscode.Uri,
- ): Promise<Boolean> {
+ static async isValidFile(pathUri: vscode.Uri): Promise<Boolean> {
----------------
ashgti wrote:
I don't think this is doing anything specific for `LLDBDapDescriptorFactory`
and a top level `isValidExe` or `isExecutable` is straight forward to reason vs
`LLDBDapDescriptorFactory.isValidFile`.
https://github.com/llvm/llvm-project/pull/118547
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
