https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben requested changes to this pull request.
@jasonmolenda I think there is a mistake in your range check.
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -6184,7 +6184,14 @@ Status Process::GetMemoryRegionInfo(lldb::addr_t
load_addr,
MemoryRegionInfo &range_info) {
if (const lldb::ABISP &abi = GetABI())
load_addr = abi->FixAnyAddress(load_addr);
- return DoGetMemoryRegionInfo(load_a
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with the formatting fixed.
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
jasonmolenda wrote:
I landed a fix with Pavel's suggestion, and rewrote the commit msg to reflect
what the patch now does.
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/115963
>From f8f1d70d1d9eac6d36c0fa84e2a94c032385da39 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 12 Nov 2024 15:55:15 -0800
Subject: [PATCH 1/5] [lldb] Handle an empty SBMemoryRegionInfo from scripted
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t
load_addr,
MemoryRegionInfo ®ion) {
Status error;
if (auto region_or_err =
- GetInterface().GetMemoryRegionContainingAddress(load_addr, er
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/78343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
anatawa12 wrote:
> Do you need me to push the "merge" button?
Yes please. I don't have merge button.
https://github.com/llvm/llvm-project/pull/115712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/anatawa12 edited
https://github.com/llvm/llvm-project/pull/115712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/116300
This patch is a follow-up to 5b6b0c97ff09de2850577bbabe1f0c296d1c7af1 and adds
extra-null checks before dereferencing the inlined_info pointer.
>From cbd6cd71cdd99db615445d0c5591482a12b61df8 Mon Sep 17 00:
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/116300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/116300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-11-14T16:12:38-08:00
New Revision: 1857d297354fd307d2b30ff69036cc343d2fd692
URL:
https://github.com/llvm/llvm-project/commit/1857d297354fd307d2b30ff69036cc343d2fd692
DIFF:
https://github.com/llvm/llvm-project/commit/1857d297354fd307d2b30ff69036cc343d2fd692.
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/116272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/116300
>From fd5ba55ee1d1231fc0acf19ee124d811da795a41 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 14 Nov 2024 16:09:53 -0800
Subject: [PATCH] [lldb/Target] Add null-check before dereferencing
inl
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/116300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-11-14T15:37:34-08:00
New Revision: 9c7701fa78037af03be10ed168fd3c75a2ed1aef
URL:
https://github.com/llvm/llvm-project/commit/9c7701fa78037af03be10ed168fd3c75a2ed1aef
DIFF:
https://github.com/llvm/llvm-project/commit/9c7701fa78037af03be10ed168fd3c75a2ed1aef.
@@ -1230,6 +1230,57 @@ bool StackFrame::IsHidden() {
return false;
}
+const char *StackFrame::GetFunctionName() {
+ const char *name = nullptr;
+ SymbolContext sc = GetSymbolContext(
+ eSymbolContextFunction | eSymbolContextBlock | eSymbolContextSymbol);
+ if (sc.blo
https://github.com/jimingham commented:
Add the check for a NULL InlinedFunctionInfo return, and this is good to go.
https://github.com/llvm/llvm-project/pull/116298
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/116298
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/116298
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/116298
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. Ideally the SB API is just a shim around the private types.
https://github.com/llvm/llvm-project/pull/116298
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/116298
This patch moves some of the logic implemented in the SBFrame APIs to the
lldb_private::StackFrame class so it can be re-used elsewhere.
>From c5bd8c739816988a6a3c710704fc83a298811bf6 Mon Sep 17 00:00:00 2
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/116272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t
load_addr,
MemoryRegionInfo ®ion) {
Status error;
if (auto region_or_err =
- GetInterface().GetMemoryRegionContainingAddress(load_addr, er
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/116260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2024-11-14T13:27:41-08:00
New Revision: 5d16fbc275d57b88866a2606453ead6a024ffee0
URL:
https://github.com/llvm/llvm-project/commit/5d16fbc275d57b88866a2606453ead6a024ffee0
DIFF:
https://github.com/llvm/llvm-project/commit/5d16fbc275d57b88866a2606453ead6a024ffee0.diff
LOG:
@@ -5046,30 +5026,50 @@ int main(int argc, char *argv[]) {
pause();
}
#endif
+
+ // Initialize LLDB first before we do anything.
+ lldb::SBDebugger::Initialize();
+
+ // Terminate the debugger before the C++ destructor chain kicks in.
+ auto terminate_debugger =
+
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/116260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5046,30 +5026,50 @@ int main(int argc, char *argv[]) {
pause();
}
#endif
+
+ // Initialize LLDB first before we do anything.
+ lldb::SBDebugger::Initialize();
+
+ // Terminate the debugger before the C++ destructor chain kicks in.
+ auto terminate_debugger =
+
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/116272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
This removes the global DAP variable and instead allocates a DAP instance in
main. This should allow us to refactor lldb-dap to enable a server mode that
accepts multiple connections.
---
Patch is 117.71 Ki
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/116272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/116272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t
load_addr,
MemoryRegionInfo ®ion) {
Status error;
if (auto region_or_err =
- GetInterface().GetMemoryRegionContainingAddress(load_addr, er
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/116260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-11-14T11:12:58-08:00
New Revision: c7605bfd4eaf1b0fe46fa91bd0e3f7aa17585d89
URL:
https://github.com/llvm/llvm-project/commit/c7605bfd4eaf1b0fe46fa91bd0e3f7aa17585d89
DIFF:
https://github.com/llvm/llvm-project/commit/c7605bfd4eaf1b0fe46fa91bd0e3f7aa17585d89.d
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/115197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -179,55 +142,34 @@ Status MainLoopPosix::RunImpl::Poll() {
read_fds.push_back(pfd);
}
- if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 &&
+ if (ppoll(read_fds.data(), read_fds.size(),
+/*timeout=*/nullptr,
Jlalond w
@@ -384,6 +313,21 @@ void
MainLoopPosix::ProcessReadObject(IOObject::WaitableHandle handle) {
it->second(*this); // Do the work
}
+void MainLoopPosix::ProcessSignals() {
+ std::vector signals;
Jlalond wrote:
(Uneducated question) Is int actually the cor
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/116269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-11-14T11:12:11-08:00
New Revision: c923ac08f0e9905a5522e9f78118623583a3f845
URL:
https://github.com/llvm/llvm-project/commit/c923ac08f0e9905a5522e9f78118623583a3f845
DIFF:
https://github.com/llvm/llvm-project/commit/c923ac08f0e9905a5522e9f78118623583a3f845.d
https://github.com/Jlalond approved this pull request.
I'm not expert, but everything looks rigorous and you've added a lot of
comments.
I left a few nits and a singular question. I would encourage comments on some
file descriptors for the less knowledgeable of us (namely me!)
https://github.
@@ -179,55 +142,34 @@ Status MainLoopPosix::RunImpl::Poll() {
read_fds.push_back(pfd);
}
- if (ppoll(read_fds.data(), read_fds.size(), nullptr, &sigmask) == -1 &&
+ if (ppoll(read_fds.data(), read_fds.size(),
+/*timeout=*/nullptr,
+/*sigmask=*/n
@@ -17,29 +17,53 @@
#include
#include
#include
+#include
#include
// Multiplexing is implemented using kqueue on systems that support it (BSD
-// variants including OSX). On linux we use ppoll, while android uses pselect
-// (ppoll is present but not implemented proper
https://github.com/Jlalond approved this pull request.
LGTM @JDevlieghere!
https://github.com/llvm/llvm-project/pull/116269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This fixes a warning that '\class' command should not be used in a comment
attached to a non-class declaration. It also makes the Doxygen comments in
SBSaveCoreOptions consistent with the rest of LL
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/116269
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/116269
This fixes a warning that '\class' command should not be used in a comment
attached to a non-class declaration. It also makes the Doxygen comments in
SBSaveCoreOptions consistent with the rest of LLDB.
>F
@@ -851,8 +851,7 @@ void CommandInterpreter::LoadCommandDictionary() {
// now "bt 3" is the preferred form, in line with gdb.
if (bt_regex_cmd_up->AddRegexCommand("^([[:digit:]]+)[[:space:]]*$",
"thread backtrace -c %1") &&
-
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/116260
>From bc771d2c7dc223c353fbfca9dbe491e08311950b Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 14 Nov 2024 09:03:33 -0800
Subject: [PATCH 1/3] [lldb] Support any flag to _regexp-bt
In particular, this al
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/116260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/116260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -851,8 +851,7 @@ void CommandInterpreter::LoadCommandDictionary() {
// now "bt 3" is the preferred form, in line with gdb.
if (bt_regex_cmd_up->AddRegexCommand("^([[:digit:]]+)[[:space:]]*$",
"thread backtrace -c %1") &&
-
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/116068
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,61 @@
+"""Test that forward declaration of a c++ template gets resolved correctly."""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+
+
+class ForwardDeclarationTestCase(TestBas
https://github.com/Michael137 commented:
Very interesting find, I *think* this makes sense since the `FindTypes` query
expects to find template parameters if we're looking up templates. And given
this API is used specifically to perform these kinds of queries, this LGTM. But
please confirm if
jimingham wrote:
> Ok, tell me what you think of this proposal:
>
> 1. Each thread plan has a virtual `GetDirection()` method returning
> `RunDirection`. Existing plans other than `ThreadBasePlan` return
> `eRunForward`.
> 2. There is a per-process `base direction` flag.
> `ThreadBasePlan::Ge
Author: Dave Lee
Date: 2024-11-14T09:28:27-08:00
New Revision: 593be023615a456ca6ee0ef9bedc21301d73b73c
URL:
https://github.com/llvm/llvm-project/commit/593be023615a456ca6ee0ef9bedc21301d73b73c
DIFF:
https://github.com/llvm/llvm-project/commit/593be023615a456ca6ee0ef9bedc21301d73b73c.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/116089
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/116260
>From bc771d2c7dc223c353fbfca9dbe491e08311950b Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 14 Nov 2024 09:03:33 -0800
Subject: [PATCH 1/2] [lldb] Support any flag to _regexp-bt
In particular, this al
labath wrote:
(Closed by mistake, I'm still waiting on #115197 though)
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
In any case I am OOO and mostly offline until Nov 26.
Rob
https://github.com/llvm/llvm-project/pull/115197
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/116260
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c9719ad5cd7e0fa65b52333f28aa62c05052d989
bc771d2c7dc223c353fbfca9dbe491e08311950b --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
In particular, this allows `bt -u`.
---
Full diff: https://github.com/llvm/llvm-project/pull/116260.diff
2 Files Affected:
- (modified) lldb/source/Interpreter/CommandInterpreter.cpp (+1-2)
- (modified)
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/116260
In particular, this allows `bt -u`.
>From bc771d2c7dc223c353fbfca9dbe491e08311950b Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 14 Nov 2024 09:03:33 -0800
Subject: [PATCH] [lldb] Support any flag to
https://github.com/cmtice closed
https://github.com/llvm/llvm-project/pull/115666
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: cmtice
Date: 2024-11-14T08:53:16-08:00
New Revision: 310351d94d7abab5d29e4171aca9dc61a97209cc
URL:
https://github.com/llvm/llvm-project/commit/310351d94d7abab5d29e4171aca9dc61a97209cc
DIFF:
https://github.com/llvm/llvm-project/commit/310351d94d7abab5d29e4171aca9dc61a97209cc.diff
LOG: [
kuilpd wrote:
Ping
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath converted_to_draft
https://github.com/llvm/llvm-project/pull/115836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -407,6 +406,15 @@ CompileUnit *Function::GetCompileUnit() { return
m_comp_unit; }
const CompileUnit *Function::GetCompileUnit() const { return m_comp_unit; }
+Address Function::GetAddress() const {
+ if (m_ranges.empty())
+return Address();
+ // We're using a (DWARF
https://github.com/labath reopened
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> I'm not sure what one needs to do that
You need to be a member of the LLVM organization (i.e. have commit access).
This has tripped me up a few times as well.
https://github.com/llvm/llvm-project/pull/115197
___
lldb-commits ma
@@ -407,6 +406,15 @@ CompileUnit *Function::GetCompileUnit() { return
m_comp_unit; }
const CompileUnit *Function::GetCompileUnit() const { return m_comp_unit; }
+Address Function::GetAddress() const {
+ if (m_ranges.empty())
+return Address();
+ // We're using a (DWARF
JDevlieghere wrote:
Is the real, underlying problem that `skipUnlessDarwin` is checking the host
platform instead of the target platform? I'm somewhat worried about adding a
category that (at first glance) competes with the existing decorators and the
associated risk of folks misunderstanding/
labath wrote:
Any brave souls? :)
@rocallahan, I can't add you as a reviewer (I'm not sure what one needs to do
that), but I would totally go with your LGTM :)
https://github.com/llvm/llvm-project/pull/115197
___
lldb-commits mailing list
lldb-commi
https://github.com/labath approved this pull request.
I think I'm fine with this. I'd probably skip the windows category for now,
since we're also not adding categories any of the bsd variants.
https://github.com/llvm/llvm-project/pull/116194
___
lldb
@@ -288,8 +288,15 @@ Status ScriptedProcess::DoGetMemoryRegionInfo(lldb::addr_t
load_addr,
MemoryRegionInfo ®ion) {
Status error;
if (auto region_or_err =
- GetInterface().GetMemoryRegionContainingAddress(load_addr, er
https://github.com/labath approved this pull request.
Okay, I think I'm satisfied by the explanation. Thanks for your patience. Do
you need me to push the "merge" button?
https://github.com/llvm/llvm-project/pull/115712
___
lldb-commits mailing list
l
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/anjenner updated
https://github.com/llvm/llvm-project/pull/115331
>From d16492dc12891cf15e41225abff890462c9f8460 Mon Sep 17 00:00:00 2001
From: Andrew Jenner
Date: Thu, 7 Nov 2024 10:47:42 -0500
Subject: [PATCH] Modify the localCache API to require an explicit commit on
Cach
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/116196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
> > Considering that there's "REQUIRES: system-windows" on top of the test,
> > maybe I'll turn it off for target-linux at all?
>
> This problem is not really linux specific any os!=windows will have the same
> problem. I think `REQUIRES: target-windows` would be better.
Tha
Author: Dmitry Vasilyev
Date: 2024-11-14T15:00:54+04:00
New Revision: 905256ad2ff136ec15e4c1a822412c87881876b8
URL:
https://github.com/llvm/llvm-project/commit/905256ad2ff136ec15e4c1a822412c87881876b8
DIFF:
https://github.com/llvm/llvm-project/commit/905256ad2ff136ec15e4c1a822412c87881876b8.dif
dzhidzhoev wrote:
> How are you going to use these categories exactly? Is this level of detail
> enough for your use case?
The initial idea was to disable tests from `lldb/test/API/macosx` directory on
lldb-remote-linux-* builders. Most of them are already disabled, but they're
disabled with
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/116198
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
So it was unsupported so it never ran on that bot. Then it was changed to xfail
for remote, so it passed on one bot but was broken on another.
This change narrows the xfail to the one configuration that fails.
In that case, LGTM.
ht
@@ -39,6 +41,7 @@
"std-module": "Tests related to importing the std module",
"stresstest": "Tests related to stressing lldb limits",
"watchpoint": "Watchpoint-related tests",
+"windows": "Windows-related tests",
DavidSpickett wrote:
What's goin
https://github.com/DavidSpickett commented:
I'm a bit skeptical about saying "X related tests" given that it will include
things like core files that can be run anywhere, but we also can't say "tests
that run on X" because we'd have to label everything individually.
How are you going to use th
1 - 100 of 108 matches
Mail list logo
