rocallahan wrote:
I adapted the code from here
https://github.com/llvm/llvm-project/blob/a62768c427ec1f34d7c3823021a6c5a794709103/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py#L516
into `lldbgdbproxy.py`:
```
+lldb_server_exe = lldbgdbserverutils.get_lldb_server
medismailben wrote:
Answering
https://github.com/llvm/llvm-project/pull/99736#issuecomment-2408387985 and
https://github.com/llvm/llvm-project/pull/99736#issuecomment-2408398073here:
> Is there a way to run the full post-merge CI test suite against a Github PR?
Not that I'm aware of, unfortun
medismailben wrote:
Answered in your new PR.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rocallahan wrote:
> added @skipIfDarwin markers to the TestReverseContinueBreakpoints.py and
> TestReverseContinueNotSupported.py API tests because lldb-server is not
> supported in gdbserver mode on Darwin systems
So there is no LLDB-based daemon that implements the gdbserver protocol on
Dar
https://github.com/rocallahan updated
https://github.com/llvm/llvm-project/pull/112079
>From c373425ab4be848bb376d2710e13efafb6058d11 Mon Sep 17 00:00:00 2001
From: Robert O'Callahan
Date: Fri, 19 Jul 2024 22:46:42 +1200
Subject: [PATCH] [lldb] Implement basic support for reverse-continue
This
https://github.com/rocallahan updated
https://github.com/llvm/llvm-project/pull/112079
>From 9f33f8e5e0efb74772022c4ffadb65a6aefedf55 Mon Sep 17 00:00:00 2001
From: Robert O'Callahan
Date: Fri, 19 Jul 2024 22:46:42 +1200
Subject: [PATCH] [lldb] Implement basic support for reverse-continue
This
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
79d695f049343c96eccbce9c06357256bc567be3...6bd33589417195eafe945f2d2f57b01352f56568
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 79d695f049343c96eccbce9c06357256bc567be3
6bd33589417195eafe945f2d2f57b01352f56568 --e
rocallahan wrote:
I have created a new PR #112079 to continue work on this.
Is there a way to run the full post-merge CI test suite against a Github PR?
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.ll
https://github.com/rocallahan edited
https://github.com/llvm/llvm-project/pull/112079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Robert O'Callahan (rocallahan)
Changes
This commit only adds support for the
`SBProcess::ReverseContinue()` API. A user-accessible command for this will
follow in a later commit.
This feature depends on a gdbserver implementation (e.g. `rr
https://github.com/rocallahan created
https://github.com/llvm/llvm-project/pull/112079
This commit only adds support for the
`SBProcess::ReverseContinue()` API. A user-accessible command for this will
follow in a later commit.
This feature depends on a gdbserver implementation (e.g. `rr`) prov
https://github.com/medismailben approved this pull request.
Makes sense, LGTM!
https://github.com/llvm/llvm-project/pull/112062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/112062
>From c40bb5f2b7d8ac95faa14579cd55bd2885ea9705 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Fri, 11 Oct 2024 17:02:39 -0700
Subject: [PATCH] [lldb] Rename CommandReturnObject::Get.*Data -> Get.*Strin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
In a later commit, I want to add a method to access diagnostics as actual
structured data, which will make these function names rather confusing.
---
Full diff: https://github.com/llvm/llvm-project/pul
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/112062
In a later commit, I want to add a method to access diagnostics as actual
structured data, which will make these function names rather confusing.
>From e0f65d0a82d8ba5b7375b158a88e2680c4bf40c3 Mon Sep 17
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
m_fallback.GetTypesWithQuery(query, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, const CompilerDeclContext &parent_decl_ctx,
+llvm::function_ref callback) {
+
@@ -71,6 +71,14 @@ class DWARFIndex {
virtual void
GetTypesWithQuery(TypeQuery &query,
llvm::function_ref callback);
+ /// Get namespace DIEs whose base name match \param name with \param
clayborg wrote:
This comment is out of date now
@@ -151,3 +151,19 @@ bool DWARFIndex::ProcessTypeDIEMatchQuery(
return true;
return callback(die);
}
+
+void DWARFIndex::GetNamespacesWithParents(
+ConstString name, const CompilerDeclContext &parent_decl_ctx,
+llvm::function_ref callback) {
+ GetNamespaces(name,
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
m_fallback.GetTypesWithQuery(query, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, const CompilerDeclContext &parent_decl_ctx,
+llvm::function_ref callback) {
+
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/111929
>From 82b48c688943a3e2a61288a08955148a2d240952 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 11 Oct 2024 14:55:03 -0700
Subject: [PATCH] [lldb] Move SBLanguages.h out of API tree
This patch
JDevlieghere wrote:
> So, I have a couple of thoughts:
>
> * the system log currently writes to stdout on windows. This was sort of
> okay, when we were writing there only sporadically, but I think piping all of
> that here would make lldb unusable. If we want to go down this path, I think
>
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Windows doesn't have a built-in system log. Previously we got away with writing
to stdout and stderr because it was used only sporadically. As we're trying to
make the system log more useful on the
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/112052
Windows doesn't have a built-in system log. Previously we got away with writing
to stdout and stderr because it was used only sporadically. As we're trying to
make the system log more useful on the other p
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
https://github.com/mentlerd updated
https://github.com/llvm/llvm-project/pull/111892
>From b1e6178b1130135262884d99262716fcc0ada86e Mon Sep 17 00:00:00 2001
From: David Mentler
Date: Mon, 7 Oct 2024 21:46:50 +0200
Subject: [PATCH 1/8] Make existing tests break
---
.../data-formatter-stl/libcx
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
jimingham wrote:
I would feel a little worse about that if the API didn't explicitly say that
the values of the enum might change meanings. So it explicitly says it isn't
stable...
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits ma
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Renato Golin
,Eric Astor
Message-ID:
In-Reply-To:
https://github.com/ericastor closed
https://github.com/llvm/llvm-project/pull/110334
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -6,27 +6,30 @@
UNALIGNED_INSTANCE_PATTERN_HEAP = ALIGNED_INSTANCE_PATTERN_HEAP[1:]
-def GetAlignedRange(test_base):
+def GetAlignedRange(test_base, shrink=False):
frame = test_base.thread.GetSelectedFrame()
ex = frame.EvaluateExpression("aligned_string_ptr")
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
zeroomega wrote:
> > Not all lldb tests require `make` to run and it feels wrong to me to
> > ma
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
JDevlieghere wrote:
> Not all lldb tests require `make` to run and it feels wrong to me to mandat
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
zeroomega wrote:
Hi,
I noticed that our LLDB Windows builders all failed after this change is la
zeroomega wrote:
Hi,
I noticed that our LLDB Windows builders all failed after this change is landed:
```
CMake Error at
C:/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/CMakeLists.txt:60 (message):
LLDB tests require 'make' tool. Please pass via `LLDB_TEST_MAKE` (or
otherwise disable te
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mentlerd wrote:
> A high-level comment: could we split up `FindLibCppStdFunctionCallableInfo`?
> Exactly how I haven't fully thought through. But possibly a function for each
> of the callable cases?
Sure! I think a natural split could be to make a version which returns a
(possibly dummy) `Va
@@ -6,27 +6,30 @@
UNALIGNED_INSTANCE_PATTERN_HEAP = ALIGNED_INSTANCE_PATTERN_HEAP[1:]
-def GetAlignedRange(test_base):
+def GetAlignedRange(test_base, shrink=False):
frame = test_base.thread.GetSelectedFrame()
ex = frame.EvaluateExpression("aligned_string_ptr")
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -191,14 +191,6 @@ llvm::Error
ItaniumABILanguageRuntime::TypeHasVTable(CompilerType type) {
type = pointee_type;
}
- // Make sure this is a class or a struct first by checking the type class
- // bitfield that gets returned.
- if ((type.GetTypeClass() & (eTypeCl
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
medismailben wrote:
> > I agree with that, but the argument here was going the other way.
> > lldb-enumerations.h are a base set of enumerations that anybody using LLDB,
> > either lldb_private or the SB API's are free to use. But the SB API's are
> > purely wrappers around lldb_private API's,
bulbazord wrote:
> I agree with that, but the argument here was going the other way.
> lldb-enumerations.h are a base set of enumerations that anybody using LLDB,
> either lldb_private or the SB API's are free to use. But the SB API's are
> purely wrappers around lldb_private API's, and so sho
medismailben wrote:
> I'm just wondering, would this patch run into the same issue that I ran into
> on #111907 where this could cause a clean build to fail since the
> `SourceLangugageNames` file wouldn't be generated before it gets included in
> `lldb-enumerations.h`?
Possibly, we'll see wh
chelcassanova wrote:
I'm just wondering, would this patch run into the same issue that I ran into on
https://github.com/llvm/llvm-project/pull/111907 where this could cause a clean
build to fail since the `SourceLangugageNames` file wouldn't be generated
before it gets included in `lldb-enumer
@@ -70,6 +70,8 @@ class CommandObjectMultiword : public CommandObject {
return m_subcommand_dict;
}
+ std::string GetTopSubcommands(int count);
jimingham wrote:
It would have to be really clear that's what we were doing, however. If you
saw this list
@@ -565,6 +565,48 @@ void DebugNamesDWARFIndex::GetTypesWithQuery(
m_fallback.GetTypesWithQuery(query, callback);
}
+void DebugNamesDWARFIndex::GetNamespacesWithParents(
+ConstString name, const CompilerDeclContext &parent_decl_ctx,
+llvm::function_ref callback) {
+
DavidSpickett wrote:
Also X86 may support the memory allocation packets and not need to call mmap to
get JIT memory. So if making it a function call doesn't reproduce it, try
hacking out support for `_M`.
https://github.com/llvm/llvm-project/pull/99736
_
DavidSpickett wrote:
The problem is not to do with the debug symbols, or it being a "properly
remote" connection due to the proxy and that messing up search paths.
It's because evaluating an expression using JIT requires us to send a `vCont`
and something goes wrong there, it appears to be mis
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/110901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-10-11T09:08:52-07:00
New Revision: 089227feaf0efb5e540783a5542655e25669e7d8
URL:
https://github.com/llvm/llvm-project/commit/089227feaf0efb5e540783a5542655e25669e7d8
DIFF:
https://github.com/llvm/llvm-project/commit/089227feaf0efb5e540783a5542655e25669e7d8.diff
@@ -0,0 +1,418 @@
+import os
+import os.path
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.gdbclientutils import *
+from lldbsuite.test.lldbgdbproxy import *
+import lldbgdbserverutils
+import re
+
+
+class ThreadSnapshot:
+def __init__(self, thread_
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/111891
>From 4493bf07c8b18dac39a2a421f97fa34cd15a6031 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 10 Oct 2024 14:48:08 -0400
Subject: [PATCH 1/2] [LLDB]Provide clearer error message for invalid commands.
Somet
@@ -194,28 +194,50 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Renato Golin
Message-ID:
In-Reply-To:
https://github.com/AaronBallman approved this pull request.
LGTM, though we should probably add a release note to
clang/docs/ReleaseNotes.rst so users know that the plugin system got a bit more
functionality.
@@ -194,28 +194,50 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
@@ -70,6 +70,8 @@ class CommandObjectMultiword : public CommandObject {
return m_subcommand_dict;
}
+ std::string GetTopSubcommands(int count);
oontvoo wrote:
Will rename this to Jim's suggestion.
I like Pavel's idea of having this returning the popula
DavidSpickett wrote:
The only info I can get out of the call to `__mmap` is that it's frame 0 is at
`0x` aka "the process died for some reason". I'm thinking that
something is preventing us finding the debug info files because this is a
"remote" not a local server, haven't found what y
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/111891
>From 4493bf07c8b18dac39a2a421f97fa34cd15a6031 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 10 Oct 2024 14:48:08 -0400
Subject: [PATCH] [LLDB]Provide clearer error message for invalid commands.
Sometimes
DavidSpickett wrote:
So on x86, either `false_condition` doesn't require JIT, or it does and the
mmap found is fine. I tried changing it to `0` or `false`, and while this will
fall back to an interpreter, the lldb-server appears to have already died by
the time that finishes.
https://github.c
DavidSpickett wrote:
This is something to do with evaluating `false_condition`.
With a normal session we see these libraries:
```
(lldb) image list
[ 0] 371298DF 0xa000
/home/david.spickett/build-llvm-aarch64/lldb-test-build.noindex/functionalities/reverse-execution/TestReverseCont
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/111980
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-10-11T14:14:04+01:00
New Revision: a2bd5db00d07bc28fcfb3350b9d50e72e6350cba
URL:
https://github.com/llvm/llvm-project/commit/a2bd5db00d07bc28fcfb3350b9d50e72e6350cba
DIFF:
https://github.com/llvm/llvm-project/commit/a2bd5db00d07bc28fcfb3350b9d50e72e6350cba.diff
DavidSpickett wrote:
I don't think so, it's used to generate dotest.py on all platforms I think.
Perhaps my cmake is being strict / less strict? The funny thing is, I can see
`LLDB_TEST_MAKE` set in the cache even when the build breaks.
https://github.com/llvm/llvm-project/pull/111980
https://github.com/weliveindetail approved this pull request.
Interesting! Your changes look fine, as they are symmetric with what we do here
for dsymutil. I just wonder why I didn't hit that. Is this a separate test
driver for Linux?
https://github.com/llvm/llvm-project/pull/111980
__
DavidSpickett wrote:
Putting this in review because I've zero idea why this fixes it. Without it I
get this on a rebuild:
```
Traceback (most recent call last):
File
"/home/david.spickett/llvm-project/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py",
line 67
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Fixes 0e913237871e8c9290e82be30be8b3484952eee0 /
https://github.com/llvm/llvm-project/pull/111531
For reasons I can't explain, a clean build works fine for me, and all the bots
are working fine. But
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/111980
Fixes 0e913237871e8c9290e82be30be8b3484952eee0 /
https://github.com/llvm/llvm-project/pull/111531
For reasons I can't explain, a clean build works fine for me, and all the bots
are working fine. But if I
Author: David Spickett
Date: 2024-10-11T11:00:07Z
New Revision: d941254da94c8a5897689a74012a57de279c2c9e
URL:
https://github.com/llvm/llvm-project/commit/d941254da94c8a5897689a74012a57de279c2c9e
DIFF:
https://github.com/llvm/llvm-project/commit/d941254da94c8a5897689a74012a57de279c2c9e.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This commit essentially reverts https://reviews.llvm.org/D30453.
In #109961, objcopy util search code was added to dotest.py. dotest.py
should use llvm-X by default if no path to a utility X is pro
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/111977
This commit essentially reverts https://reviews.llvm.org/D30453.
In #109961, objcopy util search code was added to dotest.py. dotest.py should
use llvm-X by default if no path to a utility X is provided exte
labath wrote:
> (btw, @labath is the alignment miscalculation still causing issues for you
> internally? or did you find a workaround?)
The fire has been extinguished by #110648, but it's not ideal that any
structure with a [[no_unique_address]] is treated as packed. It's not causing
any issu
DavidSpickett wrote:
Failed on Arm and AArch64:
```
FAIL: LLDB
(/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) ::
test_reverse_continue_skip_breakpoint
(TestReverseContinueBreakpoints.TestReverseContinueBreakpoints)
lldb-server exiting...
error: stopped due to an error
Michael137 wrote:
Can we do this for all the `no_unique_address-...` tests? Would be nice if they
were all in the same place. I'm not sure I added `--target` in all of them, but
probably should?
https://github.com/llvm/llvm-project/pull/111902
___
ll
Michael137 wrote:
> So does that mean that the `strip` coming with xcode is not `llvm-strip` ? I
> did not expect that..
>
> I don't suppose anyone has any background on this that they can share? :)
Yea pretty sure it's not. Just based on the options it accepts, etc.
Someone else might have mo
Michael137 wrote:
ping
(btw, @labath is the alignment miscalculation still causing issues for you
internally? or did you find a workaround?)
https://github.com/llvm/llvm-project/pull/97443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
Author: Dmitry Vasilyev
Date: 2024-10-11T12:56:42+04:00
New Revision: b222f319306a9cad9ac11183b7036ff45097c26f
URL:
https://github.com/llvm/llvm-project/commit/b222f319306a9cad9ac11183b7036ff45097c26f
DIFF:
https://github.com/llvm/llvm-project/commit/b222f319306a9cad9ac11183b7036ff45097c26f.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/111902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/108170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/111902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > A couple of quick notes:
> >
> > * are you sure that ObjectFileELF is the best thing to start with here?
> > Based on the name, I would expect that ObjectFilePECOFF would be a better
> > baseline. Or maybe the object file format is different enough from all of
> > the existi
slydiman wrote:
> The right fix is to move this test into the x86 subdir.
Done.
https://github.com/llvm/llvm-project/pull/111902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/111902
>From 7827659341b5633d8e555f7ea783a36a1fa0b574 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 10 Oct 2024 23:37:57 +0400
Subject: [PATCH] [lldb][test] Fixed the test
`no_unique_address-with-bitfield
labath wrote:
So does that mean that the `strip` coming with xcode is not `llvm-strip` ? I
did not expect that..
I don't suppose anyone has any background on this that they can share? :)
https://github.com/llvm/llvm-project/pull/111842
___
lldb-commi
https://github.com/labath commented:
I think this is a very interesting patch and, at some point, I wanted to do
something similar as well. At the same time, I am somewhat worried about the
performance impact of the extra lookups.
I think we may want to implement this in a slightly different ma
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/111892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -174,6 +174,233 @@ CPPLanguageRuntime::FindLibCppStdFunctionCallableInfo(
if (!valobj_sp)
return optional_info;
+ // std::function has many variants, try to disambiguate
+ ValueObjectSP func_as_base_ptr;
+ {
+ValueObjectSP outer_f = valobj_sp->GetChildMemberWit
@@ -191,14 +191,6 @@ llvm::Error
ItaniumABILanguageRuntime::TypeHasVTable(CompilerType type) {
type = pointee_type;
}
- // Make sure this is a class or a struct first by checking the type class
- // bitfield that gets returned.
- if ((type.GetTypeClass() & (eTypeCl
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/111892
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
Thanks for putting this together! Looks like non-trivial amount of
investigation.
On the first pass, I think this seems like a reasonable (and more maintainable)
alternative to what we're currently doing.
Using the `TypeSystem` to fish out the various
antmox wrote:
Hi, could this patch be the cause of lldb-aarch64-windows bot failure ?
https://lab.llvm.org/buildbot/#/builders/141/builds/3100
https://github.com/llvm/llvm-project/pull/108495
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
labath wrote:
> > With this in mind, deleting the file is representative of an editor wanting
> > to save the file using the deletion strategy,...
> > Yes. I had meant it is not representative of what Android Studio (or _some_
> > editors) does.
>
> > think it's not our goal here to ensure the
@@ -194,28 +194,50 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
@@ -3,8 +3,10 @@
# RUN: %clang_host -g -O0 %S/Inputs/main.c -o %t.out
# RUN: %lldb -b -o 'help breakpoint set' -o 'breakpoint set -f main.c -l 2 -u
21' %t.out | FileCheck %s --check-prefix HELP --check-prefix CHECK
# RUN: %lldb -b -o 'help _regexp-break' -o 'b main.c:2:21' %t.
@@ -194,28 +194,50 @@ void CommandObjectMultiword::Execute(const char
*args_string,
std::string error_msg;
const size_t num_subcmd_matches = matches.GetSize();
- if (num_subcmd_matches > 0)
+ if (num_subcmd_matches > 0) {
error_msg.assign("ambiguous command ");
-
@@ -70,6 +70,8 @@ class CommandObjectMultiword : public CommandObject {
return m_subcommand_dict;
}
+ std::string GetTopSubcommands(int count);
labath wrote:
This is definitely a topic for another patch, but I actually think it would be
really cool if
1 - 100 of 105 matches
Mail list logo
