JDevlieghere wrote:

> So, I have a couple of thoughts:
> 
> * the system log currently writes to stdout on windows. This was sort of 
> okay, when we were writing there only sporadically, but I think piping all of 
> that here would make lldb unusable. If we want to go down this path, I think 
> we should make `Host::SystemLog` a noop on windows (until someone comes up 
> with a better implementation)

https://github.com/llvm/llvm-project/pull/112052

Regarding limiting the output, I'm happy to draw the line at `LLDB_LOG_ERRORV`. 
The system log is pretty cheap on our platform and I assumed it's the same on 
Linux, so personally I would hope it doesn't deter anyone from using 
`LLDB_LOG_ERROR`. 

@adrian-prantl do you want the system log to include the dropped errors in 
`Status`. If so we'll need to promote that to use `LLDB_LOG_ERROR` instead. 

https://github.com/llvm/llvm-project/pull/111911
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to