https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/104589
>From c6962437499858643b8112bcc1c7d155d3c588a9 Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Mon, 12 Aug 2024 14:53:31 +
Subject: [PATCH 1/4] [lldb-dap] Implement value locations for function
https://github.com/compnerd closed
https://github.com/llvm/llvm-project/pull/106443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Andrew Rogers
Date: 2024-09-24T20:00:34-07:00
New Revision: 18b9d49ce3370c012fdd04ec87d854d53293f6a6
URL:
https://github.com/llvm/llvm-project/commit/18b9d49ce3370c012fdd04ec87d854d53293f6a6
DIFF:
https://github.com/llvm/llvm-project/commit/18b9d49ce3370c012fdd04ec87d854d53293f6a6.diff
compnerd wrote:
Going to go ahead and merge this since there/s not been any additional feedback.
https://github.com/llvm/llvm-project/pull/106443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
jimingham wrote:
I can't delete your branch, however, if you had wanted to do that.
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
Done.
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ryan Mansfield
Date: 2024-09-24T16:48:27-07:00
New Revision: 4494c54326fe33d19c14df851188f867b14ded2a
URL:
https://github.com/llvm/llvm-project/commit/4494c54326fe33d19c14df851188f867b14ded2a
DIFF:
https://github.com/llvm/llvm-project/commit/4494c54326fe33d19c14df851188f867b14ded2a.diff
jeffreytan81 wrote:
I have no idea how to do stack PR review well in github. Here is the second PR
with namespace lookup diffing from my repo:
https://github.com/jeffreytan81/llvm-project/pull/2 if anyone wants to see.
Unfortunately, if I am diffing from master llvm-project, it is showing both
@@ -486,19 +603,37 @@ bool
CommandObjectExpression::EvaluateExpression(llvm::StringRef expr,
result.SetStatus(eReturnStatusSuccessFinishResult);
} else {
-const char *error_cstr = result_valobj_sp->GetError().AsCString();
-if (error_cstr && error
@@ -8,6 +8,7 @@
#include "lldb/Utility/Status.h"
+#include "lldb/Expression/DiagnosticManager.h"
medismailben wrote:
Is this addition necessary ? It doesn't look like anything else has been added
to this file
https://github.com/llvm/llvm-project/pull/10647
https://github.com/medismailben approved this pull request.
This is pretty cool! LGTM with comment!
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1887,7 +1887,8 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
CommandReturnObject &result,
bool force_repeat_command) {
std::string command_string(command_line);
- std::st
https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -61,8 +65,50 @@ std::string DiagnosticManager::GetString(char separator) {
stream << message.drop_front(severity_pos + severity.size());
stream << separator;
}
+ return str;
+}
- return ret;
+void DiagnosticManager::Dump(Log *log) {
+ if (!log)
+return;
https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with comments!
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,16 +33,16 @@ class RemoteAwarePlatformTester : public
RemoteAwarePlatform {
MOCK_METHOD0(CalculateTrapHandlerSymbolNames, void());
MOCK_METHOD2(ResolveExecutable,
- std::pair(const ModuleSpec &,
- const FileSp
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -224,6 +224,14 @@ const char *Status::AsCString(const char
*default_error_str) const {
if (!m_string.empty() && m_string[m_string.size() - 1] == '\n')
m_string.pop_back();
+ // FIXME: Workaround for ErrorList[ExpressionError, ...].
+ if (m_error.isA()) {
+w
@@ -27,15 +27,15 @@ TEST(StatusTest, Formatv) {
}
TEST(StatusTest, ErrorConstructor) {
- EXPECT_TRUE(Status(llvm::Error::success()).Success());
+ EXPECT_TRUE(Status::FromError(llvm::Error::success()).Success());
- Status eagain(
+ Status eagain = Status::FromError(
@@ -254,14 +256,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
rjmansfield wrote:
Could someone with commit access please merge on my behalf? Thanks.
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-09-24T15:43:34-07:00
New Revision: ce1f01b887ea5945ec3ffb45e05e674804d5d7a7
URL:
https://github.com/llvm/llvm-project/commit/ce1f01b887ea5945ec3ffb45e05e674804d5d7a7
DIFF:
https://github.com/llvm/llvm-project/commit/ce1f01b887ea5945ec3ffb45e05e674804d5d7a7.diff
@@ -510,8 +510,9 @@ def start(self):
self._thread.start()
def stop(self):
-self._thread.join()
-self._thread = None
+if self._thread is not None:
jimingham wrote:
Ah, cool.
https://github.com/llvm/llvm-project/pull/99736
_
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/109851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/vogelsgesang updated
https://github.com/llvm/llvm-project/pull/108870
>From 04daaac0eade25a439856bbb287e15860aba1dfd Mon Sep 17 00:00:00 2001
From: Adrian Vogelsgesang
Date: Tue, 27 Aug 2024 17:34:11 +
Subject: [PATCH 1/8] [lldb][libc++] Hide all libc++ implementation det
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/109853
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-09-24T17:27:09-04:00
New Revision: df4f828938db807fc7c4611896fe9659af482e81
URL:
https://github.com/llvm/llvm-project/commit/df4f828938db807fc7c4611896fe9659af482e81
DIFF:
https://github.com/llvm/llvm-project/commit/df4f828938db807fc7c4611896fe9659af482e81.diff
LOG
https://github.com/bulbazord approved this pull request.
LGTM. One thing to note is that llvm's ValueType struct has an additional
uint64_t element for a section index. I wonder if LLDB can make use of that
element for something useful after some additional refactors?
https://github.com/llvm/l
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript(
result.SetStatus(eReturnStatusSuccessFinishNoResult);
result.AppendMessageWithFormat("Session's transcripts saved to %s\n",
output_file->c_str());
+ if (!GetSaveTranscript())
+
rocallahan wrote:
I see @clayborg still has a "change requested" hold on this PR. As far as I can
tell all his comments have been addressed.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
https://github.com/rocallahan updated
https://github.com/llvm/llvm-project/pull/99736
>From 4bc3e8453a2fffa7c444ed9aa4bdc51e8e54569f Mon Sep 17 00:00:00 2001
From: Robert O'Callahan
Date: Fri, 19 Jul 2024 22:46:42 +1200
Subject: [PATCH] [lldb] Implement basic support for reverse-continue
This
@@ -203,11 +203,17 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
return error;
}
-Status ProcessWindows::DoResume() {
+Status ProcessWindows::DoResume(RunDirection direction) {
rocallahan wrote:
The decision was to use a direction flag.
https
@@ -3169,6 +3176,7 @@ void PruneThreadPlans();
// m_currently_handling_do_on_removals are true,
// Resume will only request a resume, using this
// flag to check.
+ lldb::RunDirection m_last_run_d
@@ -1129,10 +1129,15 @@ class Process : public
std::enable_shared_from_this,
/// \see Thread:Resume()
/// \see Thread:Step()
/// \see Thread:Suspend()
- virtual Status DoResume() {
+ virtual Status DoResume(lldb::RunDirection direction) {
rocallahan wr
@@ -182,10 +182,17 @@ void ScriptedProcess::DidResume() {
m_pid = GetInterface().GetProcessID();
}
-Status ScriptedProcess::DoResume() {
+Status ScriptedProcess::DoResume(RunDirection direction) {
rocallahan wrote:
The decision was to use a direction flag.
@@ -52,7 +52,7 @@ class ScriptedProcess : public Process {
void DidResume() override;
- Status DoResume() override;
+ Status DoResume(lldb::RunDirection direction) override;
rocallahan wrote:
The decision was to use a direction flag.
https://github.com/
@@ -90,7 +90,7 @@ class ProcessKDP : public lldb_private::Process {
// Process Control
lldb_private::Status WillResume() override;
- lldb_private::Status DoResume() override;
+ lldb_private::Status DoResume(lldb::RunDirection direction) override;
rocalla
@@ -111,7 +111,7 @@ class ProcessGDBRemote : public Process,
// Process Control
Status WillResume() override;
- Status DoResume() override;
+ Status DoResume(lldb::RunDirection direction) override;
rocallahan wrote:
The decision was to use a direction f
@@ -874,10 +874,10 @@ class Process : public
std::enable_shared_from_this,
/// \see Thread:Resume()
/// \see Thread:Step()
/// \see Thread:Suspend()
- Status Resume();
+ Status Resume(lldb::RunDirection direction = lldb::eRunForward);
rocallahan wrote:
https://github.com/rocallahan edited
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -402,9 +402,16 @@ lldb_private::DynamicLoader
*ProcessKDP::GetDynamicLoader() {
Status ProcessKDP::WillResume() { return Status(); }
-Status ProcessKDP::DoResume() {
+Status ProcessKDP::DoResume(RunDirection direction) {
rocallahan wrote:
The decision wa
@@ -3139,6 +3146,7 @@ void PruneThreadPlans();
// m_currently_handling_do_on_removals are true,
// Resume will only request a resume, using this
// flag to check.
+ lldb::RunDirection m_last_run_d
@@ -52,7 +52,7 @@ class ProcessWindows : public Process, public ProcessDebugger
{
Status DoAttachToProcessWithID(
lldb::pid_t pid,
const lldb_private::ProcessAttachInfo &attach_info) override;
- Status DoResume() override;
+ Status DoResume(lldb::RunDirection d
@@ -203,11 +203,17 @@ ProcessWindows::DoAttachToProcessWithID(lldb::pid_t pid,
return error;
}
-Status ProcessWindows::DoResume() {
+Status ProcessWindows::DoResume(RunDirection direction) {
Log *log = GetLog(WindowsLog::Process);
llvm::sys::ScopedLock lock(m_mutex);
@@ -158,7 +158,7 @@ class LLDB_API SBProcess {
lldb::SBError Destroy();
- lldb::SBError Continue();
+ lldb::SBError Continue(RunDirection direction = RunDirection::eRunForward);
rocallahan wrote:
I have made this change.
https://github.com/llvm/llvm-pro
rocallahan wrote:
> Ack, sorry I'm bad at the formalities.
No problem. Thank you for your time.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -3271,6 +3273,11 @@ Status Process::PrivateResume() {
if (!GetModID().IsLastResumeForUserExpression())
ResetExtendedCrashInfoDict();
+ if (m_last_run_direction != direction) {
rocallahan wrote:
Done.
https://github.com/llvm/llvm-project/pull/99736
https://github.com/rocallahan edited
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/rocallahan edited
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -510,8 +510,9 @@ def start(self):
self._thread.start()
def stop(self):
-self._thread.join()
-self._thread = None
+if self._thread is not None:
rocallahan wrote:
This is not an LLDB stop or an LLDB thread. `thread_` is t
@@ -142,6 +142,9 @@ class StopInfo : public
std::enable_shared_from_this {
static lldb::StopInfoSP
CreateStopReasonProcessorTrace(Thread &thread, const char *description);
+ static lldb::StopInfoSP
rocallahan wrote:
Adding a comment.
https://github.com
@@ -3169,6 +3176,7 @@ void PruneThreadPlans();
// m_currently_handling_do_on_removals are true,
// Resume will only request a resume, using this
// flag to check.
+ lldb::RunDirection m_last_run_d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/109853.diff
2 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp (+27-27)
- (modified) lldb/source/Plugins/SymbolFi
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/109853
None
>From 93754d527df5e1336f63999fded1c7c906891f7f Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Tue, 24 Sep 2024 12:51:33 -0700
Subject: [PATCH] [lldb][NFC] Replace lldb's ValueType with llvm's
---
.../Sy
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ryan Mansfield (rjmansfield)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/109851.diff
6 Files Affected:
- (modified) lldb/source/Commands/CommandObjectFrame.cpp (+1-1)
- (modified) lldb/source/Commands/CommandObject
https://github.com/rjmansfield created
https://github.com/llvm/llvm-project/pull/109851
None
>From 7152beddd387b5d4ccef7653edaf2238999a2cfa Mon Sep 17 00:00:00 2001
From: Ryan Mansfield
Date: Tue, 24 Sep 2024 15:29:05 -0400
Subject: [PATCH] [lldb] Fix typos in various help messages.
---
lldb
Jlalond wrote:
> > [This
> > codepath](https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp#L118)
> > results in none of the modules being loaded, or rebased, and I don't why
> > this should apply without checking all modules.
>
vogelsgesang wrote:
> However, with these new "hiding frame" recognizers, we are using the frame
> hiding recognizers to handle "step out past hidden frames". So if - as was
> done in the original implementation - we're determining this during execution
> control, its hard to see how we can a
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/109062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2024-09-24T10:00:00-07:00
New Revision: 04b443e77845cd20ab5acc4356cee509316135dd
URL:
https://github.com/llvm/llvm-project/commit/04b443e77845cd20ab5acc4356cee509316135dd
DIFF:
https://github.com/llvm/llvm-project/commit/04b443e77845cd20ab5acc4356cee509316135dd.diff
LOG
jimingham wrote:
> @jimingham I agree with everything you wrote. I think you misunderstood the
> context based on the way GitHub provided you some misleading context in the
> email notification
Yeah, I should stop trying to read the notifications in the GitHub emails and
just use them as a li
jimingham wrote:
There are two clients for stack unwinding in general, with different
performance needs. There's the users of the `bt` command or it's SB API
equivalents who are operating on human timescales, and there's the execution
control machinery, which gets invoked much more frequently
https://github.com/jasonmolenda approved this pull request.
Sorry for the delay in reviewing, this looks good to me, thanks for doing this.
https://github.com/llvm/llvm-project/pull/106950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
@@ -0,0 +1,619 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -682,17 +683,51 @@ PacketStatus DAP::GetNextObject(llvm::json::Object
&object) {
}
bool DAP::HandleObject(const llvm::json::Object &object) {
+ auto start_time = std::chrono::steady_clock::now();
const auto packet_type = GetString(object, "type");
if (packet_type ==
https://github.com/felipepiovezan commented:
good catch!
https://github.com/llvm/llvm-project/pull/109751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/109751
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-09-24T09:08:08-07:00
New Revision: 206408732bca2ef464732a39c8319d47c8a1dbea
URL:
https://github.com/llvm/llvm-project/commit/206408732bca2ef464732a39c8319d47c8a1dbea
DIFF:
https://github.com/llvm/llvm-project/commit/206408732bca2ef464732a39c8319d47c8a1dbea.diff
adrian-prantl wrote:
@medismailben @labath Would you mind taking another look at this?
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
adrian-prantl wrote:
@medismailben @labath I finally worked through remaining platform-specific
issues with the patch this was depending on. Would you mind taking another look
at this?
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits
https://github.com/oontvoo ready_for_review
https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/109764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Landing this, post commit comments welcome as usual.
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/108365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-24T12:40:42+01:00
New Revision: 497759e872a53964a54db941f3a1ed74446c5ed4
URL:
https://github.com/llvm/llvm-project/commit/497759e872a53964a54db941f3a1ed74446c5ed4
DIFF:
https://github.com/llvm/llvm-project/commit/497759e872a53964a54db941f3a1ed74446c5ed4.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-09-24T11:21:24+01:00
New Revision: a3cf01d58587d81b184d40091a86d6b8bf92d240
URL:
https://github.com/llvm/llvm-project/commit/a3cf01d58587d81b184d40091a86d6b8bf92d240
DIFF:
https://github.com/llvm/llvm-project/commit/a3cf01d58587d81b184d40091a86d6b8bf92d240.diff
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DmT021 wrote:
@clayborg @Michael137 I've reverted the changes here and rewrote this patch
pretty much like it was originally presented with a slightly different order of
operation. The only change is in the `IRExecutionUnit::FindInSymbols` function
and the order of lookup is described in the c
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/109427
>From cc4032e58217a01ff414b8d03866a1631f492df8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 20 Sep 2024 14:00:44 +0100
Subject: [PATCH 1/4] [lldb][docs] Resurrect the information on adding a ne
labath wrote:
> [This
> codepath](https://github.com/llvm/llvm-project/blob/main/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp#L118)
> results in none of the modules being loaded, or rebased, and I don't why
> this should apply without checking all modules.
Yeah, I d
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/109485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vogelsgesang wrote:
> I looked into this (for way longer than it should have been necessary), and
> I tracked it down to a somewhat embarrassing bug
Thanks for looking into this. It would certainly have taken me much longer. I
will rebase on top of your commit, after your fix is merged, and t
https://github.com/vogelsgesang approved this pull request.
https://github.com/llvm/llvm-project/pull/109764
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> > [...] it may returned cached data from disk for running processes (which
> > means it will be faster, but potentially return incorrect data).
>
> I think the 2nd point shouldn't be an issue because `SBTarget::ReadMemory`
> sets `force_live_memory` to true when calling `Target
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The function should use the by-ref SBError argument instead of creating a new
one. This code has been here since ~forever, and was probably copied from
methods which return an SBError result (where one needs t
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/109764
The function should use the by-ref SBError argument instead of creating a new
one. This code has been here since ~forever, and was probably copied from
methods which return an SBError result (where one needs to
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/108870
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,9 +79,26 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
if (!sc.function)
return {};
+// Check if we have a regex match
+bool matches_regex = false;
for (RegularExpression &r : m_hidden_regex)
- if (r.Execute(sc.function->GetN
93 matches
Mail list logo
