[Lldb-commits] [lldb] 8a30246 - Revert "[lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)"

2024-09-20 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-20T19:18:56-07:00 New Revision: 8a30246f48946b0d2166d98b95b254a1865681ed URL: https://github.com/llvm/llvm-project/commit/8a30246f48946b0d2166d98b95b254a1865681ed DIFF: https://github.com/llvm/llvm-project/commit/8a30246f48946b0d2166d98b95b254a1865681ed.diff

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/109020 >From 60045b710e1102d6f220dfd4367f997b73bb64df Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Tue, 17 Sep 2024 09:56:09 -0700 Subject: [PATCH 1/2] Add warning message to `session save` when transcript isn't saved.

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-20 Thread Tom Yang via lldb-commits
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript( result.SetStatus(eReturnStatusSuccessFinishNoResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", output_file->c_str()); + if (!GetSaveTranscript()) +

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-20 Thread Tom Yang via lldb-commits
https://github.com/zhyty deleted https://github.com/llvm/llvm-project/pull/109020 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-20 Thread Tom Yang via lldb-commits
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript( result.SetStatus(eReturnStatusSuccessFinishNoResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", output_file->c_str()); + if (!GetSaveTranscript()) +

[Lldb-commits] [lldb] Add warning message to `session save` when transcript isn't saved. (PR #109020)

2024-09-20 Thread Tom Yang via lldb-commits
@@ -3306,6 +3306,8 @@ bool CommandInterpreter::SaveTranscript( result.SetStatus(eReturnStatusSuccessFinishNoResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", output_file->c_str()); + if (!GetSaveTranscript()) +

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion, bool try_dirty_pages, CreateCoreFileMemoryRange(region)); } +static void AddRegisterSections(Process &process, ThreadSP &thread_sp, +CoreFileMemoryRanges

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion, bool try_dirty_pages, CreateCoreFileMemoryRange(region)); } +static void AddRegisterSections(Process &process, ThreadSP &thread_sp, jeffreytan81 wrote: I assume this is

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion, bool try_dirty_pages, CreateCoreFileMemoryRange(region)); } +static void AddRegisterSections(Process &process, ThreadSP &thread_sp, +CoreFileMemoryRanges

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion, bool try_dirty_pages, CreateCoreFileMemoryRange(region)); } +static void AddRegisterSections(Process &process, ThreadSP &thread_sp, +CoreFileMemoryRanges

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion, bool try_dirty_pages, CreateCoreFileMemoryRange(region)); } +static void AddRegisterSections(Process &process, ThreadSP &thread_sp, +CoreFileMemoryRanges

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
@@ -6528,6 +6528,74 @@ static void AddRegion(const MemoryRegionInfo ®ion, bool try_dirty_pages, CreateCoreFileMemoryRange(region)); } +static void AddRegisterSections(Process &process, ThreadSP &thread_sp, +CoreFileMemoryRanges

[Lldb-commits] [lldb] b44da24 - [lldb] Change the implementation of Status to store an llvm::Error (NFC) (#106774)

2024-09-20 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-09-20T17:08:36-07:00 New Revision: b44da2446b17aaa847bf76f81a01870917f8736b URL: https://github.com/llvm/llvm-project/commit/b44da2446b17aaa847bf76f81a01870917f8736b DIFF: https://github.com/llvm/llvm-project/commit/b44da2446b17aaa847bf76f81a01870917f8736b.diff

[Lldb-commits] [lldb] [lldb] Don't invalid register context after setting thread pc's (PR #109499)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes Some gdb remote serial protocol stubs will send the thread IDs and PCs for all threads in a process in the stop-reply packet. lldb often needs to know the pc values for all threads while at a private s

[Lldb-commits] [lldb] [lldb] Don't invalid register context after setting thread pc's (PR #109499)

2024-09-20 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/109499 Some gdb remote serial protocol stubs will send the thread IDs and PCs for all threads in a process in the stop-reply packet. lldb often needs to know the pc values for all threads while at a private stop

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce ScriptedStopHook{, Python}Interface & make use of it (PR #109498)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/109498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f732157 - [lldb/Interpreter] Introduce ScriptedStopHook{, Python}Interface & make use of it (#109498)

2024-09-20 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2024-09-20T16:55:47-07:00 New Revision: f732157a9d067e4d300905c831a964222e0eadee URL: https://github.com/llvm/llvm-project/commit/f732157a9d067e4d300905c831a964222e0eadee DIFF: https://github.com/llvm/llvm-project/commit/f732157a9d067e4d300905c831a964222e0eadee.

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce ScriptedStopHook{, Python}Interface & make use of it (PR #109498)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch re-lands #105449 and fixes the various test failures. --- Patch is 36.49 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/109498.diff 22 File

[Lldb-commits] [lldb] [lldb/Interpreter] Introduce ScriptedStopHook{, Python}Interface & make use of it (PR #109498)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/109498 This patch re-lands #105449 and fixes the various test failures. >From 6faa2d6ccad438818dd80c601a31a883fe29c882 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Fri, 20 Sep 2024 16:26:59 -0700 Subje

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: @vogelsgesang Nice! https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Support inspecting memory (PR #104317)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: Thanks for that thoughtful write-up! #109485 should address your points > The method I'd recommend is to call `ReadMemory` I assume I should prefer `Target::ReadMemory` over `Process::readMemory`, right? https://github.com/llvm/llvm-project/pull/104317

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 65c57066e099fe7f1357485cd6c4fb068bc82323 48718649469aae62b2945e7de22cf7280316b757 --e

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes The `readMemory` request used the `MemoryRegionInfo` so it could also support short reads. Since #106532, this is no longer necessary, as mentioned by @labath in a comment on #104317. We no longe

[Lldb-commits] [lldb] [lldb-dap] Simplify `readMemory` (PR #109485)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/109485 The `readMemory` request used the `MemoryRegionInfo` so it could also support short reads. Since #106532, this is no longer necessary, as mentioned by @labath in a comment on #104317. We no longer set the

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben converted_to_draft https://github.com/llvm/llvm-project/pull/109440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread via lldb-commits
jimingham wrote: Now that successful results show up in the command return object, it's a little strange that if the expression fails - a parse error or whatever - that is not available in the command result. It would be more consistent if we did SetError on the command result object with the

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes This patch adds the support to `Process.cpp` to automatically save off TLS sections, either via loading the memory region for the module, or via reading `fs_base` via generic register. Then when Minidumps ar

[Lldb-commits] [lldb] [LLDB][Minidump] Have Minidumps save off and properly read TLS data (PR #109477)

2024-09-20 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/109477 This patch adds the support to `Process.cpp` to automatically save off TLS sections, either via loading the memory region for the module, or via reading `fs_base` via generic register. Then when Minidumps are l

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-20 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/107485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 2011cbc - [lldb-dap] Add feature to remember last non-empty expression. (#107485)

2024-09-20 Thread via lldb-commits
Author: cmtice Date: 2024-09-20T14:04:44-07:00 New Revision: 2011cbcd84102236dd6d58e2079ac676a3403f25 URL: https://github.com/llvm/llvm-project/commit/2011cbcd84102236dd6d58e2079ac676a3403f25 DIFF: https://github.com/llvm/llvm-project/commit/2011cbcd84102236dd6d58e2079ac676a3403f25.diff LOG: [

[Lldb-commits] [lldb] [lldb-dap] Implement value locations for function pointers (PR #104589)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/104589 >From a7876a20b5caa53dace056c84a1b7f1e798088f0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Mon, 12 Aug 2024 14:53:31 + Subject: [PATCH 1/3] [lldb-dap] Implement value locations for function

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 65c5706 - [lldb-dap][docs] Improve README (#109266)

2024-09-20 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-20T22:18:19+02:00 New Revision: 65c57066e099fe7f1357485cd6c4fb068bc82323 URL: https://github.com/llvm/llvm-project/commit/65c57066e099fe7f1357485cd6c4fb068bc82323 DIFF: https://github.com/llvm/llvm-project/commit/65c57066e099fe7f1357485cd6c4fb068bc82323

[Lldb-commits] [lldb] d8d252f - [lldb] Add support for disabling frame recognizers (#109219)

2024-09-20 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-09-20T22:17:42+02:00 New Revision: d8d252fe96877f9fdbf6b0b6c19da543e796bb84 URL: https://github.com/llvm/llvm-project/commit/d8d252fe96877f9fdbf6b0b6c19da543e796bb84 DIFF: https://github.com/llvm/llvm-project/commit/d8d252fe96877f9fdbf6b0b6c19da543e796bb84

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] lldb simplified template names rebuild without clang ast (PR #90008)

2024-09-20 Thread David Blaikie via lldb-commits
dwblaikie wrote: > Very cool! Yeah, I had loftier goals of taking this even further (some of lldb's comparisons are DIE-to-DIE (eg: when trying to find a definition from a declaration) and in that case it'd be nice to not create any strings (when not using simplified template names, lldb sort

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1 +0,0 @@ -objc vogelsgesang wrote: Thanks for confirming! https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [lldb] [llvm] lldb simplified template names rebuild without clang ast (PR #90008)

2024-09-20 Thread Michael Buch via lldb-commits
Michael137 wrote: Very cool! https://github.com/llvm/llvm-project/pull/90008 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread via lldb-commits
@@ -1 +0,0 @@ -objc jimingham wrote: The early motivation for stack frame recognizers was to get the "current exception object" from the objc_exception_throw routine. But this patch didn't add that recognizer, and when it was added it had its own test. There'

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-20 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. lgtm! https://github.com/llvm/llvm-project/pull/107485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -1 +0,0 @@ -objc Michael137 wrote: Yea that's fair, there doesn't seem to be anything objc specific here, so seems ok to turn it into C and enable it on all platforms. The original change that introduced these did mention Objective-C as one of the motivator

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I think this page leaves a lot to be desired but it's a good start. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/8] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/7] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/6] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 8c682fc70bff5c6dff43c4601c14e5e61d11a08f Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb] Store expression evaluator diagnostics in an llvm::Error (NFC) (PR #106442)

2024-09-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106442 >From 510511a7a9e293c268c987e670646038bd96ff45 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Fri, 20 Sep 2024 10:53:09 -0700 Subject: [PATCH] [lldb] Store expression evaluator diagnostics in an llvm:

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -87,6 +40,14 @@ adds `FOO=1` and `bar` to the environment: } ``` +### Attaching to a process + +When attaching to a process using LLDB you can attach in a few ways JDevlieghere wrote: Nit: missing period or colon. https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -1,77 +1,30 @@ # LLDB DAP -## `lldb-dap` Configurations +## Procuring the `lldb-dap` binary -The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a -command line tool that implements the [Debug Adapter -Protocol](https://microsoft.github.io/debug-ad

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/4] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict): print("Script exited with code %s" % e.code) +class LLDBInteractiveConsole(code.InteractiveConsole): +def __init__(self, locals=None): +super().__init__(locals) +self.result_output =

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict): print("Script exited with code %s" % e.code) +class LLDBInteractiveConsole(code.InteractiveConsole): +def __init__(self, locals=None): +super().__init__(locals) +self.result_output =

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: I assume you have tested this both with Python 3.9 and 3.11/3.12? https://github.com/llvm/llvm-project/pull/109440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/109440 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Jonas Devlieghere via lldb-commits
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict): print("Script exited with code %s" % e.code) +class LLDBInteractiveConsole(code.InteractiveConsole): +def __init__(self, locals=None): +super().__init__(locals) +self.result_output =

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @ashgti Thanks for your input! I updated the pull request accordingly https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/5] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/3] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/2] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109266 >From 006f7cbe4aa1621b9490ae534ea6e17f56e3f6af Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 19 Sep 2024 11:45:29 +0200 Subject: [PATCH 1/2] [lldb-dap][docs] Improve README * Document how t

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/109266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread John Harrison via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread John Harrison via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb-dap][docs] Improve README (PR #109266)

2024-09-20 Thread John Harrison via lldb-commits
@@ -204,12 +171,67 @@ The default hostname being used `localhost`. } ``` -## Custom debugger commands +### Configuration Settings Reference + +For both launch and attach configurations, lldb-dap accepts the following `lldb-dap` +specific key/value pairs: + +|parameter

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes When running a oneliner script expression, if the script interpreter returned a value, that value would be printed to the debugger standard output straight from the interpreter instead of being pro

[Lldb-commits] [lldb] [lldb/Interpreter] Propagate `script` output back to command return object (PR #109440)

2024-09-20 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/109440 When running a oneliner script expression, if the script interpreter returned a value, that value would be printed to the debugger standard output straight from the interpreter instead of being propagated

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -1 +0,0 @@ -objc vogelsgesang wrote: The intended test coverage of this test case seems to be to test the frame recognizers as indicated by the file path. Making making it run also on non-Mac platforms, we are hence gaining test coverage on other systems. T

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/8] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. Module test comments, LGTM https://github.com/llvm/llvm-project/pull/109219 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -1 +0,0 @@ -objc Michael137 wrote: Maybe with some Makefile trickery you could add a separate main.c in this directory (in addition to `main.m`). But that's probably not worth the trouble https://github.com/llvm/llvm-project/pull/109219 _

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -1 +0,0 @@ -objc Michael137 wrote: Hmm are we sure we aren't losing test coverage by converting this to plain C? I don't think it'd be a huge deal if we just added an entirely new test as part of this PR https://github.com/llvm/llvm-project/pull/109219

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Michael Buch via lldb-commits
@@ -395,6 +389,138 @@ def test_frame_recognizer_not_only_first_instruction(self): variables.GetValueAtIndex(1).GetValueType(), lldb.eValueTypeVariableArgument ) +def test_frame_recognizer_disable(self): +self.build() +exe = self.getBui

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Thorsten Schütt via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [APInt] Fix APInt constructions where value does not fit bitwidth (NFCI) (PR #80309)

2024-09-20 Thread Nikita Popov via lldb-commits
https://github.com/nikic updated https://github.com/llvm/llvm-project/pull/80309 >From 17ba7e8538a2a4cc7b17322d26e8ea83ce27d617 Mon Sep 17 00:00:00 2001 From: Nikita Popov Date: Thu, 19 Sep 2024 17:27:13 +0200 Subject: [PATCH] apint only --- clang/lib/AST/ByteCode/IntegralAP.h | 6 +

[Lldb-commits] [lldb] [lldb] Add support for disabling frame recognizers (PR #109219)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/109219 >From c471c2fe615082fb9f9c5f39466bd47ec5b86bb0 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Wed, 18 Sep 2024 22:34:30 + Subject: [PATCH 1/7] [lldb] Add support for disabling frame recognizer

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: I can't really say if the content is correct, but this was definitely an informative read https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,95 @@ +# Adding Programming Language Support + +LLDB has been architected to make it straightforward to add support for a +programming language. Only a small enum in core LLDB needs to be modified to +make LLDB aware of a new programming language. Everything else can be

[Lldb-commits] [lldb] [lldb][docs] Resurrect the information on adding a new language (PR #109427)

2024-09-20 Thread David Spickett via lldb-commits
DavidSpickett wrote: Mostly RST yes, but we have a few recent documents in Markdown which I enabled support for in https://github.com/llvm/llvm-project/pull/89716. https://github.com/llvm/llvm-project/pull/109427 ___ lldb-commits mailing list lldb-com

  1   2   >