jimingham wrote: Now that successful results show up in the command return object, it's a little strange that if the expression fails - a parse error or whatever - that is not available in the command result. It would be more consistent if we did SetError on the command result object with the error. It looks like you could capture that and forward it to where the result is made up. I think we should do that, but if you want to do it as a follow-up that's also fine. I don't have any comments on the code beyond what Jonas added, but there should be a test for this.
https://github.com/llvm/llvm-project/pull/109440 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits