[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

mstorsjo wrote: This broke building in mingw configurations, and possibly a few others as well. The `ReportWarning` function takes a pointer to a `std::once_flag`, while this is passing it with a `llvm::once_flag`. In many configurations, these are the same type, but in a couple ones, they're

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

@@ -972,8 +974,9 @@ GetLargestRangeSize(const std::vector &ranges) { return max_size; } -Status MinidumpFileBuilder::AddMemoryList_32( -std::vector &ranges) { +Status +MinidumpFileBuilder::AddMemoryList_32(std::vector &ranges, + Prog

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/108309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

@@ -837,15 +837,17 @@ Status MinidumpFileBuilder::AddMemoryList() { error = m_process_sp->CalculateCoreFileSaveRanges(m_save_core_options, all_core_memory_ranges); + if (error.Fail()) +return error; + + lldb_private::

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

https://github.com/JDevlieghere commented: The variable name should be `progress_tracker` but really we should just call it `progress` for consistency with the rest of lldb. https://github.com/llvm/llvm-project/pull/108309 ___ lldb-commits mailing li

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

jimingham wrote: I don't think this is the right way to handle ValueObjects in particular. Since ValueObjects carry their errors along with them, there's really no good excuse ever to return an empty ValueObjectSP. We do that in some places, but it really makes the interface awkward: current

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

https://github.com/jimingham approved this pull request. Yup, that's better. https://github.com/llvm/llvm-project/pull/108281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

jasonmolenda wrote: > re-ping since It's been more than a week > > @jimingham @adrian-prantl > > I hope I didn’t come across as too pushy or intrusive. No Jim was just out a little last week and is catching up still. I don't have an important opinion here, but I don't know if it adds a lot to

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

https://github.com/jasonmolenda approved this pull request. Looks correct. https://github.com/llvm/llvm-project/pull/108281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/106791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/106919 >From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 1 Sep 2024 17:26:11 +0100 Subject: [PATCH 1/7] [lldb-dap] Make environment option an object --- .../tools/l

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108309 >From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 13:33:44 -0700 Subject: [PATCH 1/2] Add Progress bar to minidump memory emission --- .../Minid

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 96b7c64b8a874584a9dad44bb8901904c14701c0 e7054832dc6e54d4b9f3ce86a8babd1f62cac81a --e

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108309 >From e7054832dc6e54d4b9f3ce86a8babd1f62cac81a Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 13:33:44 -0700 Subject: [PATCH] Add Progress bar to minidump memory emission --- .../Minidump/

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Added a progress tracker to Minidump file builders memory saving --- Full diff: https://github.com/llvm/llvm-project/pull/108309.diff 2 Files Affected: - (modified) lldb/source/Plugins/ObjectFile/Minidump/

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108259 >From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 10:27:31 -0700 Subject: [PATCH 1/4] Unlink file on failure --- .../ObjectFile/Minidump/Minidum

[Lldb-commits] [lldb] [LLDB][Minidump] Add a progress bar to minidump (PR #108309)

https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/108309 Added a progress tracker to Minidump file builders memory saving >From 043d25d320b71ed0049387a89d46ed18145e5c55 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 13:33:44 -0700 Subject: [PATCH

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/107970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Drop blocks without profile in BAT YAML (PR #107970)

https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/107970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105594 >From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 19 Jul 2024 17:26:13 -0700 Subject: [PATCH 1/5] [lldb] Change lldb's breakpoint handling behavior (#96

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105594 >From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 19 Jul 2024 17:26:13 -0700 Subject: [PATCH 1/5] [lldb] Change lldb's breakpoint handling behavior (#96

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108196 >From 0484639d79dc79eba39d203a35487a0cc1064caa Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 12:15:02 +0100 Subject: [PATCH 1/7] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfi

[Lldb-commits] [lldb] 0909e30 - [lldb] Skip checksum-mismatch.test on Windows

Author: Jonas Devlieghere Date: 2024-09-11T15:29:59-07:00 New Revision: 0909e3027004bb710b1d761569eb15452ce10346 URL: https://github.com/llvm/llvm-project/commit/0909e3027004bb710b1d761569eb15452ce10346 DIFF: https://github.com/llvm/llvm-project/commit/0909e3027004bb710b1d761569eb15452ce10346.d

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

https://github.com/walter-erquinigo approved this pull request. +1 https://github.com/llvm/llvm-project/pull/108226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/108036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

https://github.com/walter-erquinigo requested changes to this pull request. Thanks for working on this. Could you please write some tests? https://github.com/llvm/llvm-project/pull/108036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 141b8cec8c266c7857c38e5da76ab538ac35c706 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

adrian-prantl wrote: > Overall, this looks pretty good, but I'm suspicious of the Python change as > PyErr_Fetch should already return an owned reference. @medismailben @JDevlieghere Can you help me find the right solution for PythonException? https://github.com/llvm/llvm-project/pull/106774

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -181,29 +226,68 @@ const char *Status::AsCString(const char *default_error_str) const { // Clear the error and any cached error string that it might contain. void Status::Clear() { - m_code = 0; - m_type = eErrorTypeInvalid; - m_string.clear(); + if (m_error) +LLDB

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -94,26 +123,49 @@ Status Status::FromErrorStringWithFormat(const char *format, ...) { return Status(string); } -Status Status::FromError(llvm::Error error) { return Status(std::move(error)); } +Status Status::FromExpressionError(lldb::ExpressionResults result, +

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -174,33 +233,91 @@ const char *Status::AsCString(const char *default_error_str) const { // Clear the error and any cached error string that it might contain. void Status::Clear() { - m_code = 0; - m_type = eErrorTypeInvalid; - m_string.clear(); + if (m_error) +LLDB

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/108060 >From 1e83cdfeb7e3a6fba4b190e95dd794723031370d Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Tue, 3 Sep 2024 03:08:48 +0500 Subject: [PATCH 1/2] Implement operators <= and >= and add a test --- lldb/include/

[Lldb-commits] [lldb] [lldb] Change ValueObject::AddressOf() to return Expected (NFC) (PR #106831)

AbdAlRahmanGad wrote: re-ping since It's been more than a week @jimingham @adrian-prantl I hope I didn’t come across as too pushy or intrusive. https://github.com/llvm/llvm-project/pull/106831 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108259 >From 022173d669e84c96362024feb6512342fdd02d09 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 10:27:31 -0700 Subject: [PATCH 1/3] Unlink file on failure --- .../ObjectFile/Minidump/Minidum

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

adrian-prantl wrote: > > Status is already extensively unittested. > > The fact that you were able to pull this switch off without changing a single > line of test code tells me otherwise. Surely there is _some_ new > functionality being added here. That's *why* the implementation has all the

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106774 >From 141b8cec8c266c7857c38e5da76ab538ac35c706 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 10:35:37 +0200 Subject: [PATCH 1/2] [lldb] Only send "posix" error codes through the gdb-r

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/106791 >From ae9d2e4fdfe9eb15f37c2b27da1b1f239d018391 Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Fri, 30 Aug 2024 12:49:33 -0700 Subject: [PATCH] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

felipepiovezan wrote: I only hit this bug in a downstream test. It seems we don't directly test lldbutil, but none of the tests regress with this change, so we should be confident it is ok. https://github.com/llvm/llvm-project/pull/108281 ___ lldb-co

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes If multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint. Currently, `get_threads_stopped_at_breakpoint_id` only checks the first such rea

[Lldb-commits] [lldb] [lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (PR #108281)

https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/108281 If multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint. Currently, `get_threads_stopped_at_breakpoint_id` only checks the first such reason. >From 09a4

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

https://github.com/jeffreytan81 requested changes to this pull request. The logic makes sense. Implementation wise, instead of calling `builder.DeleteFile()` in every failure code path, I would suggest creating a RAII class which calls `builder.DeleteFile()` in destructor. Then you just need t

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

@@ -0,0 +1,86 @@ +//===-- CoreFileMemoryRanges.cpp *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

@@ -0,0 +1,86 @@ +//===-- CoreFileMemoryRanges.cpp *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

@@ -0,0 +1,50 @@ +//===-- CoreFileMemoryRanges.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

@@ -0,0 +1,86 @@ +//===-- CoreFileMemoryRanges.cpp *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

@@ -450,6 +450,8 @@ class RangeDataVector { void Append(const Entry &entry) { m_entries.emplace_back(entry); } + void Append(B &&b, S &&s, T &&t) { m_entries.emplace_back(Entry(b, s, t)); } mbucko wrote: why not just name then base, size, data? Then the r

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 96b7c64b8a874584a9dad44bb8901904c14701c0 771be24eecb498cecf59062182ae680f33bdbb03 --e

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In #95312 Minidump file creation was moved from being created at the end, to the file being emitted in chunks. This causes some undesirable behavior where the file can still be present after an error has occ

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108196 >From 0484639d79dc79eba39d203a35487a0cc1064caa Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 12:15:02 +0100 Subject: [PATCH 1/6] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfi

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108196 >From 0484639d79dc79eba39d203a35487a0cc1064caa Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 12:15:02 +0100 Subject: [PATCH 1/5] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfi

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp call to protected Status Constructor (PR #108248)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108248 >From c13cca79b5b90a858fe32b4ee490189c10fcd7c9 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 09:46:02 -0700 Subject: [PATCH] Remove CommandObjectTraceStartIntelPT.cpp call to Status() cons

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/108183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp call to protected Status Constructor (PR #108248)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/108248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp call to protected Status Constructor (PR #108248)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/108248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp Status Constructor (PR #108248)

https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/108248 @adrian-prantl from your recent changes I keep encountering issues iwth this file in my build chain. Does this API usage look correct for your new redesign? >From 0b449cc60c33ee8231c7a108511207298fab0403 Mon Se

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108196 >From 0484639d79dc79eba39d203a35487a0cc1064caa Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 12:15:02 +0100 Subject: [PATCH 1/3] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfi

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

cor3ntin wrote: ping! https://github.com/llvm/llvm-project/pull/106505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/108227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/107968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ffa2f53 - [lldb] Print a warning on checksum mismatch (#107968)

Author: Jonas Devlieghere Date: 2024-09-11T08:53:07-07:00 New Revision: ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c URL: https://github.com/llvm/llvm-project/commit/ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c DIFF: https://github.com/llvm/llvm-project/commit/ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c.d

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/107968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Without this, the binary would still be built with libstdc++, if that's the system/compiler default. --- Full diff: https://github.com/llvm/llvm-project/pull/108227.diff 1 Files Affected: - (modified) lldb/

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108227 Without this, the binary would still be built with libstdc++, if that's the system/compiler default. >From 2cd17c367db099e59497f1050f9bb07ce2a6d269 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The test failed in ; due to frame variable not being in stop commands, even though the DAP log shows the command being present there. I'm pretty sure t

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108226 The test failed in due to frame variable not being in stop commands, even though the DAP log shows the command being present there. I'm pretty sure this

[Lldb-commits] [lldb] 44fc987 - [lldb][test] Toolchain detection rewrite in Python (#102185)

Author: Vladislav Dzhidzhoev Date: 2024-09-11T16:04:01+03:00 New Revision: 44fc987ed174e32544a577387ab0df6886495e82 URL: https://github.com/llvm/llvm-project/commit/44fc987ed174e32544a577387ab0df6886495e82 DIFF: https://github.com/llvm/llvm-project/commit/44fc987ed174e32544a577387ab0df6886495e8

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

@@ -96,17 +98,105 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/102185 >From b3fb433811a0f072823f03de7814cbc574c18dec Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 27 Jul 2024 02:39:32 +0200 Subject: [PATCH 01/15] [lldb][test] Improve toolchain detection in Mak

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

@@ -96,16 +98,120 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

DavidSpickett wrote: > Yes I think there might be a Windows API launch flag that can let us do early > detection of hardware breakpoints and watchpoints. But so far after lots of > experimentation I have not been able to find the right set. Is it possible this is a bug in Windows itself? Thoug

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

Michael137 wrote: Test currently expectedly fails on CI https://github.com/llvm/llvm-project/pull/108169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108169 >From fd093d23400fc48b013cafceafc009fcb5f2142c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 09:32:13 +0100 Subject: [PATCH 1/2] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: a

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This logic will need adjusting soon for https://github.com/llvm/llvm-project/pull/108155 This patch pulls out the logic for detecting/creating unnamed bitfields out of `ParseSingleMember` to make the latt

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/108196 This logic will need adjusting soon for https://github.com/llvm/llvm-project/pull/108155 This patch pulls out the logic for detecting/creating unnamed bitfields out of `ParseSingleMember` to make the latter

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

@@ -85,6 +85,43 @@ TEST_P(SocketTest, DomainListenConnectAccept) { std::unique_ptr socket_b_up; CreateDomainConnectedSockets(Path, &socket_a_up, &socket_b_up); } + +TEST_P(SocketTest, DomainMainLoopAccept) { slydiman wrote: Add `#if LLDB_ENABLE_POSIX`. Oth

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/slydiman approved this pull request. LGTM, but fix the test please. https://github.com/llvm/llvm-project/pull/108188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/108188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/108188 >From eb9799b9a1631e34b9553386ce968fd5379378fc Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 12:55:09 +0200 Subject: [PATCH 1/2] [lldb] Add a MainLoop version of DomainSocket::Accept To go a

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1e3a24d2e4eb63c17b962161ae6588d1b2c178f8 eb9799b9a1631e34b9553386ce968fd5379378fc --e

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes To go along with the existing TCPSocket implementation. --- Full diff: https://github.com/llvm/llvm-project/pull/108188.diff 9 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+12-1) - (modifie

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108188 To go along with the existing TCPSocket implementation. >From eb9799b9a1631e34b9553386ce968fd5379378fc Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 12:55:09 +0200 Subject: [PATCH] [lldb] Ad

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

DhruvSrivastavaX wrote: > You can do that as a temporary fix so that we can move on to dealing with > other Host functionality. In the longer run I'll still most likely want to > get rid of those constants by doing something like I described in that > comment. Yes, agreed. If we do not need b

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/108155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] da69449 - [lldb][test] Add test for no_unique_address when mixed with bitfields (#108155)

Author: Michael Buch Date: 2024-09-11T11:36:27+01:00 New Revision: da6944912baffa430468078c38f65d55fb83dd43 URL: https://github.com/llvm/llvm-project/commit/da6944912baffa430468078c38f65d55fb83dd43 DIFF: https://github.com/llvm/llvm-project/commit/da6944912baffa430468078c38f65d55fb83dd43.diff

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

DavidSpickett wrote: If anyone wants to actually get the features we'll either have to delay checks until there is an actual process, or find a command line to qemu to dump out the features in equivalent form. But either way - not something I'm going to do myself. https://github.com/llvm/llvm

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

DavidSpickett wrote: Note that this is not part of a big push to get the test suite working this way, it's because I've been working on qemu compatibility as part of https://github.com/llvm/llvm-project/issues/87471 and need to sanity check my changes somehow. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes I've been testing against qemu-aarch64 using the qemu-user platform, which doesn't support get-file: ``` AssertionError: False is not true : Command 'platform get-file "/proc/cpuinfo" <...>/TestAArch6

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/108183 I've been testing against qemu-aarch64 using the qemu-user platform, which doesn't support get-file: ``` AssertionError: False is not true : Command 'platform get-file "/proc/cpuinfo" <...>/TestAArch64Lin

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

  1   2   >