YungRaj wrote:
> > I was hoping to fix everything in one Pull Request so that it at least
> > becomes usable once this merges.
>
> The LLVM project generally
> [prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity)
> smaller patches as they're easier to review. We
Author: Jonas Devlieghere
Date: 2024-07-31T18:06:32-07:00
New Revision: 5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704
URL:
https://github.com/llvm/llvm-project/commit/5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704
DIFF:
https://github.com/llvm/llvm-project/commit/5dbbc3b14bb04ef4bf2cbf4c23008f94f4253704.d
hekota wrote:
> > I also don't see anywhere that actually successfully uses
> > `__builtin_hlsl_resource_t`. Am I missing it, or should I not expect to see
> > it?
>
> You are correct - the type cannot be directly declared in user code, so the
> tests only check for errors and that the type s
JDevlieghere wrote:
> Thanks @JDevlieghere! Could you add this special case?
I'm happy to help but I wouldn't feel comfortable making such a change without
being able to reproduce and test it.
> The authoritatively established and supported way to link with `ncurses` on
> most Linux platfor
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/3] [lldb][test] Support remote run of Shell tests
1.
@@ -22,6 +24,55 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=None):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
@@ -22,6 +24,55 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=None):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
@@ -22,6 +24,55 @@ def _disallow(config, execName):
config.substitutions.append((" {0} ".format(execName),
warning.format(execName)))
+def get_lldb_args(config, suffix=None):
+lldb_args = []
+if "remote-linux" in config.available_features:
+lldb_args += [
@@ -4,16 +4,16 @@
target create -l "ls" /bin/ls
target list
-# CHECK: * target #0 (ls): /bin/ls
+# CHECK: * target #0 (ls): [[LS_PATH:.*]]
dzhidzhoev wrote:
> Do I understand correctly here that the path `/bin/ls` is given to target
> create, that program is
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
971a1ac4451017e625f81a4a8c15092c06dd2eb3...ed18268a5501a7d6e2aa03717d3c36a1040d2ad4
lldb/
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/95986
>From b747d2cf8d648e0dadda4adaaf2e0ef41d4ebd34 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 31 May 2024 21:39:56 +
Subject: [PATCH 1/3] [lldb][test] Support remote run of Shell tests
1.
bernhardkaindl wrote:
Thanks @JDevlieghere! Could you add this special case?
The authoritatively established and supported way to link with `ncurses` on
most Linux platforms would be to use `pkg-config --libs ncurses` to the
`LDFLAGS` for `ncurses` for the given compile target.
https://github
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/7] Squash 64b-memory-regions-minidump and take only
llvm-chang
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
kendalharland wrote:
I was able to figure this out. My CMakeCache had `-D LLVM_ENABLE_DIA_SDK="OFF"`
wh
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 1/5] Squash 64b-memory-regions-minidump and take only
llvm-chang
JDevlieghere wrote:
What I said was that, to the best of my knowledge, we don't have places in LLDB
that rely on `terminfo` but not on `ncruses`. I think that statement still
holds true. The assumption behind it was that `ncurses` provides a superset of
the functionality provided by `terminfo`
Author: Haowei Wu
Date: 2024-07-31T13:58:30-07:00
New Revision: 9effefbae8d96006a4dd29bb9ab8532fd408559d
URL:
https://github.com/llvm/llvm-project/commit/9effefbae8d96006a4dd29bb9ab8532fd408559d
DIFF:
https://github.com/llvm/llvm-project/commit/9effefbae8d96006a4dd29bb9ab8532fd408559d.diff
LOG
bernhardkaindl wrote:
@JDevlieghere, you wrote:
> No objections in the context of LLDB. We don't use terminfo directly
> (although I think editline does, but that isn't affected by this) and if we
> want the TUI we depend on curses anyway.
You truly use `libtinfo` directly in LLDB:
```py
# g
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dimitry Andric (DimitryAndric)
Changes
…() declarations
Similar to #97796, fix the type of the `native_thread` parameter for
the arm, mips64 and powerpc variants of `NativeRegisterContextFreeBSD_*`.
Otherwise, this leads to compile errors
https://github.com/DimitryAndric created
https://github.com/llvm/llvm-project/pull/101403
…() declarations
Similar to #97796, fix the type of the `native_thread` parameter for the arm,
mips64 and powerpc variants of `NativeRegisterContextFreeBSD_*`.
Otherwise, this leads to compile errors sim
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,211 @@
+"""
+Test that the FrameRecognizer for __abort_with_payload
+works properly
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+
+
+class TestAbortWithPayload(TestBase
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100477
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -12,6 +12,7 @@
class MultipleSlidesTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True
+@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
kendalharland wrote:
My output for `image dump symtab a.out` is empty. However, if I edit
https://githu
@@ -115,6 +116,18 @@ GlobalVariable *replaceBuffer(CGHLSLRuntime::Buffer &Buf) {
} // namespace
+llvm::Type *CGHLSLRuntime::convertHLSLSpecificType(const Type *T) {
+ assert(T->isHLSLSpecificType() && "Not an HLSL specific type!");
+
+ // Check if the target has a specific
@@ -23,7 +23,7 @@ export module b;
import a;
export int b();
-// CHECK: https://github.com/llvm/llvm-project/pull/97362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -1390,7 +1390,8 @@ void ASTContext::InitBuiltinTypes(const TargetInfo
&Target,
#include "clang/Basic/HLSLIntangibleTypes.def"
}
- if (Target.hasAArch64SVETypes()) {
+ if (Target.hasAArch64SVETypes() ||
hekota wrote:
I don't see this change in this PR
zeroomega wrote:
Hi @medismailben
We are seeing redefinition of pid_t error again on windows builder:
https://lab.llvm.org/buildbot/#/builders/141/builds/1254
after multiple revert and reland like e72cdae47b4e263ea97b2bdd75cf44c1510cf3be.
Could you revert the change please? Could you also not
slydiman wrote:
I have moved all Pipe related changes to #101383.
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
@labath
> one of the issues (ETXTBSY) you refer to as "system bugs"
I meant https://bugzilla.kernel.org/show_bug.cgi?id=546 and [this
discussion](https://github.com/llvm/llvm-project/pull/100670/files#r1693201568).
I'm sad that you don't believe. I concluded that no one uses t
https://github.com/bulbazord commented:
This change looks fine to me, but next time please wait longer before merging
your change.
https://github.com/llvm/llvm-project/pull/101361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
@@ -1390,7 +1390,8 @@ void ASTContext::InitBuiltinTypes(const TargetInfo
&Target,
#include "clang/Basic/HLSLIntangibleTypes.def"
}
- if (Target.hasAArch64SVETypes()) {
+ if (Target.hasAArch64SVETypes() ||
python3kgae wrote:
Is this expected change for in
@@ -0,0 +1,211 @@
+"""
+Test that the FrameRecognizer for __abort_with_payload
+works properly
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+
+
+class TestAbortWithPayload(TestBase
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,211 @@
+"""
+Test that the FrameRecognizer for __abort_with_payload
+works properly
+"""
+
+
+import lldb
+from lldbsuite.test.decorators import *
+import lldbsuite.test.lldbutil as lldbutil
+from lldbsuite.test.lldbtest import *
+
+
+class TestAbortWithPayload(TestBase
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,201 @@
+//===-- AbortWithPayloadFrameRecognizer.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101283
>From 6b2a41ba3d71270e81e24a42d3b4f5dc2f96b939 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 05:41:21 +0400
Subject: [PATCH] [lldb] Updated lldb-server to spawn the child process and
sh
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Fixed few bugs in PipeWindows. Added the test for async read/write.
---
Full diff: https://github.com/llvm/llvm-project/pull/101383.diff
7 Files Affected:
- (modified) lldb/include/lldb/Host/PipeBase.h
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/101383
Fixed few bugs in PipeWindows. Added the test for async read/write.
>From 1d6edb89e242f17908518e9d1b5da431d0d0908b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 22:02:53 +0400
Subject:
https://github.com/tschuett edited
https://github.com/llvm/llvm-project/pull/101365
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aperez closed
https://github.com/llvm/llvm-project/pull/101361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alexandre Perez
Date: 2024-07-31T10:57:40-07:00
New Revision: 0a01e8ff530ab15277aa9fad5361297d7b55e247
URL:
https://github.com/llvm/llvm-project/commit/0a01e8ff530ab15277aa9fad5361297d7b55e247
DIFF:
https://github.com/llvm/llvm-project/commit/0a01e8ff530ab15277aa9fad5361297d7b55e247.dif
https://github.com/clayborg approved this pull request.
Looks good! This will be very useful for core files.
https://github.com/llvm/llvm-project/pull/101361
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/jimingham approved this pull request.
LGTM I like that you also changed "Update" to "ModuleWasUpdated", that's more
accurate. `m_initialized` isn't quite the right name, it means "needs work"
not "initialized" which sounds like it should happen once.
If you can think of a be
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/101365
>From 5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Tue, 30 Jul 2024 09:32:24 -0700
Subject: [PATCH 1/3] Add a StackFrameRecognizer for the Darwin specific
abort_wit
https://github.com/JDevlieghere approved this pull request.
This makes sense to me. LGTM if Jim is happy.
https://github.com/llvm/llvm-project/pull/101130
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/jimingham updated
https://github.com/llvm/llvm-project/pull/101365
>From 5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5 Mon Sep 17 00:00:00 2001
From: Jim Ingham
Date: Tue, 30 Jul 2024 09:32:24 -0700
Subject: [PATCH 1/2] Add a StackFrameRecognizer for the Darwin specific
abort_wit
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/100624
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2024-07-31T10:25:31-07:00
New Revision: 9fe455fd0c7d6f2107b33b37c04bbd3b12fe65b3
URL:
https://github.com/llvm/llvm-project/commit/9fe455fd0c7d6f2107b33b37c04bbd3b12fe65b3
DIFF:
https://github.com/llvm/llvm-project/commit/9fe455fd0c7d6f2107b33b37c04bbd3b1
dzhidzhoev wrote:
> I'm not sure whether we need `LLDB_SHELL_TESTS_DISABLE_REMOTE`, can you
> explain how that would be used?
>
> Would I set up a build with all the other flags, do my remote testing, then
> set `LLDB_SHELL_TESTS_DISABLE_REMOTE=OFF` and run the shell tests locally,
> using th
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 80c0e8d572d3b1c34d66faffc42bcfc9432583ec
5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
80c0e8d572d3b1c34d66faffc42bcfc9432583ec...5b2cf0ab7e382e41ff3dfe88e4d7e35ddc99afd5
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
This is used by various system routines (the capabilities checker and dyld to
name a few) to add extra color to an abort. This patch adds a frame
recognizer so people can easily see the details, and also adds the
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/101365
This is used by various system routines (the capabilities checker and dyld to
name a few) to add extra color to an abort. This patch adds a frame
recognizer so people can easily see the details, and also ad
Author: Jonas Devlieghere
Date: 2024-07-31T09:57:10-07:00
New Revision: 8398ad9cb21736dc57ee4dd766bd0859ef9bd000
URL:
https://github.com/llvm/llvm-project/commit/8398ad9cb21736dc57ee4dd766bd0859ef9bd000
DIFF:
https://github.com/llvm/llvm-project/commit/8398ad9cb21736dc57ee4dd766bd0859ef9bd000.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/101208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aperez updated
https://github.com/llvm/llvm-project/pull/101361
>From 132b6fb0808385494a71c99533d7281420b743bd Mon Sep 17 00:00:00 2001
From: Alexandre Perez
Date: Wed, 31 Jul 2024 09:38:38 -0700
Subject: [PATCH] [lldb] Allow mapping object file paths
---
lldb/include/lldb/
@@ -138,7 +191,7 @@ def use_support_substitutions(config):
# Set up substitutions for support tools. These tools can be overridden
at the CMake
# level (by specifying -DLLDB_LIT_TOOLS_DIR), installed, or as a last
resort, we can use
# the just-built version.
-
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
12189f800585ab459afa20b4f159db93ae474b57...5221c6f267fffd811c6dd39dbbcc211e2a93739c
lldb/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alexandre Perez (aperez)
Changes
This introduces a `target.object-map` which allows us to remap module
locations, much in the same way as source mapping works today. This is useful,
for instance, when debugging coredumps, so we can replace
https://github.com/aperez created
https://github.com/llvm/llvm-project/pull/101361
This introduces a `target.object-map` which allows us to remap module
locations, much in the same way as source mapping works today. This is useful,
for instance, when debugging coredumps, so we can replace some
@@ -136,6 +136,22 @@ static size_t layout(BlobAllocator &File,
MinidumpYAML::ExceptionStream &S) {
return DataEnd;
}
+static size_t layout(BlobAllocator &File, MinidumpYAML::Memory64ListStream &S)
{
+ size_t BaseRVA = File.tell() + sizeof(minidump::Memory64ListHeader);
--
@@ -550,7 +588,7 @@ Stream::create(const Directory &StreamDesc, const
object::MinidumpFile &File) {
llvm_unreachable("Unhandled stream kind!");
}
-Expected Object::create(const object::MinidumpFile &File) {
+Expected Object::create(object::MinidumpFile &File) {
@@ -336,3 +336,52 @@ TEST(MinidumpYAML, ExceptionStream_ExtraParameter) {
0xab, 0xad, 0xca, 0xfe}),
*ExpectedContext);
}
+
+TEST(MinidumpYAML, MemoryRegion_64bit) {
+ SmallString<0> Storage;
+ auto ExpectedFile = toBinary(Storage, R"
Michael137 wrote:
> @Michael137 Have you tried applying the patch to swift-lldb and running the
> tests?
Not yet, but planning to do so sometime this week
https://github.com/llvm/llvm-project/pull/101333
___
lldb-commits mailing list
lldb-commits@lis
adrian-prantl wrote:
@Michael137 Have you tried applying the patch to swift-lldb and running the
tests?
https://github.com/llvm/llvm-project/pull/101333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
https://github.com/Michael137 commented:
Awesome, this feels much better. Thanks for doing this!
I'll give this a try in the Swift plugin this week
LGTM (modulo some stylistic comments). Will defer approval until I tried this
with Swift
https://github.com/llvm/llvm-project/pull/101333
___
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/101333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/101333
>From e87b2b24cd673584aabd00eaf6ad8fc4c0c52c98 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 16 Jul 2024 14:18:27 +
Subject: [PATCH 1/2] [lldb] Refactor TypeQuery::ContextMatches, take 2
This is an
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff d8b985c9490664f7ec923e59cf6c603d998179ae
e87b2b24cd673584aabd00eaf6ad8fc4c0c52c98 --e
labath wrote:
@Michael137, I'd appreciate it if you could give this a spin. If
https://github.com/swiftlang/llvm-project/blob/ee8bc8b8d30eb99807adbcd3c1f044e00af66cdd/lldb/source/Plugins/TypeSystem/Swift/TypeSystemSwiftTypeRef.cpp#L219-L225
is the only use of `AnyModule`, then it should be stra
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is an alternative, much simpler implementation of #99305. In this
version I replace the AnyModule wildcard match with a special TypeQuery flag
which achieves (mostly) the same thing.
It is a preparatory
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/101333
This is an alternative, much simpler implementation of #99305. In this version
I replace the AnyModule wildcard match with a special TypeQuery flag which
achieves (mostly) the same thing.
It is a preparatory st
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/101326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-07-31T17:51:06+04:00
New Revision: 93fecc2577ece0329f3bbe2719bbc5b4b9b30010
URL:
https://github.com/llvm/llvm-project/commit/93fecc2577ece0329f3bbe2719bbc5b4b9b30010
DIFF:
https://github.com/llvm/llvm-project/commit/93fecc2577ece0329f3bbe2719bbc5b4b9b30010.dif
DavidSpickett wrote:
Linaro does yes, I think @omjavaid is currently dealing with that bot.
https://github.com/llvm/llvm-project/pull/100710
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/labath approved this pull request.
This makes sense, though it would probably be even better to just use the real
StreamLogHandler class. I think all that's needed would be to add a new
constructor to it.
https://github.com/llvm/llvm-project/pull/101326
_
@@ -114,6 +120,218 @@ static Status save_socket_id_to_file(const std::string
&socket_id,
return status;
}
+static GDBRemoteCommunicationServerPlatform::PortMap gdbserver_portmap;
+static std::mutex gdbserver_portmap_mutex;
+
+#if defined(_WIN32)
+static void SpawnProcessRea
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> @labath
>
> > For consistency, and to minimize the number of ifdefs, I believe windows
> > and non-windows paths should use as similar approaches as possible. That
> > means I think the end state should be that the posix path also uses a
> > fork+exec approach.
>
> fork+exec
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c35c4c72e4977258fc1da940e0470e8d0671bf07
c785238cf366746a383e74a89be7c7431cd41d3c --e
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101283
>From add315c8db91c4d51f9b298cc64478c0497857a5 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 05:41:21 +0400
Subject: [PATCH] [lldb] Updated lldb-server to spawn the child process and
sh
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/101283
>From c785238cf366746a383e74a89be7c7431cd41d3c Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 31 Jul 2024 05:41:21 +0400
Subject: [PATCH] [lldb] Updated lldb-server to spawn the child process and
sh
Michael137 wrote:
> @Michael137 This broke the windows bot:
> https://lab.llvm.org/buildbot/#/builders/141/builds/1214 Should we skip it on
> that platform or do you see an easy fix ?
Thanks for pinging. This is the failure:
```
| error: no variable named 'f' found in this frame
# `--
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Host::LaunchProcess() requires to SetMonitorProcessCallback. This callback is
called from the child process monitor thread. We cannot control this thread
anyway. lldb-server may crash if there is a loggin
1 - 100 of 152 matches
Mail list logo
