================
@@ -138,7 +191,7 @@ def use_support_substitutions(config):
     # Set up substitutions for support tools.  These tools can be overridden 
at the CMake
     # level (by specifying -DLLDB_LIT_TOOLS_DIR), installed, or as a last 
resort, we can use
     # the just-built version.
-    host_flags = ["--target=" + config.host_triple]
+    host_flags = ["--target=" + config.target_triple]
----------------
dzhidzhoev wrote:

Hmm. I thought it was named after the substitution name %clang_host (used by 
tests not bound to the specific architecture).
I think it may be better to rename the substitution to %clang_target instead, 
but it requires a huge change of all tests.
Otherwise, we get the line like 
`config.substitutions.append(("%clang_host", "%clang " + target_flags))`
which also looks confusing IMO.

https://github.com/llvm/llvm-project/pull/95986
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to