https://github.com/labath closed https://github.com/llvm/llvm-project/pull/91586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-10T08:34:42+02:00
New Revision: 5bde2aa1080ba90021f8f5e0c48744ddfc0d6f15
URL:
https://github.com/llvm/llvm-project/commit/5bde2aa1080ba90021f8f5e0c48744ddfc0d6f15
DIFF:
https://github.com/llvm/llvm-project/commit/5bde2aa1080ba90021f8f5e0c48744ddfc0d6f15.diff
labath wrote:
> I can't remember: does terminate come before disconnecting? Or is it the
> other way around?
Disconnect docs say "The disconnect request asks the debug adapter to
disconnect from the debuggee (thus ending the debug session) and then to shut
down itself (the debug adapter).", s
labath wrote:
> I realised that as it was, the calling object file would get its map updated
> but not the other object file. Which is potentially a regression if we choose
> to use one or the other file for a lookup. So now the methods update the
> member map, and return the changes they made
@@ -23,6 +23,8 @@ class Symtab {
public:
typedef std::vector IndexCollection;
typedef UniqueCStringMap NameToIndexMap;
+ typedef std::map
+ FileAddressToAddressClassMap;
labath wrote:
This code depends on the map being sorted, which densemap isn't. A
labath wrote:
I have fixed/worked around the mach exception issue in a [followup
commit](https://github.com/llvm/llvm-project/commit/b903badd73a2467fdd4e363231f2bf9b0704b546)
with a `settings set platform.plugin.darwin.ignored-exceptions
EXC_BAD_INSTRUCTION`. Now the process gets a SIGILL as e
@@ -23,6 +23,8 @@ class Symtab {
public:
typedef std::vector IndexCollection;
typedef UniqueCStringMap NameToIndexMap;
+ typedef std::map
+ FileAddressToAddressClassMap;
clayborg wrote:
You might want to use a llvm::DenseMap if possible. std::map use
https://github.com/clayborg commented:
I can't remember: does terminate come before disconnecting? Or is it the other
way around?
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/clayborg commented:
How many notifications happen during an expression? We want to make sure this
doesn't slow down expression evaluation by any appreciable amount. If we spam
these notifications, without having any throttling in place (I have an open
patch for this I haven'
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91685
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Keith Smiley (keith)
Changes
This mirrors the LLDB_DEBUGSERVER_PATH environment variable and allows you to
have lldb-argdumper in a non-standard location and still use it at runtime.
---
Full diff: https://github.com/llvm/llvm-project/pull
https://github.com/keith created https://github.com/llvm/llvm-project/pull/91688
This mirrors the LLDB_DEBUGSERVER_PATH environment variable and allows you to
have lldb-argdumper in a non-standard location and still use it at runtime.
>From 98ddf4ed99a10c46a43d9a750bd826623a8c7e6f Mon Sep 17 00
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
If you change the generation script and re-run ninja (or whatever drives your
build), it currently will not regenerate SBLanguages.h. With dependency
tracking, it should re-run when the script changes.
--
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/91686
If you change the generation script and re-run ninja (or whatever drives your
build), it currently will not regenerate SBLanguages.h. With dependency
tracking, it should re-run when the script changes.
>From
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91685.diff
1 Files Affected:
- (modified) lldb/scripts/generate-sbapi-dwarf-enum.py (+4)
``diff
diff --git a/lldb/scripts/generate-sba
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/91685
None
>From 6c2ea1ff493a55fc4713c4bc58ef6e659e1c7b9d Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 9 May 2024 17:27:42 -0700
Subject: [PATCH] [lldb] Put SBSourceLanguageName in lldb namespace
---
ll
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From 0e45adeac968aa435f58dfef026ef308e56b40a5 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/91029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Anthony Ha
Date: 2024-05-09T15:57:46-07:00
New Revision: 95f208f97e709139c3ecbce552bcf1e34b9fcf12
URL:
https://github.com/llvm/llvm-project/commit/95f208f97e709139c3ecbce552bcf1e34b9fcf12
DIFF:
https://github.com/llvm/llvm-project/commit/95f208f97e709139c3ecbce552bcf1e34b9fcf12.diff
LO
Awfa wrote:
> > @JDevlieghere , do you know if there's a way to run buildbot on a merge of
> > this PR and main branch - just to validate the build/tests work before this
> > merge?
>
> Not that I know. When failures are macOS specific I'm happy to apply a PR
> locally and run the test suite
@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo {
m_cumulative_system_time.tv_usec > 0;
}
+ int8_t GetNiceValue() const { return m_nice_value; }
feg208 wrote:
prpsinfo has pr_nice field to be populated
https://github.com/llv
jasonmolenda wrote:
Ah, so the problem is,
```
(lldb) bt
* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION
(code=1, subcode=0xdead)
* frame #0: 0x00013f2c b.out`signal_generating_add + 4 at
signal-in-leaf-function-aarch64.c:5
frame #1: 0x00013
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91146
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-10T01:56:14+04:00
New Revision: ba66dfb11bcaef5e0dc21358b3712b491d61d020
URL:
https://github.com/llvm/llvm-project/commit/ba66dfb11bcaef5e0dc21358b3712b491d61d020
DIFF:
https://github.com/llvm/llvm-project/commit/ba66dfb11bcaef5e0dc21358b3712b491d61d020.dif
Author: Med Ismail Bennani
Date: 2024-05-09T14:13:44-07:00
New Revision: db9421381980cdf3d6914f8898a77d3237325019
URL:
https://github.com/llvm/llvm-project/commit/db9421381980cdf3d6914f8898a77d3237325019
DIFF:
https://github.com/llvm/llvm-project/commit/db9421381980cdf3d6914f8898a77d3237325019.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/91653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/91653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This should fix the various crashlog test failures on the bots:
```
lldb-shell ::
ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
lldb-shell :: ScriptInterpreter/Python/C
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/91653
This should fix the various crashlog test failures on the bots:
```
lldb-shell ::
ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test
lldb-shell :: ScriptInterpreter/Python/Crashlog/i
Author: Tomas Matheson
Date: 2024-05-09T21:54:48+01:00
New Revision: 639a740035b732e9bc0f43f3f95d1ce3acf82e1b
URL:
https://github.com/llvm/llvm-project/commit/639a740035b732e9bc0f43f3f95d1ce3acf82e1b
DIFF:
https://github.com/llvm/llvm-project/commit/639a740035b732e9bc0f43f3f95d1ce3acf82e1b.diff
https://github.com/tmatheson-arm closed
https://github.com/llvm/llvm-project/pull/90987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/91631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-05-09T13:51:52-07:00
New Revision: f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2
URL:
https://github.com/llvm/llvm-project/commit/f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2
DIFF:
https://github.com/llvm/llvm-project/commit/f4a7e1f9bac1f11e1db1c0a895f3f681838f89f2.
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/91631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/91631
>From 1f63d6807bc8a6b1e04cb96cbc7e4fd1572553e4 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 9 May 2024 12:51:39 -0700
Subject: [PATCH] [lldb/crashlog] Fix module binary resolution
This patch
@@ -418,9 +418,20 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in os.listdi
@@ -418,9 +418,20 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in os.listdi
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/91631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/91631
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -418,9 +418,20 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in os.listdi
@@ -848,6 +850,13 @@ void Breakpoint::GetDescription(Stream *s,
lldb::DescriptionLevel level,
const size_t num_locations = GetNumLocations();
const size_t num_resolved_locations = GetNumResolvedLocations();
+ // Grey out any disabled breakpoints in the list of breakpoint
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/91631
>From b849720f6559392f91c54be5987beeb8c8c3fe21 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 9 May 2024 12:39:01 -0700
Subject: [PATCH] [lldb/crashlog] Fix module binary resolution
This patch
@@ -848,6 +850,13 @@ void Breakpoint::GetDescription(Stream *s,
lldb::DescriptionLevel level,
const size_t num_locations = GetNumLocations();
const size_t num_resolved_locations = GetNumResolvedLocations();
+ // Grey out any disabled breakpoints in the list of breakpoint
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/91631
>From e2cd9670c20daac3f6a5f75806c7f48ed7b2ccd9 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 9 May 2024 11:38:03 -0700
Subject: [PATCH] [lldb/crashlog] Fix module binary resolution
This patch
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/91404
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
I changed this PR to make disabled breakpoints greyed out (per Ismail's
suggestion). Since this is being done at the `Breakpoint` level we have access
to the target and its debugger to access `GetUseColor()`.
https://github.com/llvm/llvm-project/pull/91404
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91404
>From c334f7357aebefa3e0b7af645396e699cf3a4c8d Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 11:08:29 -0700
Subject: [PATCH] [lldb][breakpoint] Grey out disabled breakpoints
This c
@@ -418,9 +418,22 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in os.listdi
@@ -418,9 +418,22 @@ def locate_module_and_debug_symbols(self):
with print_lock:
print('falling back to binary inside "%s"' % dsym)
self.symfile = dsym
-for filename in os.listdi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch fixes a bug in when resolving and loading modules from the binary
image list.
When loading a module, we would first use the UUID from the binary image list
with `dsymForUUID` to fetch t
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/91631
This patch fixes a bug in when resolving and loading modules from the binary
image list.
When loading a module, we would first use the UUID from the binary image list
with `dsymForUUID` to fetch the dSYM b
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/91107
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-05-09T10:39:05-07:00
New Revision: b3a835e129ed8a67cf393f9ee26989b36a3eff1c
URL:
https://github.com/llvm/llvm-project/commit/b3a835e129ed8a67cf393f9ee26989b36a3eff1c
DIFF:
https://github.com/llvm/llvm-project/commit/b3a835e129ed8a67cf393f9ee26989b36a3eff1c.
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/91107
>From d34abd53e2cd8484299516f8c7f01fe45e58e07c Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 9 May 2024 10:35:33 -0700
Subject: [PATCH] [lldb] Verify target stop-hooks support with scripted pr
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2024-05-09T10:28:23-07:00
New Revision: b9e3fa84d3fdfe718a4a3085f7adeda3d81f2568
URL:
https://github.com/llvm/llvm-project/commit/b9e3fa84d3fdfe718a4a3085f7adeda3d81f2568
DIFF:
https://github.com/llvm/llvm-project/commit/b9e3fa84d3fdfe718a4a3085f7adeda3d81f2568.d
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/91618
>From 167850e01960175e332b9da3d95d6054102a960a Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Thu, 9 May 2024 09:23:02 -0700
Subject: [PATCH] [lldb][enums] Remove broadcast bits from debugger
Remov
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/91162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-05-09T10:19:34-07:00
New Revision: 8585bf7542f1098bd03a667a408d42d2a815d305
URL:
https://github.com/llvm/llvm-project/commit/8585bf7542f1098bd03a667a408d42d2a815d305
DIFF:
https://github.com/llvm/llvm-project/commit/8585bf7542f1098bd03a667a408d42d2a815d305.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/91109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-05-09T10:13:20-07:00
New Revision: 785b143a402a282822c3d5e30bb4e2b1980c0b1e
URL:
https://github.com/llvm/llvm-project/commit/785b143a402a282822c3d5e30bb4e2b1980c0b1e
DIFF:
https://github.com/llvm/llvm-project/commit/785b143a402a282822c3d5e30bb4e2b1980c0b1e.
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/91109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/91109
>From 625245737c31ac4e2cf04417bc8457caa461ef31 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 9 May 2024 10:02:50 -0700
Subject: [PATCH] [lldb/crashlog] Enforce image loading policy
In `27f27d
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
Will debug this today.
https://github.com/llvm/llvm-project/pull/91321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> If this turns out to be necessary, one way to rate-limit them would be to
> have a nesting depth counter. Assuming that these imports happen recursively
> we could create only Progress objects for the top n layers.
Is the code that emits the progress event recursive too?
adrian-prantl wrote:
If this turns out to be necessary, one way to rate-limit them would be to have
a nesting depth counter. Assuming that these imports happen recursively we
could create only Progress objects for the top n layers.
https://github.com/llvm/llvm-project/pull/91452
__
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM but let's give Alex and Ismail a chance to take a look too.
https://github.com/llvm/llvm-project/pull/91618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fe0b7983a2f510cdede22cdf6c9227e32ded6a15
f338108d6b0cbb47e72663c58c1cbb17ee446cbc --
@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo {
m_cumulative_system_time.tv_usec > 0;
}
+ int8_t GetNiceValue() const { return m_nice_value; }
feg208 wrote:
Done. Agreed. I also added a note in the linux specific code. In l
@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo {
m_cumulative_system_time.tv_usec > 0;
}
+ int8_t GetNiceValue() const { return m_nice_value; }
+
+ void SetNiceValue(int8_t nice_value) { m_nice_value = nice_value; }
+
+ bool NiceValueIsVali
@@ -17,6 +17,7 @@
#include
#include
+#include
feg208 wrote:
removed
https://github.com/llvm/llvm-project/pull/91544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
@@ -117,6 +118,10 @@ bool ProcessInfo::IsScriptedProcess() const {
return m_scripted_metadata_sp && *m_scripted_metadata_sp;
}
+bool ProcessInstanceInfo::NiceValueIsValid() const {
+ return m_nice_value >= PRIO_MIN && m_nice_value <= PRIO_MAX;
feg208 wrote:
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
Removes the debugger broadcast bits from `Debugger.h` and instead uses the enum
from `lldb-enumerations.h`. Also adds the `eBroadcastSymbolChange` bit to the
enum in `lldb-enumerations.h`.
---
Ful
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/91544
>From 18b0d55d1c4e04842e531c7f7e304998f2b2ad4e Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Wed, 8 May 2024 15:36:16 -0700
Subject: [PATCH] [lldb] Adds additional fields to ProcessInfo
To implement SaveCore for
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/91618
Removes the debugger broadcast bits from `Debugger.h` and instead uses the enum
from `lldb-enumerations.h`. Also adds the `eBroadcastSymbolChange` bit to the
enum in `lldb-enumerations.h`.
>From f338108d6
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/90987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -237,6 +250,16 @@ class ProcessInstanceInfo : public ProcessInfo {
m_cumulative_system_time.tv_usec > 0;
}
+ int8_t GetNiceValue() const { return m_nice_value; }
emaste wrote:
nice and priority are not synonymous though, nice is one input int
@@ -12,6 +12,9 @@
#include "lldb/Utility/ProcessInfo.h"
#include "gtest/gtest.h"
+#include
+#include
feg208 wrote:
yeah. The cmake file enforces a linux-only build as well. However as @jimingham
pointed out someone could plausibly move this into a non-linu
JDevlieghere wrote:
> My understanding was that the progress increment is designed to be really
> cheap (writing two pointers) and that it's up to presentation layer to decide
> a t what frequency to update the UI.
>
> @JDevlieghere — is that perception correct?
You're correct about the prese
https://github.com/walter-erquinigo approved this pull request.
This all makes sense to me. Thank you!
https://github.com/llvm/llvm-project/pull/91591
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
labath wrote:
> > I am somewhat worried about this slowing down the actual operations it is
> > reporting progress on. I didn't really measure this, but intuitively, I'd
> > expect that a one of these operations (parsing/importing one type) would be
> > pretty fast, and that the whole process
@@ -254,6 +277,8 @@ class ProcessInstanceInfo : public ProcessInfo {
struct timespec m_system_time {};
struct timespec m_cumulative_user_time {};
struct timespec m_cumulative_system_time {};
+ int8_t m_nice_value = INT8_MAX;
feg208 wrote:
yeah. I'll mak
@@ -144,6 +144,19 @@ class ProcessInstanceInfo : public ProcessInfo {
long int tv_usec = 0;
};
+ enum class ProcessState {
+Unknown,
+Dead,
+DiskSleep,
+Idle,
+Paging,
+Parked,
+Running,
+Sleeping,
+TracedOrStopped,
+Zombie,
+ };
adrian-prantl wrote:
I think that would be a good start. Also tagging @jasonmolenda for advice.
https://github.com/llvm/llvm-project/pull/91321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
adrian-prantl wrote:
> I am somewhat worried about this slowing down the actual operations it is
> reporting progress on. I didn't really measure this, but intuitively, I'd
> expect that a one of these operations (parsing/importing one type) would be
> pretty fast, and that the whole process t
DavidSpickett wrote:
The only thing I can think of that breaks this is if some object wanted to use
the same symbol table section, but interpret it in a different way that changed
the address classes. I don't see any evidence of us doing that or needing to.
Even if we did it'd probably change
DavidSpickett wrote:
Alternative: https://github.com/llvm/llvm-project/pull/91603
https://github.com/llvm/llvm-project/pull/91585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Code in https://github.com/llvm/llvm-project/pull/90622 exposed a situation
where a symbol table may be loaded via a second copy of the same object.
This resulted in the first copy having its address
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/91603
Code in https://github.com/llvm/llvm-project/pull/90622 exposed a situation
where a symbol table may be loaded via a second copy of the same object.
This resulted in the first copy having its address class
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/91343
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Zequan Wu
Date: 2024-05-09T10:42:53-04:00
New Revision: fdede92d435068f31e7ea3a1dddb46d50343dd8c
URL:
https://github.com/llvm/llvm-project/commit/fdede92d435068f31e7ea3a1dddb46d50343dd8c
DIFF:
https://github.com/llvm/llvm-project/commit/fdede92d435068f31e7ea3a1dddb46d50343dd8c.diff
LOG
DavidSpickett wrote:
I realised that as it was, the calling object file would get its map updated
but not the other object file. Which is potentially a regression if we choose
to use one or the other file for a lookup. So now the methods update the member
map, and return the changes they made
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91585
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/91585
>From 34c5ac8292b34d96039c6c69326f3fceb5cc3499 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 9 May 2024 11:23:32 +
Subject: [PATCH 1/2] [lldb][ELF] Return address class map from symbol table
1 - 100 of 127 matches
Mail list logo
