[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-12 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/77547 >From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 9 Jan 2024 18:32:06 -0800 Subject: [PATCH 1/6] [lldb][Progress] Separate title and details Per thi

[Lldb-commits] [lldb] [libc] [compiler-rt] [libcxxabi] [flang] [libcxx] [clang-tools-extra] [lld] [clang] [llvm] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

2024-01-12 Thread Krzysztof Parzyszek via lldb-commits
@@ -3655,8 +3661,7 @@ void Fortran::lower::genOpenMPDeclarativeConstruct( Fortran::lower::pft::Evaluation &eval, const Fortran::parser::OpenMPDeclarativeConstruct &omp) { genOMP(converter, eval, omp); kparzysz wrote: I made all `genOMP` functions hav

[Lldb-commits] [lldb] [libc] [compiler-rt] [libcxxabi] [flang] [libcxx] [clang-tools-extra] [lld] [clang] [llvm] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

2024-01-12 Thread Krzysztof Parzyszek via lldb-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/77758 >From 62f31654ec66fe0e2a27200d0484d3c70d4ce2c1 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 20 Dec 2023 15:12:04 -0600 Subject: [PATCH 1/5] [Flang][OpenMP] Separate creation of work-sharing and

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/78005 >From 09f1556fd0615f42fe9dd49bf8c2355517f6e0da Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 12 Jan 2024 16:39:47 -0800 Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands vs va

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. debugserver never expects libdyld's API (to iterate over the binary images in a process) to return the same binary multiple times, and lldb won't handle that well if we pass that behavior along. Eliminating the incorrect dupli

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3edf82d5566ed5c9898f52b5591c05f6366d6bac...6290aaa803324f6942e642b888f41966f4cc3709 lldb/

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes The previous logic for determining if an expression was a command or variable expression in the repl would incorrectly identify the context in many common cases where a local variable name partially overlaps

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/78005 The previous logic for determining if an expression was a command or variable expression in the repl would incorrectly identify the context in many common cases where a local variable name partially overlaps with

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes There's a bad interaction between the macOS 14 dyld and the "dyld_sim" shim that comes from older (iOS 15) simulator downloads that results in dyld reporting some modules twice in the return from the dyld callback

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-12 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/78004 There's a bad interaction between the macOS 14 dyld and the "dyld_sim" shim that comes from older (iOS 15) simulator downloads that results in dyld reporting some modules twice in the return from the dyld cal

[Lldb-commits] [clang-tools-extra] [libcxx] [clang] [flang] [lldb] [llvm] [mlir] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Phoebe Wang via lldb-commits
@@ -5336,6 +5336,7 @@ X86: operand in a SSE register. If AVX is also enabled, can also be a 256-bit vector operand in an AVX register. If AVX-512 is also enabled, can also be a 512-bit vector operand in an AVX512 register. Otherwise, an error. +- ``Ws``: A symbolic refere

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
@@ -357,7 +357,7 @@ void LineTable::Dump(Stream *s, Target *target, Address::DumpStyle style, Address::DumpStyle fallback_style, bool show_line_ranges) { const size_t count = m_entries.size(); LineEntry line_entry; - FileSpec prev_file; + SupportFil

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
@@ -133,7 +134,8 @@ struct LineEntry { AddressRange range; ///< The section offset address range for this line entry. FileSpec file; ///< The source file, possibly mapped by the target.source-map ///setting - FileSpec original_file; ///< The original sour

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with nits https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -20,7 +20,7 @@ LineEntry::LineEntry() void LineEntry::Clear() { range.Clear(); file.Clear(); - original_file.Clear(); + original_file = std::make_shared(); JDevlieghere wrote: Correct, this ensures I can always assume that the shared pointer is valid.

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Adrian Prantl via lldb-commits
@@ -20,7 +20,7 @@ LineEntry::LineEntry() void LineEntry::Clear() { range.Clear(); file.Clear(); - original_file.Clear(); + original_file = std::make_shared(); adrian-prantl wrote: Is this default-constructing an empty object? Should it be a null shared_p

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This is a series of 4 NFC commit to store `SupportFile`s rather than `FileSpec`s in `LineEntry`. This is work towards having the `SourceManager`operate on `SupportFile`s so that it can (1) validate

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/77999 This is a series of 4 NFC commit to store `SupportFile`s rather than `FileSpec`s in `LineEntry`. This is work towards having the `SourceManager`operate on `SupportFile`s so that it can (1) validate the Che

[Lldb-commits] [clang] [llvm] [clang-tools-extra] [lldb] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

2024-01-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/77920 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f4461cf - [lldb][test] Add tests for target.max-string-summary-length setting (#77920)

2024-01-12 Thread via lldb-commits
Author: Michael Buch Date: 2024-01-12T22:26:31Z New Revision: f4461cf4f30417be118487142bca6635e07ed1e6 URL: https://github.com/llvm/llvm-project/commit/f4461cf4f30417be118487142bca6635e07ed1e6 DIFF: https://github.com/llvm/llvm-project/commit/f4461cf4f30417be118487142bca6635e07ed1e6.diff LOG:

[Lldb-commits] [clang] [llvm] [clang-tools-extra] [lldb] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

2024-01-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/77920 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread David Goldman via lldb-commits
https://github.com/DavidGoldman closed https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 40a361a - [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (#77026)

2024-01-12 Thread via lldb-commits
Author: John Harrison Date: 2024-01-12T17:12:30-05:00 New Revision: 40a361acf5ce255054c5b2e5f67a24325bfe0398 URL: https://github.com/llvm/llvm-project/commit/40a361acf5ce255054c5b2e5f67a24325bfe0398 DIFF: https://github.com/llvm/llvm-project/commit/40a361acf5ce255054c5b2e5f67a24325bfe0398.diff

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread Alex Langford via lldb-commits
@@ -0,0 +1,291 @@ +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (PR #77858)

2024-01-12 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/77858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c8ef88c - [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (#77858)

2024-01-12 Thread via lldb-commits
Author: Alex Langford Date: 2024-01-12T13:52:59-08:00 New Revision: c8ef88c446a3ff773c5be2fbf3df84b8b40c0c41 URL: https://github.com/llvm/llvm-project/commit/c8ef88c446a3ff773c5be2fbf3df84b8b40c0c41 DIFF: https://github.com/llvm/llvm-project/commit/c8ef88c446a3ff773c5be2fbf3df84b8b40c0c41.diff

[Lldb-commits] [lldb] [lldb] Support changes to TLS on macOS (PR #77988)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes I decided to resubmit #77854 but broken up into multiple commits for better reviewability. I recommend reviewing each commit individually, the overall change is quite large. rdar://120676969 --- Full dif

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Alex Langford via lldb-commits
bulbazord wrote: I broke up this PR into multiple commits and resubmitted at https://github.com/llvm/llvm-project/pull/77988. Please take a look! https://github.com/llvm/llvm-project/pull/77854 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/77854 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support changes to TLS on macOS (PR #77988)

2024-01-12 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/77988 I decided to resubmit #77854 but broken up into multiple commits for better reviewability. I recommend reviewing each commit individually, the overall change is quite large. rdar://120676969 >From cf2597f907

[Lldb-commits] [lldb] e27561f - [lldb] Move MD5 Checksum from FileSpec to SupportFile

2024-01-12 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-01-12T13:08:24-08:00 New Revision: e27561fc7de0231f2efdb750f2092c3ac807c1a3 URL: https://github.com/llvm/llvm-project/commit/e27561fc7de0231f2efdb750f2092c3ac807c1a3 DIFF: https://github.com/llvm/llvm-project/commit/e27561fc7de0231f2efdb750f2092c3ac807c1a3.d

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-12 Thread Greg Clayton via lldb-commits
@@ -35,25 +42,28 @@ Progress::~Progress() { ReportProgress(); } -void Progress::Increment(uint64_t amount, std::string update) { +void Progress::Increment(uint64_t amount, + std::optional updated_detail) { if (amount > 0) { std::lock_guard gua

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-12 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Thanks for the changes. On comment might be able to be reverted, but this looks good. https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-12 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tools-extra] [flang] [openmp] [libcxx] [clang] [libc] [llvm] [mlir] [BOLT] Embed cold mapping info into function entry in BAT (PR #76903)

2024-01-12 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/76903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tools-extra] [flang] [openmp] [libcxx] [clang] [libc] [llvm] [mlir] [BOLT] Embed cold mapping info into function entry in BAT (PR #76903)

2024-01-12 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/76903 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [clang-tools-extra] [flang] [lldb] [libcxx] [clang] [libclc] [libunwind] [libc] [llvm] [compiler-rt] [lld] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-12 Thread Sean Perry via lldb-commits
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) { #endif } -#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE) +#elif defined(QUAD_PRECISION) perry-ca wrote: I've put up #77981 for review. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/77966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,21 @@ +import os +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +@skipUnlessDarwin +class TargetModuleAddDsymTest(TestBase): +@no_debug_info_test +def test_target_module_add(self): +"""Test that you can add a dSYM as

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,21 @@ +import os +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * + + +@skipUnlessDarwin +class TargetModuleAddDsymTest(TestBase): +@no_debug_info_test +def test_target_module_add(self): +"""Test that you can add a dSYM as

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: If a module is debug info only, like a dSYM file, and then you try to `target module add` it to a target, it would be nice to add it as the symbol file for an already existing module. The test below, I wouldn't want a target with two things representing a

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread John Harrison via lldb-commits
@@ -1210,15 +1210,16 @@ bool SBValue::GetDescription(SBStream &description) { ValueLocker locker; lldb::ValueObjectSP value_sp(GetSP(locker)); - if (value_sp) { -DumpValueObjectOptions options; -options.SetUseDynamicType(m_opaque_sp->GetUseDynamic()); -options

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread John Harrison via lldb-commits
@@ -405,6 +405,9 @@ struct VariableDescription { /// Create a JSON object that represents these extensions to the DAP variable /// response. llvm::json::Object GetVariableExtensionsJSON(); + + /// Returns a description of the value appropraite for the specified context.

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread John Harrison via lldb-commits
@@ -173,21 +173,21 @@ TryCreateAutoSummaryForContainer(lldb::SBValue &v) { lldb::SBValue child = v.GetChildAtIndex(i); if (llvm::StringRef name = child.GetName(); !name.empty()) { - llvm::StringRef value; + llvm::StringRef desc; if (llvm::StringRef sum

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/77026 >From 56d1520f2ce7eb9a9f0c5b5c199deefab15dadfa Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 4 Jan 2024 15:42:35 -0800 Subject: [PATCH] [lldb-dap] Updating VariableDescription to use GetDescription() fo

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/77026 >From 52d6dc8f26477b8fba839194ac1485274312a865 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 4 Jan 2024 15:42:35 -0800 Subject: [PATCH] [lldb-dap] Updating VariableDescription to use GetDescription() fo

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Greg Clayton via lldb-commits
clayborg wrote: It will be nice to not have the TLS test failing on macOS anymore! https://github.com/llvm/llvm-project/pull/77854 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [flang] [libc] [lldb] [compiler-rt] [lld] [llvm] [libcxx] [clang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Stanislav Mekhanoshin via lldb-commits
@@ -703,8 +713,37 @@ void WaitcntBrackets::updateByEvent(const SIInstrInfo *TII, setRegScore(RegNo, T, CurrScore); } } -if (Inst.mayStore() && (TII->isDS(Inst) || mayWriteLDSThroughDMA(Inst))) { - setRegScore(SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS, T, Curr

[Lldb-commits] [flang] [libcxx] [compiler-rt] [llvm] [libc] [lldb] [lld] [clang-tools-extra] [clang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Stanislav Mekhanoshin via lldb-commits
@@ -1183,9 +1228,21 @@ bool SIInsertWaitcnts::generateWaitcntInstBefore(MachineInstr &MI, // No need to wait before load from VMEM to LDS. if (TII->mayWriteLDSThroughDMA(MI)) continue; -unsigned RegNo = SQ_MAX_PGM_VGPRS + EXTRA_VGPR_LDS; +

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/77854 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [libcxx] [compiler-rt] [llvm] [libc] [lldb] [lld] [clang-tools-extra] [clang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Stanislav Mekhanoshin via lldb-commits
@@ -130,6 +130,8 @@ ; GCN-O0-NEXT:MachineDominator Tree Construction ; GCN-O0-NEXT:Machine Natural Loop Construction ; GCN-O0-NEXT:MachinePostDominator Tree Construction +; GCN-O0-NEXT:Basic Alias Analysis (stateless AA impl) +; GCN-O0-NEXT:

[Lldb-commits] [flang] [libcxx] [compiler-rt] [llvm] [libc] [lldb] [lld] [clang-tools-extra] [clang] [AMDGPU] Use alias info to relax waitcounts for LDS DMA (PR #74537)

2024-01-12 Thread Stanislav Mekhanoshin via lldb-commits
https://github.com/rampitec updated https://github.com/llvm/llvm-project/pull/74537 >From 7e382620cdc5999c645ed0746f242595f0294c58 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Mon, 4 Dec 2023 16:11:53 -0800 Subject: [PATCH 01/10] [AMDGPU] Use alias info to relax waitcounts for LDS

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @JDevlieghere Thank you! > > I will remove the code that handles DW_OP_WASM_location as you suggest. Given we don't have a good solution for stacked commits, you don't necessarily need to remove it here, and rebase it once the other PR has been merged. > For what concer

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread Paolo Severini via lldb-commits
paolosevMSFT wrote: @JDevlieghere Thank you! I will remove the code that handles DW_OP_WASM_location as you suggest. For what concerns testing, I took a very quick look at `GdbRemoteTestCaseBase` and if I am not wrong, it works by spawning an inferior processor attaching to an inferior proces

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > @JDevlieghere I created a new PR and closed #76683 because I made a mess with > a git rebase, and since the other PR had just started I thought it made sense > to start anew. I apologize for the confusion. Here I have already addressed > most of your comments from 76683.

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/77966 >From ca65108fe01931482110bf6dabef1550fd6a307e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 11 Jan 2024 09:19:31 -0800 Subject: [PATCH 1/2] [lldb] Move CanBeTarget logic into the ObjectFile pl

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff dd5ce4572fb90323799f1bdf585c01d08613e277 aa8cda04994699b23df3b5dd149d9204272aa74b --

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r dd5ce4572fb90323799f1bdf585c01d08613e277...aa8cda04994699b23df3b5dd149d9204272aa74b lldb/

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (PR #77858)

2024-01-12 Thread Alex Langford via lldb-commits
https://github.com/bulbazord updated https://github.com/llvm/llvm-project/pull/77858 >From d138a85dbddf5373e0a60d8467768c186e343f1b Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Thu, 11 Jan 2024 16:51:03 -0800 Subject: [PATCH 1/2] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDL

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Generally, separate debug info files are not object files. The exception are dSYMs which are Mach-O and often contain enough information to be used as a module. This patch allows users to add dSYM sy

[Lldb-commits] [lldb] [lldb] Support dSYMs as modules (PR #77966)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/77966 Generally, separate debug info files are not object files. The exception are dSYMs which are Mach-O and often contain enough information to be used as a module. This patch allows users to add dSYM symbol fil

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Alex Langford via lldb-commits
bulbazord wrote: > Currently this is a little hard to read given a bunch of shared setup > followed by two possible ways to read the TLS data. If those implementations > don't require too many inputs, it might be worth splitting this out into two > helper functions to make this easier to follo

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (PR #77858)

2024-01-12 Thread Alex Langford via lldb-commits
bulbazord wrote: > LGTM! > > Should we `#include llvm/Support/Error.h"` in the BreakpointIDList header? Ah, I didn't add it but it builds so it's probably getting it transitively. I'll add it for future-proofing. https://github.com/llvm/llvm-project/pull/77858

[Lldb-commits] [lldb] [clang] [clang-tools-extra] [llvm] [lldb][test] Add tests for target.max-string-summary-length setting (PR #77920)

2024-01-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/77920 >From 4de3716b55a22dc8b7dda621889089f390026739 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 12 Jan 2024 12:34:16 + Subject: [PATCH 1/2] [lldb][test] Add tests for target.max-string-summary-lengt

[Lldb-commits] [llvm] [clang-tools-extra] [lldb] [libcxx] [clang] [flang] [mlir] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Fangrui Song via lldb-commits
@@ -56966,6 +56965,17 @@ void X86TargetLowering::LowerAsmOperandForConstraint(SDValue Op, } return; } + case 'W': { +assert(Constraint[1] == 's'); +if (const auto *GA = dyn_cast(Op)) { + Ops.push_back(DAG.getTargetGlobalAddress(GA->getGlobal(), SDLoc(Op

[Lldb-commits] [llvm] [clang-tools-extra] [lldb] [libcxx] [clang] [flang] [mlir] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Fangrui Song via lldb-commits
@@ -0,0 +1,34 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=i686 < %s | FileCheck %s +; RUN: llc -mtriple=x86_64 < %s | FileCheck %s + +@var = external dso_local global i32, align 4 + +define dso_local void @test() { +; CHEC

[Lldb-commits] [llvm] [clang-tools-extra] [lldb] [libcxx] [clang] [flang] [mlir] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/77886 >From f5a33f9e6893250e3584a77630b771ee76693c20 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 11 Jan 2024 23:42:38 -0800 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[Lldb-commits] [llvm] [clang-tools-extra] [libclc] [libc] [lld] [lldb] [clang] [libcxx] [libcxxabi] [flang] [libunwind] [compiler-rt] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-12 Thread Alexander Richardson via lldb-commits
@@ -374,10 +376,10 @@ static __inline fp_t __compiler_rt_fmax(fp_t x, fp_t y) { #endif } -#elif defined(QUAD_PRECISION) && defined(CRT_HAS_TF_MODE) +#elif defined(QUAD_PRECISION) arichardson wrote: Looks like this was actually required. Probably needs to be c

[Lldb-commits] [lldb] [lldb][libc++] Adds missing C++20 calendar data formatters. (PR #77954)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mark de Wever (mordante) Changes This is a followup of #76983 and adds the libc++ data formatters for - weekday, - weekday_indexed, - weekday_last, - month_weekday, - month_weekday_last, - year_month, - year_month_day_last - year_month_weekd

[Lldb-commits] [lldb] [lldb][libc++] Adds missing C++20 calendar data formatters. (PR #77954)

2024-01-12 Thread Mark de Wever via lldb-commits
https://github.com/mordante created https://github.com/llvm/llvm-project/pull/77954 This is a followup of #76983 and adds the libc++ data formatters for - weekday, - weekday_indexed, - weekday_last, - month_weekday, - month_weekday_last, - year_month, - year_month_day_last - year_month_weekday,

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread Paolo Severini via lldb-commits
paolosevMSFT wrote: @JDevlieghere I created a new PR and closed [https://github.com/llvm/llvm-project/pull/76683](https://github.com/llvm/llvm-project/pull/76683) because I made a mess with a git rebase, and since the other PR had just started I thought it made sense to start anew. I apologize

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Paolo Severini (paolosevMSFT) Changes Add support for source-level debugging of WebAssembly code that runs in a WebAssembly engine. The idea is to use the GDB-remote protocol to connect to a Wasm engine that implements a GDB-remote stub t

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #77949)

2024-01-12 Thread Paolo Severini via lldb-commits
https://github.com/paolosevMSFT created https://github.com/llvm/llvm-project/pull/77949 Add support for source-level debugging of WebAssembly code that runs in a WebAssembly engine. The idea is to use the GDB-remote protocol to connect to a Wasm engine that implements a GDB-remote stub that o

[Lldb-commits] [flang] [llvm] [compiler-rt] [lld] [libcxx] [clang] [mlir] [lldb] [clang-tools-extra] [DWARFLinker][NFC] Decrease DWARFLinker dependence on DwarfStreamer. (PR #77932)

2024-01-12 Thread Alexey Lapshin via lldb-commits
https://github.com/avl-llvm updated https://github.com/llvm/llvm-project/pull/77932 >From 30a603f6d37afecdb2cb150bd98acd27c8d8baf5 Mon Sep 17 00:00:00 2001 From: Alexey Lapshin Date: Fri, 12 Jan 2024 13:07:33 +0300 Subject: [PATCH] [DWARFLinker][NFC] Decrease DWARFLinker dependence on DwarfStr

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Currently this is a little hard to read given a bunch of shared setup followed by two possible ways to read the TLS data. If those implementations don't require too many inputs, it might be worth splitting this out into two helper functions to make th

[Lldb-commits] [lldb] [lldb] Adjust DynamicLoaderDarwin::GetThreadLocalData to support changes to TLS on macOS (PR #77854)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -1048,70 +1048,107 @@ DynamicLoaderDarwin::GetThreadLocalData(const lldb::ModuleSP module_sp, std::lock_guard guard(m_mutex); - const uint32_t addr_size = m_process->GetAddressByteSize(); + lldb_private::Address tls_addr; + if (!module_sp->ResolveFileAddress(tls_file

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (PR #77858)

2024-01-12 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. LGTM! Should we `#include llvm/Support/Error.h"` in the BreakpointIDList header? https://github.com/llvm/llvm-project/pull/77858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb][NFCI] Remove CommandReturnObject from BreakpointIDList (PR #77858)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. This improves layering so LGTM! https://github.com/llvm/llvm-project/pull/77858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (PR #77919)

2024-01-12 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/77919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 844a8dc - [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (#77919)

2024-01-12 Thread via lldb-commits
Author: Michael Buch Date: 2024-01-12T16:11:59Z New Revision: 844a8dcaafb3efcac936e0d89df857f818e5a209 URL: https://github.com/llvm/llvm-project/commit/844a8dcaafb3efcac936e0d89df857f818e5a209 DIFF: https://github.com/llvm/llvm-project/commit/844a8dcaafb3efcac936e0d89df857f818e5a209.diff LOG:

[Lldb-commits] [lldb] [lldb][ValueObject][NFC] Remove unused parameter to ReadPointedString (PR #77919)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/77919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,295 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,15 @@ +# This file comes from https://reviews.llvm.org/D78978. +# Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + JDevlieghere wrote: Remove this https://github.com/llvm/llvm-project/pull/76683

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,295 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + JDevlieghere wrote: Remove this here and everywhere else. https://github.com/llvm/llvm-project/pull/76683 ___

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,295 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,135 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/76683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,135 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -2595,6 +2606,37 @@ bool DWARFExpression::Evaluate( break; } +case DW_OP_WASM_location: { + uint8_t wasm_op = opcodes.GetU8(&offset); + uint32_t index; + + /* LLDB doesn't have an address space to represents WebAssembly Locals,

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,295 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,295 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,295 @@ +// This file comes from https://reviews.llvm.org/D78978. +// Author: [@paolosev](https://reviews.llvm.org/p/paolosev/). + +//===-- ProcessWasm.cpp ---===// +// +// Part of the LLVM Project, under the Apache Licens

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: Thanks for picking this up again. I was going to ask about testing and I see that Adrian asked a similar question on Phabricator in the original review. My recommendation would be to use `GdbRemoteTestCaseBase` style tests for this, as they'll run on

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -2595,6 +2606,37 @@ bool DWARFExpression::Evaluate( break; } +case DW_OP_WASM_location: { + uint8_t wasm_op = opcodes.GetU8(&offset); + uint32_t index; + + /* LLDB doesn't have an address space to represents WebAssembly Locals, + * GLobals

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Paolo Severini (paolosevMSFT) Changes Add support for source-level debugging of WebAssembly code that runs in a WebAssembly engine. The idea is to use the GDB-remote protocol to connect to a Wasm engine that implements a GDB-remote stub

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-12 Thread Paolo Severini via lldb-commits
https://github.com/paolosevMSFT ready_for_review https://github.com/llvm/llvm-project/pull/76683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >