https://github.com/JDevlieghere commented:

Thanks for picking this up again. I was going to ask about testing and I see 
that Adrian asked a similar question on Phabricator in the original review. My 
recommendation would be to use `GdbRemoteTestCaseBase` style tests for this, as 
they'll run on all the existing bots. If you want to integration test the stub 
this is actually going to talk to it would be great to have that running in CI 
too, but that's not a requirement to get this merged. 

The support for `DW_OP_WASM_location` seems like it can be hoisted out in a 
separate patch with its own dedicated  test. 

https://github.com/llvm/llvm-project/pull/76683
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to