[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw commented: Thank you for the great work. I really appreciate the excellent documentation that you wrote. I am not well versed enough in the code to comment on the implementation, but your comments were so good that I intuitively understood the point of the new class

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -56,6 +57,13 @@ class CompilerDeclContext { return m_type_system != nullptr && m_opaque_decl_ctx != nullptr; } + /// Populate a valid compiler context from the current decl context. + /// + /// \returns A valid vector of CompilerContext entries that describes + //

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -415,70 +415,19 @@ class Module : public std::enable_shared_from_this, void FindGlobalVariables(const RegularExpression ®ex, size_t max_matches, VariableList &variable_list); - /// Find types by name. - /// - /// Type lookups in modules go t

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match -

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -301,21 +301,20 @@ class SymbolFile : public PluginInterface { bool include_inlines, SymbolContextList &sc_list); virtual void FindFunctions(const RegularExpression ®ex, bool include_inlines, SymbolContextList &sc_l

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -84,6 +84,13 @@ class CompilerDecl { // based argument index CompilerType GetFunctionArgumentType(size_t arg_idx) const; + /// Populate a valid compiler context from the current declaration. + /// + /// \returns A valid vector of CompilerContext entries that describe

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -340,26 +340,22 @@ class ModuleList { lldb::SymbolType symbol_type, SymbolContextList &sc_list) const; - /// Find types by name. + /// Find types using a type matching object that contains all s

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw edited https://github.com/llvm/llvm-project/pull/74786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [llvm] [lld] [lldb] [clang-tools-extra] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/74916 >From ab33bda7fd31fbfc28344bb6f81ce08394e7c3fd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 7 Dec 2023 23:20:42 -0800 Subject: [PATCH 1/3] [ADT] Rename SmallString::{starts,ends}with to {starts,e

[Lldb-commits] [clang] [llvm] [lld] [lldb] [clang-tools-extra] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > flang and bolt are not changed? Right. Somehow, `SmallString::{startswith,endswith}` do not occur there. By the way, they are not to be confused with `StringRef::{startswith,endswith}, which is everywhere. https://github.com/llvm/llvm-project/pull/74916 _

[Lldb-commits] [llvm] [lld] [clang-tools-extra] [lldb] [clang] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Fangrui Song via lldb-commits
MaskRay wrote: flang and bolt are not changed? https://github.com/llvm/llvm-project/pull/74916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [clang] [lld] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/74916 >From ab33bda7fd31fbfc28344bb6f81ce08394e7c3fd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 7 Dec 2023 23:20:42 -0800 Subject: [PATCH 1/2] [ADT] Rename SmallString::{starts,ends}with to {starts,e

[Lldb-commits] [llvm] [lldb] [lld] [clang-tools-extra] [clang] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes This patch renames {starts,ends}with to {starts,ends}_with for consistency with std::{string,string_view}::{starts,ends}_with in C++20. Since there are only a handful of occurrences, this patch skips th

[Lldb-commits] [lldb] [llvm] [clang-tools-extra] [clang] [lld] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/74916 This patch renames {starts,ends}with to {starts,ends}_with for consistency with std::{string,string_view}::{starts,ends}_with in C++20. Since there are only a handful of occurrences, this patch skips the d

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: One other way to test is to create a python test that makes a test windows binary that creates a thread using the Windows APIs and then we set a breakpoint in one of the thread functions and then verify the thread name is returned in the output of "thread

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: > Sorry, it's been a while since I last reviewed this and I must admit I forgot > about this in the mean time. The only thing I'd like to check before we can > land this is to hear from @Michael137 who has been actively working on > FindTypes performance recently whether this a

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: > Note, I thought about adding an `SBDebugger::GetSharedModules or something, > but I don't actually think that's a good thing to give external access to. > Some day we should make an SBTestAPI with some useful for testing but not for > the SB API library so we can make this so

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/74861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: `{${function.is-optimized} [opt]}` is how is already is and can be done with frame formats, so I agree with this patch that if the user customizes it, they have complete control and we shouldn't add anything. Does everyone else agree? https://github.com/llvm/llvm-project/pull/7

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -33,9 +39,14 @@ namespace lldb_dap { /// \param[in] strm /// The stream that will receive the prefix, prompt + command and /// all command output. +/// +/// \param[in] parse_command_directives +/// If \b false, then command prefixes like \b ! or \b ? are not pars

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix, const char *error = result.GetError(); strm << error; } + }; + + lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter(); + for (llvm::StringRef command : commands) { +lld

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. I would rather not terminate the debug session if we get erorrs on `!`. It would be nice if the `RunLLDBCommands` function could take an extra `bool &fatal_error` that clients could check after running when needed to decide wh

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -13,16 +13,22 @@ namespace lldb_dap { void RunLLDBCommands(llvm::StringRef prefix, const llvm::ArrayRef &commands, - llvm::raw_ostream &strm) { + llvm::raw_ostream &strm, bool parse_command_directives) { -

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -33,9 +39,14 @@ namespace lldb_dap { /// \param[in] strm /// The stream that will receive the prefix, prompt + command and /// all command output. +/// +/// \param[in] parse_command_directives +/// If \b false, then command prefixes like \b ! or \b ? are not pars

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -13,16 +13,22 @@ namespace lldb_dap { void RunLLDBCommands(llvm::StringRef prefix, const llvm::ArrayRef &commands, - llvm::raw_ostream &strm) { + llvm::raw_ostream &strm, bool parse_command_directives) { if (co

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/74808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix, const char *error = result.GetError(); strm << error; } + }; + + lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter(); + for (llvm::StringRef command : commands) { +lld

[Lldb-commits] [lldb] [lldb][draft] All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-08 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/74912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][draft] All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-08 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/74912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-08 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/74912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

2023-12-08 Thread Pete Lawrence via lldb-commits
https://github.com/PortalPete created https://github.com/llvm/llvm-project/pull/74912 Many methods return `nullptr` or `ValueObjectSP()` to represent an invalid result. For methods that have a `Status &error` parameter and return an `ValueObjectSP`, the return value *becomes* the container

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-08 Thread Walter Erquinigo via lldb-commits
@@ -1101,6 +1101,29 @@ std::string CreateUniqueVariableNameForDisplay(lldb::SBValue v, // can use this optional information to present the // children in a paged UI and fetch them in chunks." // } +// "declaration": { +//

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Walter Erquinigo via lldb-commits
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix, const char *error = result.GetError(); strm << error; } + }; + + lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter(); + for (llvm::StringRef command : commands) { +lld

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread via lldb-commits
jimingham wrote: Would it make sense to have opt be the result of a frame-format token, which we could put in the default format (function.optimization?) and people could add or not in custom formats? Jim > On Dec 8, 2023, at 3:59 PM, Alex Langford ***@***.***> wrote: > > > @bulbazord comme

[Lldb-commits] [llvm] [clang-tools-extra] [libcxx] [flang] [lld] [openmp] [lldb] [libcxxabi] [compiler-rt] [mlir] [clang] [libc] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via lldb-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/11] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?= =?UTF

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-08 Thread Alex Langford via lldb-commits
@@ -1101,6 +1101,29 @@ std::string CreateUniqueVariableNameForDisplay(lldb::SBValue v, // can use this optional information to present the // children in a paged UI and fetch them in chunks." // } +// "declaration": { +//

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I think conceptually this makes sense, but I somewhat wonder if folks would get confused when they have a custom frame format and don't see the [opt] in there? The current behavior is that [opt] is always there so folks know they don't have to put it in

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Alex Langford via lldb-commits
@@ -33,14 +39,49 @@ void RunLLDBCommands(llvm::StringRef prefix, const char *error = result.GetError(); strm << error; } + }; + + lldb::SBCommandInterpreter interp = g_dap.debugger.GetCommandInterpreter(); + for (llvm::StringRef command : commands) { +lld

[Lldb-commits] [lldb] [lldb][NFC] Simplify DWARRFDeclContext::GetQualifiedName (PR #74788)

2023-12-08 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. TIL about this overload of `llvm::interleave`!!! https://github.com/llvm/llvm-project/pull/74788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-08 Thread via lldb-commits
jimingham wrote: Note, I thought about adding an SBDebugger::GetSharedModules or something, but I don't actually think that's a good thing to give external access to. Some day we should make an SBTestAPI with some useful for testing but not for the SB API library so we can make this sort of t

[Lldb-commits] [lldb] [polly] [mlir] [llvm] [openmp] [clang] [flang] [lld] [compiler-rt] [VPlan] Compute scalable VF in preheader for induction increment. (PR #74762)

2023-12-08 Thread via lldb-commits
https://github.com/ayalz commented: post-commit nit https://github.com/llvm/llvm-project/pull/74762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [flang] [lldb] [compiler-rt] [mlir] [polly] [clang] [llvm] [openmp] [VPlan] Compute scalable VF in preheader for induction increment. (PR #74762)

2023-12-08 Thread via lldb-commits
@@ -340,8 +340,14 @@ Value *VPInstruction::generateInstruction(VPTransformState &State, auto *Phi = State.get(getOperand(0), 0); // The loop step is equal to the vectorization factor (num of SIMD // elements) times the unroll factor (num of SIMD instructions)

[Lldb-commits] [compiler-rt] [mlir] [clang] [lldb] [llvm] [flang] [openmp] [polly] [lld] [VPlan] Compute scalable VF in preheader for induction increment. (PR #74762)

2023-12-08 Thread via lldb-commits
https://github.com/ayalz edited https://github.com/llvm/llvm-project/pull/74762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-08 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 44dc1e0baae7c4b8a02ba06dcf396d3d452aa873 438d35a7a7fca454718062583f91776ca018b2b1 --

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes When you debug a binary and the change & rebuild and then rerun in lldb w/o quitting lldb, the Modules in the Global Module Cache for the old binary & .o files if used are now "unreachable". Nothing in lldb is hol

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-08 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/74894 When you debug a binary and the change & rebuild and then rerun in lldb w/o quitting lldb, the Modules in the Global Module Cache for the old binary & .o files if used are now "unreachable". Nothing in lldb i

[Lldb-commits] [lld] [llvm] [mlir] [lldb] [flang] [clang] [openmp] [clang-tools-extra] [libcxx] [libcxxabi] [compiler-rt] [libc] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via lldb-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/11] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?= =?UTF

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Sorry, it's been a while since I last reviewed this and I must admit I forgot about this in the mean time. The only thing I'd like to check before we can land this is to hear from @Michael137 who has been actively working on FindTypes performance recently whether this alig

[Lldb-commits] [clang-tools-extra] [compiler-rt] [clang] [flang] [libc] [lld] [openmp] [mlir] [lldb] [libcxxabi] [llvm] [libcxx] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via lldb-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/10] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?= =?UTF

[Lldb-commits] [clang] [flang] [llvm] [lld] [libcxxabi] [libc] [lldb] [openmp] [compiler-rt] [libcxx] [clang-tools-extra] [mlir] [llvm] Support IFuncs on Darwin platforms (PR #73686)

2023-12-08 Thread Jon Roelofs via lldb-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/73686 >From bc152095691b32d1ad8539dfd60f5089df5eed8d Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Tue, 28 Nov 2023 10:39:44 -0800 Subject: [PATCH 01/10] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20?= =?UTF

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) { const char *file_name = file.GetFilename().AsCString(""); LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name); LLDB_LOG(log, "Parsing symbol table for {0}", file_name); - P

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-12-08 Thread Chelsea Cassanova via lldb-commits
@@ -2225,7 +2225,8 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) { const char *file_name = file.GetFilename().AsCString(""); LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name); LLDB_LOG(log, "Parsing symbol table for {0}", file_name); - P

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/74413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-08 Thread via lldb-commits
oltolm wrote: I have added a test. https://github.com/llvm/llvm-project/pull/74731 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-08 Thread Pete Lawrence via lldb-commits
PortalPete wrote: > > > doesn't appear to be anything that calls these methods > > > > > > Candidate for removal then? If so it still makes sense to fix them, then > > remove them. Saves fixing them again if they are brought back. > > Either way, I'm not going to block this by requiring a test

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-08 Thread via lldb-commits
https://github.com/oltolm updated https://github.com/llvm/llvm-project/pull/74731 >From 9383b8b92849c71a96b4b4e7e55f615d8f2efedb Mon Sep 17 00:00:00 2001 From: oltolm Date: Fri, 1 Dec 2023 16:49:13 +0100 Subject: [PATCH 1/2] lldb: add support for thread names on Windows --- .../Windows/Common

[Lldb-commits] [flang] [compiler-rt] [lldb] [libc] [openmp] [libcxx] [llvm] [libcxxabi] [clang-tools-extra] [mlir] [lld] [clang] [libc++] Fix `take_view::__sentinel`'s `operator==` (PR #74655)

2023-12-08 Thread Hristo Hristov via lldb-commits
@@ -8,10 +8,7 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17 -// sentinel() = default; -// constexpr explicit sentinel(sentinel_t end); -// constexpr sentinel(sentinel s) -// requires Const && convertible_to, sentinel_t>; +// constexpr sentinel_t base() const; --

[Lldb-commits] [compiler-rt] [openmp] [lldb] [polly] [mlir] [lld] [llvm] [clang] [flang] [VPlan] Initial modeling of VF * UF as VPValue. (PR #74761)

2023-12-08 Thread Florian Hahn via lldb-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/74761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [libcxx] [lldb] [libcxxabi] [clang-tools-extra] [lld] [llvm] [clang] [flang] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-08 Thread Stanislav Mekhanoshin via lldb-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: > I am really struggling to handle the scope of the changes here, IIUC there > are a handful of changes that could be split into separate commits and merged > independently of each other: there is some code being moved around, new > GetCompilerContext APIs, the new query, the r

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Thanks for the quick change, and I need to check sources for the anonymous namespace before I comment next time! https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes This is an extension to the protocol that emits the declaration information along with the metadata of each variable. This can be used by vscode extensions to implement, for example, a "goToDefin

[Lldb-commits] [lldb] [lldb-dap] Emit declarations along with variables (PR #74865)

2023-12-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/74865 This is an extension to the protocol that emits the declaration information along with the metadata of each variable. This can be used by vscode extensions to implement, for example, a "goToDefinition"

[Lldb-commits] [lldb] [lldb] Return index of element in ValueObject path instead of the element's value (PR #74413)

2023-12-08 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > > doesn't appear to be anything that calls these methods > > Candidate for removal then? If so it still makes sense to fix them, then > remove them. Saves fixing them again if they are brought back. > > Either way, I'm not going to block this by requiring a test case. I

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes Currently there's an include in which `[opt]` might be emitted twice if the frame format also asks for it. As a trivial fix, we should manually emit `[opt]` only if a custom frame format is not s

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/74861 Currently there's an include in which `[opt]` might be emitted twice if the frame format also asks for it. As a trivial fix, we should manually emit `[opt]` only if a custom frame format is not specifie

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/74808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/74808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Implement quiet commands (PR #74808)

2023-12-08 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/74808 >From d544ba0cc6836c0b5c2086edccfc2b41080174ef Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 8 Dec 2023 00:11:19 -0500 Subject: [PATCH] [lldb-dap] Implement quiet commands This adds support

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: I am really struggling to handle the scope of the changes here, IIUC there are a handful of changes that could be split into separate commits and merged independently of each other: there is some code being moved around, new GetCompilerContext APIs, the new query, the rep

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-08 Thread via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?=

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -130,6 +130,10 @@ class PluginProperties : public Properties { } }; +bool IsTypeTag(llvm::dwarf::Tag Tag) { felipepiovezan wrote: In the interest of expediency, I've moved it out of the anonymous namespace and made it static https://github.com/llvm/llv

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/74773 >From 9f38564875620a44a982a50492d87ee431baffcd Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 7 Dec 2023 13:41:44 -0800 Subject: [PATCH 1/3] [SymbolFileDWARF][NFC] Remove duplicated c

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [flang] [lldb] [lld] [clang] [llvm] [libcxxabi] [libcxx] [clang-tools-extra] [AMDGPU] GFX12: select @llvm.prefetch intrinsic (PR #74576)

2023-12-08 Thread Jay Foad via lldb-commits
@@ -959,6 +967,32 @@ def : GCNPat < } } // let OtherPredicates = [HasShaderCyclesRegister] +def SIMM24bitPtr : ImmLeaf (Imm);}] +>; + +multiclass SMPrefetchPat { + def : GCNPat < +(smrd_prefetch (SMRDImm i64:$sbase, i32:$offset), timm, timm, (i32 cache_type)), +(!cas

[Lldb-commits] [lldb] [clang] fixing issue #64441 (PR #74814)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan requested changes to this pull request. Hi @jeevanghimire, thank you for the PR! I believe the original issue was not about changing LLVM test inputs, but rather about changing clang-tidy to warn about this kind of patterns. Please see my rationale in a previo

[Lldb-commits] [clang] [lldb] fixing issue #64441 (PR #74814)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -34,7 +34,7 @@ namespace A { int myfunc (int a); int myfunc2(int a) { - return a + 2; +return a + 2; //just changing tab not much felipepiovezan wrote: In general, we don't add diffs that are unrelated to

[Lldb-commits] [clang] [lldb] fixing issue #64441 (PR #74814)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -56,10 +56,10 @@ namespace Foo = A::B; // namespace alias using Foo::myfunc; // using declaration -using namespace Foo;// using directive +//removing namespace foo; for quality naming felipepiovezan wrote: Hi @jeevanghimire, please note that t

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -130,6 +130,10 @@ class PluginProperties : public Properties { } }; +bool IsTypeTag(llvm::dwarf::Tag Tag) { felipepiovezan wrote: Do you prefer if I take it out of the namespace and make it static? In llvm-project/llvm I would have done because of the p

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-08 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?=

[Lldb-commits] [lldb] 61f1825 - [lldb][test] Disable image lookup colour test on Mac OS

2023-12-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-08T13:44:06Z New Revision: 61f18255fab3c404dc43a59091a750c22e5d0ccb URL: https://github.com/llvm/llvm-project/commit/61f18255fab3c404dc43a59091a750c22e5d0ccb DIFF: https://github.com/llvm/llvm-project/commit/61f18255fab3c404dc43a59091a750c22e5d0ccb.diff LOG

[Lldb-commits] [lldb] 810d09f - [lldb][test] Disable image lookup colour test on Windows

2023-12-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-08T13:36:41Z New Revision: 810d09faf89af53025205c540ef9980e2286e687 URL: https://github.com/llvm/llvm-project/commit/810d09faf89af53025205c540ef9980e2286e687 DIFF: https://github.com/llvm/llvm-project/commit/810d09faf89af53025205c540ef9980e2286e687.diff LOG

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/74773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -130,6 +130,10 @@ class PluginProperties : public Properties { } }; +bool IsTypeTag(llvm::dwarf::Tag Tag) { felipepiovezan wrote: I'll rename it. Regarding static, this function as well as most functions defined above it, are in an anonymous namespace

[Lldb-commits] [lldb] [SymbolFileDWARF][NFC] Remove duplicated code checking for type tags (PR #74773)

2023-12-08 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -3128,36 +3121,11 @@ SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext(const DWARFDIE &die) { if (type_system && !type_system->SupportsLanguage(GetLanguage(*type_die.GetCU( return true; - bool try_resolving_type = false; - // Don

[Lldb-commits] [lldb] ce3c7c0 - [lldb][test] Don't check line number in image lookup colour test

2023-12-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-08T13:34:07Z New Revision: ce3c7c09100803608177459b4d923f17742885f9 URL: https://github.com/llvm/llvm-project/commit/ce3c7c09100803608177459b4d923f17742885f9 DIFF: https://github.com/llvm/llvm-project/commit/ce3c7c09100803608177459b4d923f17742885f9.diff LOG

[Lldb-commits] [llvm] [flang] [lld] [polly] [lldb] [openmp] [clang] [compiler-rt] [mlir] [VPlan] Initial modeling of VF * UF as VPValue. (PR #74761)

2023-12-08 Thread Florian Hahn via lldb-commits
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/74761 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-08 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?=

[Lldb-commits] [flang] [lldb] [mlir] [polly] [openmp] [compiler-rt] [lld] [clang] [llvm] [VPlan] Compute scalable VF in preheader for induction increment. (PR #74762)

2023-12-08 Thread Florian Hahn via lldb-commits
https://github.com/fhahn closed https://github.com/llvm/llvm-project/pull/74762 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-08 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?=

[Lldb-commits] [lldb] ffd61c1 - [lldb] Add missing nullptr checks when colouring symbol output

2023-12-08 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-12-08T11:24:07Z New Revision: ffd61c1e96e9c8a472f305585930b45be0d639d3 URL: https://github.com/llvm/llvm-project/commit/ffd61c1e96e9c8a472f305585930b45be0d639d3 DIFF: https://github.com/llvm/llvm-project/commit/ffd61c1e96e9c8a472f305585930b45be0d639d3.diff LOG

[Lldb-commits] [lldb] [lldb] colorize symbols in image lookup with a regex pattern (PR #69422)

2023-12-08 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior ,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>,taalhaataahir0102 <23100...@lums.edu.pk>, =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?= L. Junior , =?utf-8?q?José?=

  1   2   >