[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Greg Clayton via lldb-commits
@@ -443,6 +455,9 @@ class FileSpec { /// The unique'd filename path. ConstString m_filename; + /// The optional MD5 checksum of the file. + Checksum m_checksum; + clayborg wrote: The DWARF 5 line table should have a file list where can we easily compute

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Greg Clayton via lldb-commits
@@ -443,6 +455,9 @@ class FileSpec { /// The unique'd filename path. ConstString m_filename; + /// The optional MD5 checksum of the file. + Checksum m_checksum; + clayborg wrote: This will increase the byte size of every FileSpec object by 16 bytes whic

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/71465 >From 54bde6b52bb02d1626611926e6d4e4b282a28081 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 6 Nov 2023 16:12:36 -0800 Subject: [PATCH] [lldb/Interpreter] Make Scripted*Interface base class a

[Lldb-commits] [lldb] 317481b - [lldb][test] TestConstStaticIntegralMember.py: un-XFAIL on Linux (#71486)

2023-11-06 Thread via lldb-commits
Author: Michael Buch Date: 2023-11-07T05:23:46Z New Revision: 317481b3c8b34b0c3f106c514e6aa39b70886110 URL: https://github.com/llvm/llvm-project/commit/317481b3c8b34b0c3f106c514e6aa39b70886110 DIFF: https://github.com/llvm/llvm-project/commit/317481b3c8b34b0c3f106c514e6aa39b70886110.diff LOG:

[Lldb-commits] [lldb] [lldb][test] TestConstStaticIntegralMember.py: un-XFAIL on Linux (PR #71486)

2023-11-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/71486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d08d9cf - [lldb][test] TestVTableValue.py: skip base_class_ptr test case on older Clang versions

2023-11-06 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2023-11-07T05:18:23Z New Revision: d08d9cf55629a300a54ab1660912b044145540f1 URL: https://github.com/llvm/llvm-project/commit/d08d9cf55629a300a54ab1660912b044145540f1 DIFF: https://github.com/llvm/llvm-project/commit/d08d9cf55629a300a54ab1660912b044145540f1.diff LOG:

[Lldb-commits] [lldb] [lldb][test] TestConstStaticIntegralMember.py: un-XFAIL on Linux (PR #71486)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is a newly added test which XPASSes on Linux --- Full diff: https://github.com/llvm/llvm-project/pull/71486.diff 1 Files Affected: - (modified) lldb/test/API/lang/cpp/const_static_integral_member/T

[Lldb-commits] [lldb] [lldb][test] TestConstStaticIntegralMember.py: un-XFAIL on Linux (PR #71486)

2023-11-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/71486 This is a newly added test which XPASSes on Linux >From acf1ba6c54bc897cf572a01bb0caeeff207f76dc Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 7 Nov 2023 05:10:44 + Subject: [PATCH] [lldb][test]

[Lldb-commits] [lldb] 15fc809 - Reland "[lldb][test] Add FindGlobalVariables tests for C++ inline static data members (#70641)"

2023-11-06 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2023-11-07T04:54:04Z New Revision: 15fc809404d4715822e5349b76dcca50eb100eec URL: https://github.com/llvm/llvm-project/commit/15fc809404d4715822e5349b76dcca50eb100eec DIFF: https://github.com/llvm/llvm-project/commit/15fc809404d4715822e5349b76dcca50eb100eec.diff LOG:

[Lldb-commits] [lldb] 470de2b - Reland "[lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (#71004)"

2023-11-06 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2023-11-07T04:54:01Z New Revision: 470de2bbec7f5fdd199775aa99c68ac76f4d5c74 URL: https://github.com/llvm/llvm-project/commit/470de2bbec7f5fdd199775aa99c68ac76f4d5c74 DIFF: https://github.com/llvm/llvm-project/commit/470de2bbec7f5fdd199775aa99c68ac76f4d5c74.diff LOG:

[Lldb-commits] [lldb] 7c3707a - Reland "clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (#70639)"

2023-11-06 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2023-11-07T04:53:54Z New Revision: 7c3707aea8a6f1fc245ad2862982b8a51b6c0fea URL: https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea DIFF: https://github.com/llvm/llvm-project/commit/7c3707aea8a6f1fc245ad2862982b8a51b6c0fea.diff LOG:

[Lldb-commits] [lldb] [lldb] BreakpointResolver{*}::CreateFromStructuredData should return shared pointers (PR #71477)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/71477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] BreakpointResolver{*}::CreateFromStructuredData should return shared pointers (PR #71477)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes BreakpointResolver::CreateFromStructuredData returns a BreakpointResolverSP, but all of the subclasses return raw pointers. Instead of creating a raw pointer and shoving it into a shared pointer, it seems

[Lldb-commits] [lldb] [lldb] BreakpointResolver{*}::CreateFromStructuredData should return shared pointers (PR #71477)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71477 BreakpointResolver::CreateFromStructuredData returns a BreakpointResolverSP, but all of the subclasses return raw pointers. Instead of creating a raw pointer and shoving it into a shared pointer, it seems reas

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-06 Thread José Lira Junior via lldb-commits
junior-jl wrote: Hi David! I'm working with @taalhaataahir0102 on this. I addressed some of your comments. First, in the renamed `DumpName`, I tried using `llvm` Regex instead of `std`. It is passing the tests, so I hope it's okay. One question about it, do you think `Address` is the right cl

[Lldb-commits] [mlir] [compiler-rt] [libcxx] [libcxxabi] [clang] [llvm] [lldb] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-11-06 Thread Anton Rydahl via lldb-commits
https://github.com/AntonRydahl edited https://github.com/llvm/llvm-project/pull/66968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [clang] [compiler-rt] [llvm] [lldb] [libcxxabi] [mlir] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-11-06 Thread Anton Rydahl via lldb-commits
@@ -466,6 +466,114 @@ Unpoisoning may not be an option, if (for example) you are not maintaining the a * You are using allocator, which does not call destructor during deallocation. * You are aware that memory allocated with an allocator may be accessed, even when unused by co

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with comments. https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -300,6 +300,16 @@ size_t SourceManager::DisplaySourceLinesWithLineNumbersUsingLastFile( break; } } + +Checksum checksum = last_file_sp->GetFileSpec().GetChecksum(); +if (checksum && checksum != last_file_sp->GetChecksum()) { + llvm::call_once(

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -9,11 +9,13 @@ #ifndef LLDB_CORE_SOURCEMANAGER_H #define LLDB_CORE_SOURCEMANAGER_H +#include "lldb/Utility/Checksum.h" #include "lldb/Utility/FileSpec.h" #include "lldb/lldb-defines.h" #include "lldb/lldb-forward.h" #include "llvm/Support/Chrono.h" +#include "llvm/Sup

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -420,13 +428,17 @@ class FileSpec { /// The lifetime of the StringRefs is tied to the lifetime of the FileSpec. std::vector GetComponents() const; + /// Return the checksum for this FileSpec or all zeros if there is none. + const Checksum &GetChecksum() const { retu

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -13,15 +13,18 @@ #include #include +#include "lldb/Utility/Checksum.h" #include "lldb/Utility/ConstString.h" #include "llvm/ADT/StringRef.h" #include "llvm/Support/FileSystem.h" #include "llvm/Support/FormatVariadic.h" +#include "llvm/Support/MD5.h"

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/71457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with comments. https://github.com/llvm/llvm-project/pull/71457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Convert LocateSymbolFile into a plugin (PR #71151)

2023-11-06 Thread Kevin Frei via lldb-commits
@@ -0,0 +1,4 @@ +add_subdirectory(Default) +if (CMAKE_SYSTEM_NAME MATCHES "Darwin") + add_subdirectory(DebugSymbols) kevinfrei wrote: I'm switching my previous PR to be a "Debuginfod" SymbolLocator plugin, and I think this plugin name is far too general. @clayb

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Depends on #71456. > > I considered an alternative where we don't store the `Checksum` in the > `FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a > `FileSpec`. The reason I didn't got with this approach is because of the > `FileSpecList`. The

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,46 @@ +//===-- Checksum.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] 555a71b - [LLDB] Don't forcefully initialize the process trace plugin (#71455)

2023-11-06 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-11-06T19:45:52-05:00 New Revision: 555a71be457f351411b89c6a6a66aeecf7ca5291 URL: https://github.com/llvm/llvm-project/commit/555a71be457f351411b89c6a6a66aeecf7ca5291 DIFF: https://github.com/llvm/llvm-project/commit/555a71be457f351411b89c6a6a66aeecf7ca5291.di

[Lldb-commits] [lldb] [LLDB] Don't forcefully initialize the process trace plugin (PR #71455)

2023-11-06 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/71455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. the dwarf line tables patch LGTM https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: You pushed a commit from a different PR btw https://github.com/llvm/llvm-project/pull/71457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71457 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -72,7 +75,8 @@ class FileSpec { /// The style of the path /// /// \see FileSpec::SetFile (const char *path) - explicit FileSpec(llvm::StringRef path, Style style = Style::native); + explicit FileSpec(llvm::StringRef path, Style style = Style::native, +

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,46 @@ +//===-- Checksum.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,46 @@ +//===-- Checksum.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,36 @@ +//===-- Checksum.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,46 @@ +//===-- Checksum.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/71456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't forcefully initialize the process trace plugin (PR #71455)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/71455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > If I wanted to add `ScriptedLuaProcessInterface` (as an example), what would > I need to do? In the current state, you'd just need to implement at lease `ScriptedProcessLuaInterface::CreatePluginObject` to construct the object. But after I land #71260, you'll also have t

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. This more closely matches my intuition for how I would expect this inheritance hierarchy to be set up. If I wanted to add `ScriptedLuaProcessInterface` (as an example), what would I need to do? https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public ScriptedInterface { return {llvm::make_error()}; } + llvm::SmallVector GetAbstractMethods() const override { +return {}; + } medismailben wrote: @bulbazord @JDevlieghere Here! ht

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/71465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Med Ismail Bennani (medismailben) Changes This patch makes the various Scripted Interface base class abstract by making the `CreatePluginObject` method pure virtual. This means that we cannot construct a Scripted Interface base class insta

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/71465 This patch makes the various Scripted Interface base class abstract by making the `CreatePluginObject` method pure virtual. This means that we cannot construct a Scripted Interface base class instance, so

[Lldb-commits] [lldb] [LLDB] Don't forcefully initialize the process trace plugin (PR #71455)

2023-11-06 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. There is no LLDB_PLUGIN_DEFINE() macro in ProcessTrace.cpp, so that is why it was being manually initialized. But this plugin in a problem in that if it's ProcessTrace::CreateInstance(...) is called, it will always return a valid Process

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on #71458. This is probably incomplete and obviously needs a test, but I wanted to put up the PR to show what the dependent patches are building towards. https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mai

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Print a warning when the debugger detects a mismatch between the MD5 checksum in the DWARF 5 line table and the file on disk. --- Full diff: https://github.com/llvm/llvm-project/pull/71459.diff 11

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71459 Print a warning when the debugger detects a mismatch between the MD5 checksum in the DWARF 5 line table and the file on disk. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 From: Jon

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Read the MD5 checksum from DWARF line tables and store it in the corresponding support files. --- Full diff: https://github.com/llvm/llvm-project/pull/71458.diff 9 Files Affected: - (added) lldb/i

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on #71457. https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71458 Read the MD5 checksum from DWARF line tables and store it in the corresponding support files. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon, 6 Nov

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Depends on #71456. I considered an alternative where we don't store the `Checksum` in the `FileSpec` but create a new `SupportFile` class that wraps a `Checksum` and a `FileSpec`. The reason I didn't got with this approach is because of the `FileSpecList`. The latter has

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added to the DWARF 5 line table. --- Full diff: https://github.com/llvm/llvm-project/pull/71457.diff 8 Files Affected: - (added)

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71457 Store a Checksum in FileSpec. Its purpose is to store the MD5 hash added to the DWARF 5 line table. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Mon,

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This commit adds an MD5 checksum (`Checksum`) class to LLDB. Its purpose is to store the MD5 hash added to the DWARF 5 line table. --- Full diff: https://github.com/llvm/llvm-project/pull/71456.diff

[Lldb-commits] [lldb] [lldb] Add Checksum class to lldbUtility (PR #71456)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71456 This commit adds an MD5 checksum (`Checksum`) class to LLDB. Its purpose is to store the MD5 hash added to the DWARF 5 line table. >From 5ba3f9d6cd795bc091bacae75b7c51d815138d5b Mon Sep 17 00:00:00 2001 Fro

[Lldb-commits] [lldb] [LLDB] Don't forcefully initialize the process trace plugin (PR #71455)

2023-11-06 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/71455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't forcefully initialize the process trace plugin (PR #71455)

2023-11-06 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/71455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't forcefully initialize the process trace plugin (PR #71455)

2023-11-06 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/71455 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] walter/fix (PR #71455)

2023-11-06 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/71455 >From d877ef80bbaa62afed2c7656c5ff6e84a8628786 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 6 Nov 2023 17:57:45 -0500 Subject: [PATCH] [LLDB] Don't forcefully initialize the process trace p

[Lldb-commits] [lldb] walter/fix (PR #71455)

2023-11-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes - [LLDB][easy] Fix a bug in DummySyntheticFrontEnd - [LLDB] Don't forcefully initialize the process trace plugin --- Full diff: https://github.com/llvm/llvm-project/pull/71455.diff 3 Files Affe

[Lldb-commits] [lldb] walter/fix (PR #71455)

2023-11-06 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/71455 - [LLDB][easy] Fix a bug in DummySyntheticFrontEnd - [LLDB] Don't forcefully initialize the process trace plugin >From 57d19fdd476b293a87f1c14b743ba636350af7a1 Mon Sep 17 00:00:00 2001 From: walter erqu

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. I'm on board https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/71260 >From 4f15a3dfa7fdf600f76e434dc93879de910b317b Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 6 Nov 2023 14:15:12 -0800 Subject: [PATCH] [lldb] Check for abstract methods implementation in Scri

[Lldb-commits] [clang-tools-extra] [clang] [libcxx] [compiler-rt] [llvm] [lldb] [flang] [lld] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-06 Thread Scott Linder via lldb-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const { } StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const { - // TODO: Handle newlines properly. We need to remove leading whitespace. - if (Value[0] == '"') { // Double quoted. -// Pull off the leading and tra

[Lldb-commits] [flang] [lldb] [clang] [llvm] [lld] [clang-tools-extra] [libcxx] [compiler-rt] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-06 Thread Scott Linder via lldb-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const { } StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const { - // TODO: Handle newlines properly. We need to remove leading whitespace. - if (Value[0] == '"') { // Double quoted. -// Pull off the leading and tra

[Lldb-commits] [libcxx] [flang] [compiler-rt] [clang-tools-extra] [lldb] [llvm] [lld] [clang] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-06 Thread Scott Linder via lldb-commits
https://github.com/slinder1 edited https://github.com/llvm/llvm-project/pull/70898 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [clang] [libcxx] [llvm] [flang] [lldb] [compiler-rt] [lld] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-06 Thread Scott Linder via lldb-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const { } StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const { - // TODO: Handle newlines properly. We need to remove leading whitespace. - if (Value[0] == '"') { // Double quoted. -// Pull off the leading and tra

[Lldb-commits] [clang-tools-extra] [llvm] [lld] [compiler-rt] [libcxx] [flang] [lldb] [clang] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-06 Thread Scott Linder via lldb-commits
@@ -2030,187 +2030,219 @@ bool Node::failed() const { } StringRef ScalarNode::getValue(SmallVectorImpl &Storage) const { - // TODO: Handle newlines properly. We need to remove leading whitespace. - if (Value[0] == '"') { // Double quoted. -// Pull off the leading and tra

[Lldb-commits] [clang] [llvm] [clang-tools-extra] [lldb] [flang] [compiler-rt] [libcxx] [lld] [YAMLParser] Unfold multi-line scalar values (PR #70898)

2023-11-06 Thread Scott Linder via lldb-commits
https://github.com/slinder1 requested changes to this pull request. I don't mean to make existing debt your problem, but if it isn't too much work could you post a pre-patch that just adds the `FileCheck`s to the existing tests where the behavior changes, so the test diff is more self-documenti

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public ScriptedInterface { return {llvm::make_error()}; } + llvm::SmallVector GetAbstractMethods() const override { +return {}; + } medismailben wrote: Ok, I'll make the the base class

[Lldb-commits] [llvm] [mlir] [compiler-rt] [lldb] [clang] [libcxxabi] [libcxx] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-11-06 Thread Anton Rydahl via lldb-commits
@@ -330,6 +330,23 @@ def getStdFlag(cfg, std): default=f"{shlex.quote(sys.executable)} {shlex.quote(str(Path(__file__).resolve().parent.parent.parent / 'run.py'))}", help="Custom executor to use instead of the configured default.", actions=lambda execut

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) { return PyDict_Check(py_obj); } +bool PythonDictionary::HasKey(const llvm::Twine &key) const { medismailben wrote: Done! https://github.com/llvm/llvm-project/pull/71260 __

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: FWIW the "plugin-ification" has landed so this should be able to move forward as a plugin. https://github.com/llvm/llvm-project/pull/70996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb] Change Breakpoint::AddName return value (PR #71236)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/71236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change Breakpoint::AddName return value (PR #71236)

2023-11-06 Thread Alex Langford via lldb-commits
bulbazord wrote: @jimingham Does this work for you? https://github.com/llvm/llvm-project/pull/71236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Change parameter type in Target::AddNameToBreakpoint (PR #71241)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71241 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f4df0c4 - [lldb][NFCI] Change parameter type in Target::AddNameToBreakpoint (#71241)

2023-11-06 Thread via lldb-commits
Author: Alex Langford Date: 2023-11-06T12:45:02-08:00 New Revision: f4df0c48e912f01abe2ecaad207b469745620c5d URL: https://github.com/llvm/llvm-project/commit/f4df0c48e912f01abe2ecaad207b469745620c5d DIFF: https://github.com/llvm/llvm-project/commit/f4df0c48e912f01abe2ecaad207b469745620c5d.diff

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -89,12 +89,18 @@ class DynamicRegisterInfo { GetRegisterInfo(llvm::StringRef reg_name) const; typedef std::vector reg_collection; - llvm::iterator_range registers() const { -return llvm::iterator_range(m_regs); + + template T registers(); bulbazo

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Works for me. https://github.com/llvm/llvm-project/pull/71402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-06 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,77 @@ +//===-- RegisterFlagsLinux_arm64.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -67,6 +70,21 @@ RegisterContextCorePOSIX_arm64::RegisterContextCorePOSIX_arm64( : RegisterContextPOSIX_arm64(thread, std::move(register_info)) { ::memset(&m_sme_pseudo_regs, 0, sizeof(m_sme_pseudo_regs)); + ProcessElfCore *process = + static_cast(thread.GetProc

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-06 Thread Alex Langford via lldb-commits
@@ -0,0 +1,102 @@ +//===-- RegisterFlagsLinux_arm64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [clang] [lldb] [mlir] [compiler-rt] [llvm] [clang-tools-extra] [flang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-11-06 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Ping. https://github.com/llvm/llvm-project/pull/69493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] TestVTableValue.py: skip test for older versions of clang (PR #71372)

2023-11-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/71372 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 876bd79 - [lldb][test] TestVTableValue.py: skip test for older versions of clang (#71372)

2023-11-06 Thread via lldb-commits
Author: Michael Buch Date: 2023-11-06T19:15:39Z New Revision: 876bd794fc33c74fc8689015699b9fec06dd0580 URL: https://github.com/llvm/llvm-project/commit/876bd794fc33c74fc8689015699b9fec06dd0580 DIFF: https://github.com/llvm/llvm-project/commit/876bd794fc33c74fc8689015699b9fec06dd0580.diff LOG:

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

2023-11-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > These asserts are testing that the static representation of register contexts > is ok and building and testing with asserts enabled should flush out any > issues. `lldbassert()` is perfect for this since it is enabled for debug > builds while testing happens. The [contri

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > Is there any way we could avoid ever having to instantiate a > `Scripted{.*}Interface`? @JDevlieghere I actually suggested something here https://github.com/llvm/llvm-project/pull/71260#discussion_r1383748012 https://github.com/llvm/llvm-project/pull/71260 __

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -99,25 +135,87 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { } llvm::Expected expected_return_object = - llvm::createStringError(llvm::inconvertibleErrorCode(), - "Resulting object is not initial

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-06 Thread Med Ismail Bennani via lldb-commits
@@ -32,27 +32,66 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter); ~ScriptedPythonInterface() override = default; + enum class AbstractMethodCheckerCases { +eNotImplemented, +e

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

2023-11-06 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. These asserts are testing that the static representation of register contexts is ok and building and testing with asserts enabled should flush out any issues. `lldbassert()` is perfect for this since it is enabled for debug builds while t

  1   2   >