[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given support for other languages like Rust and D, I think this is reasonable. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

2023-08-21 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, augusto2112, kastiglione, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Apple maintains a d

[Lldb-commits] [PATCH] D158457: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

2023-08-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158457/new/ https://reviews.llvm.org/D158457 ___

[Lldb-commits] [PATCH] D158467: [lldb] Link back to the LLVM Project and Developer Policy from the docs

2023-08-21 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, tonic. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Add backlinks to the LLVM Project and the LLVM Developer Policy from the docs. As suggested by Tanya in

[Lldb-commits] [PATCH] D158457: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

2023-08-21 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, DavidSpickett, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's no reason for GetSignalInfo to return the

[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

2023-08-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG446abb5125f7: [lldb/crashlog] Fix python version requirement issue (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158452/new/ https://revi

[Lldb-commits] [lldb] 446abb5 - [lldb/crashlog] Fix python version requirement issue

2023-08-21 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-08-21T21:52:44+01:00 New Revision: 446abb5125f76423232e5d4d3ed116cccfbd8b99 URL: https://github.com/llvm/llvm-project/commit/446abb5125f76423232e5d4d3ed116cccfbd8b99 DIFF: https://github.com/llvm/llvm-project/commit/446abb5125f76423232e5d4d3ed116cccfbd8b99.

[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

2023-08-21 Thread Alex Langford via Phabricator via lldb-commits
bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Unfortunate but it makes the most sense for now. Thanks for fixing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158452/new/ https:/

[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

2023-08-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added reviewers: JDevlieghere, kastiglione, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. In 21a597c

[Lldb-commits] [PATCH] D158209: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

2023-08-21 Thread Alex Langford via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG58fe7b751dc4: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [lldb] 58fe7b7 - [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

2023-08-21 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2023-08-21T12:44:17-07:00 New Revision: 58fe7b751dc4a611a013a7708c1c0cac159b5f1e URL: https://github.com/llvm/llvm-project/commit/58fe7b751dc4a611a013a7708c1c0cac159b5f1e DIFF: https://github.com/llvm/llvm-project/commit/58fe7b751dc4a611a013a7708c1c0cac159b5f1e.diff

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-21 Thread Lily Orth-Smith via Phabricator via lldb-commits
electriclilies added a comment. @jingham Any other changes I should make? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/D158010 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. I was going to wait for some Mac specific reviewer too but it's simple and the Green Dragon bots should verify it well enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158391/new/ https://reviews.llvm.org/D15839

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7549cde6bd52: [lldb][debugserver] Fix build after libcxx removed generic char_traits… (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 7549cde - [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-08-21T07:50:03Z New Revision: 7549cde6bd5243570da8480c8580674a30024a71 URL: https://github.com/llvm/llvm-project/commit/7549cde6bd5243570da8480c8580674a30024a71 DIFF: https://github.com/llvm/llvm-project/commit/7549cde6bd5243570da8480c8580674a30024a71.diff LOG

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158391/new/ https://reviews.llvm.org/D158391 ___

[Lldb-commits] [PATCH] D158391: [lldb][debugserver] Fix build after libcxx removed generic char_traits implementation

2023-08-21 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Which was done in https://reviews.llvm.org/D157058. This follows the fix for lldb-server in https://reviews.llvm