[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

[Med Ismail Bennani via Phabricator via lldb-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG446abb5125f7: [lldb/crashlog] Fix python version requirement 
issue (authored by mib).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158452/new/

https://reviews.llvm.org/D158452

Files:
  lldb/examples/python/crashlog.py


Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -1603,14 +1603,29 @@
         help="pause for NSEC seconds for debugger",
         default=0,
     )
+    # NOTE: Requires python 3.9
+    # arg_parser.add_argument(
+    #     "--crashed-only",
+    #     "-c",
+    #     action=argparse.BooleanOptionalAction,
+    #     dest="crashed_only",
+    #     help="only symbolicate the crashed thread",
+    #     default=True,
+    # )
     arg_parser.add_argument(
         "--crashed-only",
         "-c",
-        action=argparse.BooleanOptionalAction,
+        action="store_true",
         dest="crashed_only",
         help="only symbolicate the crashed thread",
         default=True,
     )
+    arg_parser.add_argument(
+        "--no-crashed-only",
+        action="store_false",
+        dest="crashed_only",
+        help="do not symbolicate the crashed thread",
+    )
     arg_parser.add_argument(
         "--disasm-depth",
         "-d",



Index: lldb/examples/python/crashlog.py
===================================================================
--- lldb/examples/python/crashlog.py
+++ lldb/examples/python/crashlog.py
@@ -1603,14 +1603,29 @@
         help="pause for NSEC seconds for debugger",
         default=0,
     )
+    # NOTE: Requires python 3.9
+    # arg_parser.add_argument(
+    #     "--crashed-only",
+    #     "-c",
+    #     action=argparse.BooleanOptionalAction,
+    #     dest="crashed_only",
+    #     help="only symbolicate the crashed thread",
+    #     default=True,
+    # )
     arg_parser.add_argument(
         "--crashed-only",
         "-c",
-        action=argparse.BooleanOptionalAction,
+        action="store_true",
         dest="crashed_only",
         help="only symbolicate the crashed thread",
         default=True,
     )
+    arg_parser.add_argument(
+        "--no-crashed-only",
+        action="store_false",
+        dest="crashed_only",
+        help="do not symbolicate the crashed thread",
+    )
     arg_parser.add_argument(
         "--disasm-depth",
         "-d",

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits