[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

jasonmolenda updated this revision to Diff 550148. jasonmolenda added a comment. Incorporate Jonas' suggestion of a AddressableBits class that GDBRemoteCommunicationClient and ObjectFileMachO could use to store the zero/one/two addressable bits values back to a Process, and centralizing the log

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

clayborg added a comment. We are also looking for a way to locate .dwo files at Meta. One idea we came up with is to add a setting that can be set: (lldb) settings set symbols.locate-dwo-script /path/to/locate-dwo.py Any specified scripts would be expect to contain a python function: def l

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:1737 + if (!dwo_file.IsRelative()) { +found = FileSystem::Instance().Exists(dwo_file); + } else { Maybe we can also check the debug info search paths to see

[Lldb-commits] [PATCH] D157662: [lldb][NFCI] Change parameter type in Process::SetExitStatus

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a25f97e6950: [lldb][NFCI] Change parameter type in Process::SetExitStatus (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157662/new/

[Lldb-commits] [lldb] 5a25f97 - [lldb][NFCI] Change parameter type in Process::SetExitStatus

Author: Alex Langford Date: 2023-08-14T15:49:03-07:00 New Revision: 5a25f97e69500d4f65ce0e56027787752c7aab61 URL: https://github.com/llvm/llvm-project/commit/5a25f97e69500d4f65ce0e56027787752c7aab61 DIFF: https://github.com/llvm/llvm-project/commit/5a25f97e69500d4f65ce0e56027787752c7aab61.diff

[Lldb-commits] [PATCH] D157122: [lldb] Remove support for SBHostOS threading functionality

bulbazord abandoned this revision. bulbazord added a comment. Landed as 69fdbdc4493aacf4d418a063930b39b02b5e18c5 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157122/new/ https

[Lldb-commits] [lldb] 69fdbdc - [lldb] Remove support for SBHostOS threading functionality

Author: Alex Langford Date: 2023-08-14T14:33:08-07:00 New Revision: 69fdbdc4493aacf4d418a063930b39b02b5e18c5 URL: https://github.com/llvm/llvm-project/commit/69fdbdc4493aacf4d418a063930b39b02b5e18c5 DIFF: https://github.com/llvm/llvm-project/commit/69fdbdc4493aacf4d418a063930b39b02b5e18c5.diff

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

augusto2112 added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:86-89 + lldb_private::Connection *GetConnection() { +std::shared_lock guard(m_connection_mutex); +return m_connection_sp.get(); + } bulbazord wrote: > This isn't neces

[Lldb-commits] [PATCH] D157756: Support corefiles that put the uuid of their binary in a fixed address in low memory; load that binary

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157756/new/ https://reviews.llvm.org/D157756 _

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

This revision was automatically updated to reflect the committed changes. Closed by commit rGe634c2f71493: [lldb] Remove use of __future__ in python (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157759/new/ https://reviews.l

[Lldb-commits] [lldb] e634c2f - [lldb] Remove use of __future__ in python

Author: Alex Langford Date: 2023-08-14T14:14:48-07:00 New Revision: e634c2f7149392b62e93c1b2b75701a12bc06721 URL: https://github.com/llvm/llvm-project/commit/e634c2f7149392b62e93c1b2b75701a12bc06721 DIFF: https://github.com/llvm/llvm-project/commit/e634c2f7149392b62e93c1b2b75701a12bc06721.diff

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

JDevlieghere accepted this revision. JDevlieghere added a comment. In D157759#4581673 , @mib wrote: > LGTM! Although we should make sure no one is still using Python 2 downstream Python 2 has been deprecated for a while and we've removed other stuff that

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:172-174 std::mutex m_write_mutex; ///< Don't let multiple threads write at the same time... + mutable std::shared_mutex m_connection_mutex; Why do we need both? Can'

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

bulbazord added a comment. In D157497#4586165 , @MaskRay wrote: > In D157497#4584621 , @Pivnoy wrote: > >> This discussion was the main motivation for this change. >> https://discourse.llvm.org/t/rfc-refactor-trip

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:125-126 - lldb::addr_t GetAddressMask() override; + bool GetAddressMask(lldb::addr_t &lowmem_mask, + lldb::addr_t &highmem_mask) override; --

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

MaskRay added a comment. In D157497#4584621 , @Pivnoy wrote: > This discussion was the main motivation for this change. > https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 > As a result, Triple should become a data class, and its d

[Lldb-commits] [PATCH] D157849: [lldb/crashlog] Replace deprecated optparse by argparse (NFC)

bulbazord added a comment. Makes sense to me. `optparse` has been deprecated since Python 3.2 in favor of `argparse`. It's good to get ahead of the curve here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157849/new/ https://reviews.llvm.org/D157

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:86-89 + lldb_private::Connection *GetConnection() { +std::shared_lock guard(m_connection_mutex); +return m_connection_sp.get(); + } This isn't necessarily introduced by

[Lldb-commits] [PATCH] D157512: [lldb][PlatformDarwin] Only parse SDK from debug-info if target language is Objective-C

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Apart from Jim's comment (does this still work?) this seems like a reasonable heuristic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157512/

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett added a comment. I realise this is a giant patch, so if you see a way to split it, great. However, SVG is read from the ZA header and we need SVG to implement the resizing of ZA. So at least those are tied to each other. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett updated this revision to Diff 549951. DavidSpickett added a comment. Rebase and reimplement this on top of ZA/SVG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. The "Matrix" part of the Scalable Matrix Extensi

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

Pivnoy added a comment. This discussion was the main motivation for this change. https://discourse.llvm.org/t/rfc-refactor-triple-related-classes/70410/11 As a result, Triple should become a data class, and its dependencies such as Architecture, Operating System etc. represent in the form of inte

[Lldb-commits] [PATCH] D157609: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett added reviewers: aprantl, clayborg, lenary. DavidSpickett added a subscriber: lenary. DavidSpickett added a comment. https://github.com/llvm/llvm-project/issues/28667 is the github issue. @lenary This fixes your reproducer, if you have any more ways to confuse lldb please try them

[Lldb-commits] [PATCH] D157609: WIP: [lldb] Search debug file paths when looking for split DWARF files

DavidSpickett updated this revision to Diff 549872. DavidSpickett added a comment. Cleanup, add testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 Files: lldb/source/Plugins/SymbolFile/DWARF/Symbo

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

mib added a comment. In D157043#4582385 , @JDevlieghere wrote: > Test? I'll do it in a follow-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157043/new/ https://reviews.llvm.org/D157043 _

[Lldb-commits] [PATCH] D157852: [lldb/crashlog] Skip non-crashed threads in batch mode

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. When using the `crashlog` command in batch mode, most users only care about the crashed t

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support to the "Last Exception Backtrace" to the `crashlog` command. Thi

[Lldb-commits] [PATCH] D157850: [lldb/crashlog] Fix module loading for crashed thread behaviour

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. Before 27f27d15f , the `cras

[Lldb-commits] [PATCH] D157849: [lldb/crashlog] Replace deprecated optparse by argparse (NFC)

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added subscribers: lldb-commits, wangpc. This patch replace the deprecated `optparse` module used for the `crashlog`& `save

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

asb added a comment. Is there some separate discussion thread or proposal about this refactoring and its motivations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157497/new/ https://reviews.llvm.org/D157497 _

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since we need to switch modes, this is its own test. I will b

[Lldb-commits] [PATCH] D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This always succeeds. While I'm here, document why we check the size o

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 549836. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156687/new/ https://reviews.llvm.org/D156687 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLi

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett updated this revision to Diff 549835. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157488/new/ https://reviews.llvm.org/D157488 Files: lldb/test/API/commands/register/register/aarch64_mte_ctrl

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett updated this revision to Diff 549834. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157000/new/ https://reviews.llvm.org/D157000 Files: lldb/test/API/commands/register/register/aarch64_sve_sim