bulbazord added inline comments.
================
Comment at: lldb/include/lldb/Core/Communication.h:86-89
+ lldb_private::Connection *GetConnection() {
+ std::shared_lock guard(m_connection_mutex);
+ return m_connection_sp.get();
+ }
----------------
This isn't necessarily introduced by your patch, but I don't think this lock
does much other than make sure nobody can change `m_connection_sp` in between
you calling `GetConnection` and you actually receiving the `Connection`
pointer. It still comes with all the pitfalls of handing out a raw pointer
(instead of a `shared_ptr`).
As a follow-up or maybe even precursor, we should probably stop handing out the
raw connection pointer...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157760/new/
https://reviews.llvm.org/D157760
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
