JDevlieghere updated this revision to Diff 546694.
JDevlieghere added a comment.
Add Discourse and Discord usernames.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
Files:
lldb/CODE_OWNERS.txt
lldb/CodeOwners.rst
Index: lldb/CodeOwners.r
RamNalamothu marked 3 inline comments as done.
RamNalamothu added a comment.
Thanks for the comments @MaskRay.
Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:23
+
+class TestMCDisasmInstanceRISCV : public testing::Test {
+public:
Ma
RamNalamothu updated this revision to Diff 546688.
RamNalamothu added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156086/new/
https://reviews.llvm.org/D156086
Files:
lldb/source/Plugins/Disassembler/LLVMC/Di
tonic added a comment.
Since you are going to the effort of changing the CodeOwners file format from
what is in LLVM, can you go ahead and add Discourse and Discord handles? It is
often very helpful to tag someone on Discourse/Discord. I'll be proposing this
change for LLVM soon.
CHANGES SIN
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation. LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155905/new/
https://reviews.llvm.org/D155905
___
clayborg added a comment.
Sorry this fell off my radar. I was on medical leave for a surgery for 3
months. Back now
Comment at: lldb/tools/lldb-vscode/Watchpoint.cpp:72
+ m_verified = true;
+ m_error = "";
+}
Comment at: lldb/tools/lldb-v
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156949/new/
https://reviews.llvm.org/D156949
___
lldb-commits mailing list
lldb-commits@list
JDevlieghere added a comment.
Added the bot owners as reviewers for visibility.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156804/new/
https://reviews.llvm.org/D156804
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
JDevlieghere created this revision.
JDevlieghere added reviewers: jasonmolenda, DavidSpickett, jingham, bulbazord,
Michael137, clayborg, mib, labath, wallace, compnerd, aprantl, zequanwu,
emaste, omjavaid.
Herald added a subscriber: yaxunl.
Herald added a project: All.
JDevlieghere requested revi
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5f45a87bf029: [lldb] Print hint if object description is
requested but not implemented (authored by augusto2112).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
Author: Augusto Noronha
Date: 2023-08-02T15:33:32-07:00
New Revision: 5f45a87bf029cc4b9815f5f819906198b07e00d1
URL:
https://github.com/llvm/llvm-project/commit/5f45a87bf029cc4b9815f5f819906198b07e00d1
DIFF:
https://github.com/llvm/llvm-project/commit/5f45a87bf029cc4b9815f5f819906198b07e00d1.dif
MaskRay added inline comments.
Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:23
+
+class TestMCDisasmInstanceRISCV : public testing::Test {
+public:
Place all classes and test methods in an anonymous namespace.
Com
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156919/new/
https://reviews.llvm.org/D156919
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rG61af957aeaa3: [lldb] Make IR interpretation interruptible
(authored by JDevlieghere).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D156822?vs=546174&id=546600#toc
Rep
Author: Jonas Devlieghere
Date: 2023-08-02T13:56:24-07:00
New Revision: 61af957aeaa3ba69a64598966525af6a40280fa0
URL:
https://github.com/llvm/llvm-project/commit/61af957aeaa3ba69a64598966525af6a40280fa0
DIFF:
https://github.com/llvm/llvm-project/commit/61af957aeaa3ba69a64598966525af6a40280fa0.d
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D156934
F
jingham added a comment.
LGTM. Thanks for adding this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156822/new/
https://reviews.llvm.org/D156822
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
mib marked 2 inline comments as done.
mib added inline comments.
Comment at: lldb/examples/python/crashlog.py:104
+registers_info = None
+if self.arch:
+if "x86_64" == self.arch:
bulbazord wrote:
> Is there a reason to do a
bulbazord added a comment.
In general looks good to me. I have one suggestion and one question.
Comment at: lldb/examples/python/crashlog.py:104
+registers_info = None
+if self.arch:
+if "x86_64" == self.arch:
Is there a
mib created this revision.
mib added reviewers: bulbazord, JDevlieghere.
mib added a project: LLDB.
Herald added a project: All.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch changes the way we dump the registers from the legacy
crashlog command to make
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6c2e3249160f: [lldb] Re-add compile-time checks for SPI in
HosInfoMacOSX (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156838/new/
Author: Alex Langford
Date: 2023-08-02T10:21:54-07:00
New Revision: 6c2e3249160f5b68f6e09fed0435ee043659f2d9
URL:
https://github.com/llvm/llvm-project/commit/6c2e3249160f5b68f6e09fed0435ee043659f2d9
DIFF:
https://github.com/llvm/llvm-project/commit/6c2e3249160f5b68f6e09fed0435ee043659f2d9.diff
ashgti added a comment.
Do you have any additional information about the failure? The link looks like a
timeout, so I'm not sure where things are timing out.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156493/new/
https://reviews.llvm.org/D15649
DavidSpickett added a comment.
Also it would be very useful if the logs could be printed in a pretty form like:
>>> from pprint import pprint
>>> pprint(j)
{u'body': {u'instructions': [{u'address': u'0x400584',
u'column': 9,
u'
wallace added a comment.
Greg hasn't been working for a while. You can go ahead and land this, and when
he gets back he can share some feedback.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140630/new/
https://reviews.llvm.org/D140630
__
DavidSpickett added a comment.
I've marked one of these tests skipped on Arm because it's failing on our bot:
https://github.com/llvm/llvm-project/commit/54458c525aa47219a3ef2bee2be33d6096b1585c
This is a 32 Arm machine, so unless you've got ready access to one, we'll
figure out what the proble
Author: David Spickett
Date: 2023-08-02T14:36:24Z
New Revision: 54458c525aa47219a3ef2bee2be33d6096b1585c
URL:
https://github.com/llvm/llvm-project/commit/54458c525aa47219a3ef2bee2be33d6096b1585c
DIFF:
https://github.com/llvm/llvm-project/commit/54458c525aa47219a3ef2bee2be33d6096b1585c.diff
LOG
cimacmillan added a comment.
Ping
@clayborg would you mind having another look? Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140630/new/
https://reviews.llvm.org/D140630
___
lldb-commits mailing
Michael137 added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040
+case DW_TAG_enumeration_type:
+{
Endill wrote:
> Michael137 wrote:
> > Michael137 wrote:
> > > Michael137 wrote:
> > > > Michael137 wrote:
>
Endill added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040
+case DW_TAG_enumeration_type:
+{
Michael137 wrote:
> Michael137 wrote:
> > Michael137 wrote:
> > > Michael137 wrote:
> > > > At first glance thi
Michael137 added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040
+case DW_TAG_enumeration_type:
+{
Michael137 wrote:
> Michael137 wrote:
> > Michael137 wrote:
> > > At first glance this seems OK but I'll wa
Michael137 added a comment.
Could you update the commit message with a description of the failure and
summary of the fix? And change the title to something like
`[lldb][DWARFASTParserClang] Resolve nested types when parsing structures`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
Michael137 added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040
+case DW_TAG_enumeration_type:
+{
Michael137 wrote:
> Michael137 wrote:
> > At first glance this seems OK but I'll want to check why the type
DavidSpickett added inline comments.
Comment at: lldb/source/Host/windows/FileSystem.cpp:104
return -1;
+ mode = mode & (_S_IREAD | _S_IWRITE); // All other bits are rejected by
_wsopen_s
int result;
Nitpick: comments are usually on the line before.
R
DavidSpickett added a comment.
Also please put `[lldb][Windows]` at the start of the commit title.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156817/new/
https://reviews.llvm.org/D156817
___
lldb-comm
DavidSpickett added a comment.
I just commented on the issue, thanks for the fix!
What exactly are the other bits in the mode here, are we losing something
important potentially? I guess it can't be that important if Windows rejects
them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
36 matches
Mail list logo
