MaskRay added inline comments.
================
Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:23
+
+class TestMCDisasmInstanceRISCV : public testing::Test {
+public:
----------------
Place all classes and test methods in an anonymous namespace.
================
Comment at: lldb/unittests/Disassembler/RISCV/TestMCDisasmInstanceRISCV.cpp:64
+ // and we should skip these tests without marking anything as failing.
+ if (disass_sp) {
+ const InstructionList inst_list (disass_sp->GetInstructionList());
----------------
Early return
================
Comment at: llvm/include/llvm/MC/MCInstrAnalysis.h:76
+ return false;
+ if (Info->get(Inst.getOpcode()).hasDefOfPhysReg(Inst, PC, MCRI))
+ return true;
----------------
`return Info->get(Inst.getOpcode()).hasDefOfPhysReg(Inst, PC, MCRI)`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156086/new/
https://reviews.llvm.org/D156086
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
