[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546306. RamNalamothu added a comment. Remove left overs of copy-paste. Apologies for so many updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: ll

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546297. RamNalamothu added a comment. Oops. Didn't notice the changed formatting of the comment after git-clang-format. Fixed the format issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ h

[Lldb-commits] [PATCH] D156838: [lldb] Re-add compile-time checks for SPI in HosInfoMacOSX

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, I missed that I removed the check when we were trying to clean up old pre-macOS 10.12 ifdef's. LGTM thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D156838: [lldb] Re-add compile-time checks for SPI in HosInfoMacOSX

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There were some checks removed previously in bc1969

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

augusto2112 updated this revision to Diff 546275. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153489/new/ https://reviews.llvm.org/D153489 Files: lldb/include/lldb/Core/Debugger.h lldb/source/C

[Lldb-commits] [PATCH] D156817: _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156817/new/ https://reviews.llvm.org/D156817 __

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce7831b4023: [lldb][test] Skip *-dbg-info-content API tests (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156827/new/ https://rev

[Lldb-commits] [lldb] 5ce7831 - [lldb][test] Skip *-dbg-info-content API tests

Author: Michael Buch Date: 2023-08-01T23:43:24+02:00 New Revision: 5ce7831b402334a13b00c1441655a51fbec7456a URL: https://github.com/llvm/llvm-project/commit/5ce7831b402334a13b00c1441655a51fbec7456a DIFF: https://github.com/llvm/llvm-project/commit/5ce7831b402334a13b00c1441655a51fbec7456a.diff

[Lldb-commits] [PATCH] D156822: [lldb] Make IR interpretation interruptible

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156822/new/ https://reviews.llvm.org/D156822 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

Michael137 updated this revision to Diff 546226. Michael137 added a comment. - Amend commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156827/new/ https://reviews.llvm.org/D156827 Files: lldb/test/API/commands/expression/import-std-m

[Lldb-commits] [PATCH] D156827: [lldb][test] Skip *-dbg-info-content API tests

Michael137 created this revision. Michael137 added reviewers: aprantl, iana, JDevlieghere. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests started failing on the public build-bots recently

[Lldb-commits] [PATCH] D156564: [lldb] Fix test TestBSDArchives.py properly

This revision was automatically updated to reflect the committed changes. Closed by commit rGca76281917d0: [lldb] Fix test TestBSDArchives.py properly (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] ca76281 - [lldb] Fix test TestBSDArchives.py properly

Author: Wanyi Ye Date: 2023-08-01T16:38:58-04:00 New Revision: ca76281917d0d5aa40472d237584fd983a19d246 URL: https://github.com/llvm/llvm-project/commit/ca76281917d0d5aa40472d237584fd983a19d246 DIFF: https://github.com/llvm/llvm-project/commit/ca76281917d0d5aa40472d237584fd983a19d246.diff LOG:

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

clayborg added a comment. You can copy this folder to a new test folder and adjust the test to verify: lldb/test/API/tools/lldb-vscode/stackTrace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156732/new/ https://reviews.llvm.org/D156732 ___

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Adding a test case for this is a good idea. In order to get the PC somewhere bad, you can probably make a function pointer that points to data, then try to branch there. The PC w

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546177. RamNalamothu added a comment. Fix RISC-V test name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: lldb/source/Plugins/Disassembler/LLVMC/Disas

[Lldb-commits] [PATCH] D156822: [lldb] Make IR interpretation interruptible

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, Michael137, teemperor. Herald added a project: All. JDevlieghere requested review of this revision. Check the interrupt flag while interpreting IR expressions and allow the user to interrupt them. https://reviews.llvm.or

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 546173. RamNalamothu added a comment. Herald added subscribers: luke, frasercrmck, sameer.abuasal, Jim, jocewei, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, johnrusso, rbar. Added RISC-V specific test whic

[Lldb-commits] [PATCH] D102762: [lldb] Use a time-based timeout instead of a hardcoded instruction count in the IRInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG59237bb52c94: [lldb] Use a time-based timeout in IRInterpreter (authored by JDevlieghere). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] 59237bb - [lldb] Use a time-based timeout in IRInterpreter

Author: Jonas Devlieghere Date: 2023-08-01T10:50:49-07:00 New Revision: 59237bb52c9483fce395428bfab5996eabe54ed0 URL: https://github.com/llvm/llvm-project/commit/59237bb52c9483fce395428bfab5996eabe54ed0 DIFF: https://github.com/llvm/llvm-project/commit/59237bb52c9483fce395428bfab5996eabe54ed0.d

[Lldb-commits] [PATCH] D156817: _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

yshui created this revision. Herald added a project: All. yshui requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When sending file from a Linux host to a Windows remote, Linux host will try to copy the source file's permission bits, which w

[Lldb-commits] [PATCH] D156764: [lldb][NFCI] More forward declarations in SBDefines.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8aba26c82f2: [lldb][NFCI] More forward declarations in SBDefines.h (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156764/new/ https

[Lldb-commits] [lldb] b8aba26 - [lldb][NFCI] More forward declarations in SBDefines.h

Author: Alex Langford Date: 2023-08-01T09:57:07-07:00 New Revision: b8aba26c82f270a3bdbc85e2c886e8446f0d6820 URL: https://github.com/llvm/llvm-project/commit/b8aba26c82f270a3bdbc85e2c886e8446f0d6820 DIFF: https://github.com/llvm/llvm-project/commit/b8aba26c82f270a3bdbc85e2c886e8446f0d6820.diff

[Lldb-commits] [PATCH] D156763: [lldb] Fix building LLDB standlone without framework

This revision was automatically updated to reflect the committed changes. Closed by commit rG6888de118707: [lldb] Fix building LLDB standlone without framework (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156763/new/ https:

[Lldb-commits] [lldb] 6888de1 - [lldb] Fix building LLDB standlone without framework

Author: Alex Langford Date: 2023-08-01T09:50:36-07:00 New Revision: 6888de118707e6392b46073fc35738804f9f1d80 URL: https://github.com/llvm/llvm-project/commit/6888de118707e6392b46073fc35738804f9f1d80 DIFF: https://github.com/llvm/llvm-project/commit/6888de118707e6392b46073fc35738804f9f1d80.diff

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere updated this revision to Diff 546093. JDevlieghere added a comment. Remove check for SWIG 3.0.9-3.0.10 in `python.swig`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 Files: lldb/bindings/python/python.swig lldb/cmake/module

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

yinghuitan added a comment. Can you add a testcase for this? Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:768 +// hex string. +frame_name.clear(); +llvm::raw_string_ostream os(frame_name); I do not think this is needed? Comme

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

bulbazord added a comment. `python.swig` has a few checks for SWIG versions 3.0.9 and 3.0.10, those can be removed as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. SWIG 4 was released in 2019 and has been the de-facto standard for a while now. All bots are at least running SWIG 4. Hans found out that after 66

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted added a comment. In D155117#4521393 , @labath wrote: > In D155117#4510512 , @ted wrote: > >> In D155117#4505538 , @labath wrote: >> >>> I am wondering if we actually n

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

ted added a comment. In D155107#4534020 , @clayborg wrote: > So Ted, can you verify that nothing is missing in RISCV since this is already > the way it works for x86/x86_64 and arm32/arm64? I am thinking like Jason is > where I wonder if something isn't

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 546064. azhan92 added a comment. Check if file is directory before opening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: clang/lib/AST/Interp/Floating.h

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 546053. azhan92 added a comment. Check if directory before opening file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: llvm/lib/Support/Unix/Path.inc Ind

[Lldb-commits] [PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 546051. azhan92 added a comment. Herald added a reviewer: jhenderson. Check if directory before opening as a file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Fil

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW_TAG_enumeration_type: +{ Michael137 wrote: > At first glance this seems OK but I'll want to check why the type doesn't get > resolv

[Lldb-commits] [PATCH] D156774: [lldb] Parse enums while parsing a type

Michael137 added a comment. Thanks for addressing this. Can you add a test? Possibly in `lldb/test/API/lang/cpp/enum_types/`. Or `lldb/test/API/lang/cpp/const_static_integral_member/` Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3040 +case DW