[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

dblaikie added a comment. Filed https://github.com/llvm/llvm-project/issues/64093 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154907/new/ https://reviews.llvm.org/D154907 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D154907: [LLDB] Fix buffer overflow problem in DWARFExpression::Evaluate (2nd attempt)

dblaikie added a subscriber: jmorse. dblaikie added a comment. Simple clang example that produces this invalid DWARF: void b(double); void c(); void e(double e) { c(); b(e); } $ clang-tot x.ii -g -c -o - -O3 | llvm-dwarfdump-tot - | grep DW_OP_deref_size

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu added a comment. In D156086#4529791 , @jasonmolenda wrote: > I'm not super familiar with the MCInst class from llvm, and hadn't heard of > MCInstrAnalysis. I was looking through the llvm targets - are these > MCInstrAnalysis primitives go

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

jasonmolenda added a comment. I'm not super familiar with the MCInst class from llvm, and hadn't heard of MCInstrAnalysis. I was looking through the llvm targets - are these MCInstrAnalysis primitives going to be implemented for all targets we support today? I see them defined for e.g. MIPS a

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + aprantl wrote: > These flags really only make sense in the context of an XcodeSDK, so why not > just return

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

aprantl added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + These flags really only make sense in the context of an XcodeSDK, so why not just return an XcodeSDK or XcodeSD

[Lldb-commits] [PATCH] D155653: [lldb][NFCI] Add some missing SB class forward declarations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5876eee1ff92: [lldb][NFCI] Add some missing SB class forward declarations (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] 5876eee - [lldb][NFCI] Add some missing SB class forward declarations

Author: Alex Langford Date: 2023-07-24T10:33:30-07:00 New Revision: 5876eee1ff9278662aab219023f7466406ff4dfc URL: https://github.com/llvm/llvm-project/commit/5876eee1ff9278662aab219023f7466406ff4dfc DIFF: https://github.com/llvm/llvm-project/commit/5876eee1ff9278662aab219023f7466406ff4dfc.diff

[Lldb-commits] [PATCH] D155653: [lldb][NFCI] Add some missing SB class forward declarations

bulbazord updated this revision to Diff 543631. bulbazord added a comment. Rebase onto main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155653/new/ https://reviews.llvm.org/D155653 Files: lldb/include/lldb/API/SBDefines.h Index: lldb/include

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

DavidSpickett updated this revision to Diff 543587. DavidSpickett added a comment. Lower stack limit when making corefile to shrink it some. 16k was about as low as I could go before it failed to even get to the program itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] cf2f433 - [lldb] Remove Windows XFAIL for TestDollarInVariable.py

Author: David Spickett Date: 2023-07-24T13:25:34Z New Revision: cf2f4334582b55d42a74ca61c8feafa6a85e80f4 URL: https://github.com/llvm/llvm-project/commit/cf2f4334582b55d42a74ca61c8feafa6a85e80f4 DIFF: https://github.com/llvm/llvm-project/commit/cf2f4334582b55d42a74ca61c8feafa6a85e80f4.diff LOG

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. I wanted to add tpidr to the release notes and realised I left it half finished. Will update the release notes afterwards on branch or main depending on when this lands. Repository

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added subscribers: lldb-commits, alextsao1999. Herald added a project: LLDB. 7e229217f4215b519b886e7881bae4da3742a7d2

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu marked an inline comment as done. RamNalamothu added inline comments. Comment at: llvm/include/llvm/MC/MCInstrAnalysis.h:80 + } + /// Returns true if at least one of the register writes performed by DavidSpickett wrote: > Does this have test cove

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

DavidSpickett added a comment. What I understand is that `MCInstrAnalysis` defaults to using `MCInstrDesc`, however not all targets have `MCInstrAnalysis` at all. So we have this awkwardness here with the two pointers, which is fine. Sounds good to me, I am just wondering about the changes over

[Lldb-commits] [PATCH] D155256: [lldb][x86_64] Add fs_base/gs_base support for Linux

DavidSpickett added a comment. If you feel it's significant enough, it is worth adding a release note in `llvm/docs/ReleaseNotes.rst` before/on to the llvm 17 branch is taken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155256/new/ https://revie

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

DavidSpickett added a comment. I will land this and the next patch once the 17 branch has been taken. I don't want SME changes on 17 with A: not enough testing and B: missing features (ZA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154926/new/

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 543406. RamNalamothu added a comment. Refer to the commit which added symbolize operands feature in llvm-objdump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu created this revision. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, arichardson. Herald added a project: All. RamNalamothu requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, wangpc. Herald added projects: LLDB, LLVM. Since th