[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470261 , @ChuanqiXu wrote: >> That is clearly a big motivation - I will ask the folks we were talking to >> at WG21 if that is their priority - or maybe they care about language >> isolation etc. > > Yeah, I know the f

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. > That is clearly a big motivation - I will ask the folks we were talking to at > WG21 if that is their priority - or maybe they care about language isolation > etc. Yeah, I know the folks in WG21 prefer the language isolation. But you know, there are many folks who

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a579db32a7a: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1543

[Lldb-commits] [lldb] 2a579db - [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

Author: Haojian Wu Date: 2023-07-04T08:52:45+02:00 New Revision: 2a579db32a7a0a5f10ddd989eb4cb14974c17c26 URL: https://github.com/llvm/llvm-project/commit/2a579db32a7a0a5f10ddd989eb4cb14974c17c26 DIFF: https://github.com/llvm/llvm-project/commit/2a579db32a7a0a5f10ddd989eb4cb14974c17c26.diff LO

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added a comment. thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470250 , @ChuanqiXu wrote: > BTW, in my experience for talking about modules to users, they mainly/mostly > care about the compilation performance. And I can't image how many people > would like to use modules if they

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. BTW, in my experience for talking about modules to users, they mainly/mostly care about the compilation performance. And I can't image how many people would like to use modules if they know they won't get a compilation performance win. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#4470235 , @iains wrote: > In D126694#4470139 , @ChuanqiXu > wrote: > >> Now I think the feature may be important for the performance of modules. And >> I feel we should work

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470139 , @ChuanqiXu wrote: > Now I think the feature may be important for the performance of modules. And > I feel we should work on the ASTWriter side instead of ASTReader side. Since > the size of BMIs is a problem n

[Lldb-commits] [PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. Now I think the feature may be important for the performance of modules. And I feel we should work on the ASTWriter side instead of ASTReader side. Since the size of BMIs is a problem now also it shows that it is not free to load the large BMIs. So while it is semanti

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153918/new/ https://reviews.llvm.org/D153918 ___

[Lldb-commits] [lldb] 6977c1c - [lldb] Remove old commented out code (NFC)

Author: Dave Lee Date: 2023-07-03T14:41:03-07:00 New Revision: 6977c1caf43fa22988cfd811d65dce39f1720c34 URL: https://github.com/llvm/llvm-project/commit/6977c1caf43fa22988cfd811d65dce39f1720c34 DIFF: https://github.com/llvm/llvm-project/commit/6977c1caf43fa22988cfd811d65dce39f1720c34.diff LOG:

[Lldb-commits] [lldb] cec93c6 - [lldb] SymbolFileJSON: Update outdates Text -> JSON (NFC)

Author: Jonas Devlieghere Date: 2023-07-03T14:28:02-07:00 New Revision: cec93c6589fe6e6fab99aa5c11819ff841a469b2 URL: https://github.com/llvm/llvm-project/commit/cec93c6589fe6e6fab99aa5c11819ff841a469b2 DIFF: https://github.com/llvm/llvm-project/commit/cec93c6589fe6e6fab99aa5c11819ff841a469b2.d

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl accepted this revision. avl added a comment. This revision is now accepted and ready to land. this LGTM, assuming D154329 is landed. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https:

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 ___

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

This revision was automatically updated to reflect the committed changes. Closed by commit rG51944e78bb37: [lldb] Add two-level caching in the source manager (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 51944e7 - [lldb] Add two-level caching in the source manager

Author: Jonas Devlieghere Date: 2023-07-03T14:12:39-07:00 New Revision: 51944e78bb3760768d62b79e972a8e65baaa1518 URL: https://github.com/llvm/llvm-project/commit/51944e78bb3760768d62b79e972a8e65baaa1518 DIFF: https://github.com/llvm/llvm-project/commit/51944e78bb3760768d62b79e972a8e65baaa1518.d

[Lldb-commits] [PATCH] D154365: [lldb][nfc] Remove redundant nullptr check

This revision was automatically updated to reflect the committed changes. Closed by commit rGf470ab734c9b: [lldb][nfc] Remove redundant nullptr check (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154365/new/ https://reviews.l

[Lldb-commits] [lldb] f470ab7 - [lldb][nfc] Remove redundant nullptr check

Author: Felipe de Azevedo Piovezan Date: 2023-07-03T17:12:06-04:00 New Revision: f470ab734c9bae9464faf6cff6530beb32ea44ba URL: https://github.com/llvm/llvm-project/commit/f470ab734c9bae9464faf6cff6530beb32ea44ba DIFF: https://github.com/llvm/llvm-project/commit/f470ab734c9bae9464faf6cff6530beb3

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

mib added a comment. LGTM! @bulbazord when you land this, make sure to close @teemperor's diff (D104231 ). Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 __

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D154387: [lldb][NFCI] Minor cleanup of default OptionValue::GetSubValue implementation

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This does 2 things: - Corrects a minor typo (`value subvalue` -> `valid s

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

bulbazord updated this revision to Diff 536873. bulbazord added a comment. Small fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154386/new/ https://reviews.llvm.org/D154386 Files: lldb/source/Interpreter/OptionValue.cpp Index: lldb/source/I

[Lldb-commits] [PATCH] D154386: [lldb][NFCI] Remove use of ConstString from OptionValue

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No need to create a ConstString, `GetName` already returns a StringRef.

[Lldb-commits] [PATCH] D153918: [lldb][NFCI] Deprecate SBValue::GetOpaqueType

bulbazord updated this revision to Diff 536865. bulbazord added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153918/new/ https://reviews.llvm.org/D153918 Files: lldb/include/lldb/API/SBValue.h Index: lldb/include/l

[Lldb-commits] [PATCH] D153900: [lldb] Deprecate SBHostOS threading functionality

bulbazord updated this revision to Diff 536864. bulbazord added a comment. Reword deprecation message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153900/new/ https://reviews.llvm.org/D153900 Files: lldb/include/lldb/API/SBHostOS.h lldb/tools

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9987646057d9: [lldb] Fix data race when interacting with python scripts (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 9987646 - [lldb] Fix data race when interacting with python scripts

Author: Med Ismail Bennani Date: 2023-07-03T11:49:11-07:00 New Revision: 9987646057d9748514662f96c869a5f87e463bc6 URL: https://github.com/llvm/llvm-project/commit/9987646057d9748514662f96c869a5f87e463bc6 DIFF: https://github.com/llvm/llvm-project/commit/9987646057d9748514662f96c869a5f87e463bc6.

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib updated this revision to Diff 536859. mib added a comment. Address @JDevlieghere last comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h lldb/sourc

[Lldb-commits] [PATCH] D153917: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

This revision was automatically updated to reflect the committed changes. Closed by commit rGb709149b7627: [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] b709149 - [lldb][NFCI] Target::StopHook::GetDescription should take a Stream ref instead of pointer

Author: Alex Langford Date: 2023-07-03T11:39:38-07:00 New Revision: b709149b76277e8bea4a3d7977ccb4e818499b7b URL: https://github.com/llvm/llvm-project/commit/b709149b76277e8bea4a3d7977ccb4e818499b7b DIFF: https://github.com/llvm/llvm-project/commit/b709149b76277e8bea4a3d7977ccb4e818499b7b.diff

[Lldb-commits] [PATCH] D153834: [lldb] Add two-level caching in the source manager

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153834/new/ https://reviews.llvm.org/D153834 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D154365: [lldb][nfc] Remove redundant nullptr check

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154365/new/ https://reviews.llvm.org/D154365 ___

[Lldb-commits] [PATCH] D153928: [lldb] Introduce a macro to mark methods as unsupported with no replacement

This revision was automatically updated to reflect the committed changes. Closed by commit rGebec53e2d7c7: [lldb] Introduce a macro to mark methods as unsupported with no replacement (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] ebec53e - [lldb] Introduce a macro to mark methods as unsupported with no replacement

Author: Alex Langford Date: 2023-07-03T11:17:48-07:00 New Revision: ebec53e2d7c79b519aec455d048f5f03fc2e7abe URL: https://github.com/llvm/llvm-project/commit/ebec53e2d7c79b519aec455d048f5f03fc2e7abe DIFF: https://github.com/llvm/llvm-project/commit/ebec53e2d7c79b519aec455d048f5f03fc2e7abe.diff

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo one more lock. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h:381 uint32_t IsExecutingPython() const { r

[Lldb-commits] [PATCH] D153827: [lldb][NFCI] Remove use of ConstString from ProcessElfCore

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3921b8bff69: [lldb][NFCI] Remove use of ConstString from ProcessElfCore (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153827/new/

[Lldb-commits] [lldb] e3921b8 - [lldb][NFCI] Remove use of ConstString from ProcessElfCore

Author: Alex Langford Date: 2023-07-03T11:13:50-07:00 New Revision: e3921b8bff693649602760a6221cd1150420a287 URL: https://github.com/llvm/llvm-project/commit/e3921b8bff693649602760a6221cd1150420a287 DIFF: https://github.com/llvm/llvm-project/commit/e3921b8bff693649602760a6221cd1150420a287.diff

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib updated this revision to Diff 536850. mib added a comment. After chatting with Jonas, it turns out that my previous implementation didn't actually address the underflow issue using atomics, so we have to revert to using a `std::mutex` when incrementing/decrementing the python lock counter.

[Lldb-commits] [PATCH] D153825: [lldb][NFCI] Change return type of GetProcessPluginName

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b102886c0c3: [lldb][NFCI] Change return type of GetProcessPluginName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153825/new/ htt

[Lldb-commits] [lldb] 1b10288 - [lldb][NFCI] Change return type of GetProcessPluginName

Author: Alex Langford Date: 2023-07-03T10:03:49-07:00 New Revision: 1b102886c0c33bb01ff8f2360b57c7b8d039abcc URL: https://github.com/llvm/llvm-project/commit/1b102886c0c33bb01ff8f2360b57c7b8d039abcc DIFF: https://github.com/llvm/llvm-project/commit/1b102886c0c33bb01ff8f2360b57c7b8d039abcc.diff

[Lldb-commits] [PATCH] D154365: [lldb][nfc] Remove redundant nullptr check

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. The make_shared function never returns a nullptr, as such the test fo

[Lldb-commits] [PATCH] D153810: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2ff2921e84a: [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [lldb] a2ff292 - [lldb][NFCI] TypeSystemClang::CreateStructForIdentifier should take a StringRef

Author: Alex Langford Date: 2023-07-03T09:35:24-07:00 New Revision: a2ff2921e84aa435e124ad275f70855a185cfb1c URL: https://github.com/llvm/llvm-project/commit/a2ff2921e84aa435e124ad275f70855a185cfb1c DIFF: https://github.com/llvm/llvm-project/commit/a2ff2921e84aa435e124ad275f70855a185cfb1c.diff

[Lldb-commits] [lldb] 673f910 - [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

Author: Alex Langford Date: 2023-07-03T09:31:10-07:00 New Revision: 673f91055a41b2273e159eafe86d0d7d87fa474f URL: https://github.com/llvm/llvm-project/commit/673f91055a41b2273e159eafe86d0d7d87fa474f DIFF: https://github.com/llvm/llvm-project/commit/673f91055a41b2273e159eafe86d0d7d87fa474f.diff

[Lldb-commits] [PATCH] D153905: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer

This revision was automatically updated to reflect the committed changes. Closed by commit rG673f91055a41: [lldb][NFCI] Remove unneeded use of ConstString in ASTResultSynthesizer (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added a comment. this LGTM. thanks! Please, wait for approve from Jonas. I think someone from lldb needs to check whether new error reporting is OK. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 __

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; avl wrote: > probably, it would be better to add err

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein updated this revision to Diff 536735. hokein marked an inline comment as done. hokein added a comment. address a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154329/new/ https://reviews.llvm.org/D154329 Files: lldb/tools/lldb-se

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

avl added inline comments. Comment at: lldb/tools/lldb-server/lldb-platform.cpp:112 return Status("Failed to atomically write file %s", file_spec.GetPath().c_str()); return status; probably, it would be better to add error text here? `

[Lldb-commits] [PATCH] D154265: [lldb][NFC] Simplify GetLocation_DW_OP_addr function

This revision was automatically updated to reflect the committed changes. Closed by commit rGf292ca136240: [lldb][NFC] Simplify GetLocation_DW_OP_addr function (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154265/new/ https:/

[Lldb-commits] [lldb] f292ca1 - [lldb][NFC] Simplify GetLocation_DW_OP_addr function

Author: Felipe de Azevedo Piovezan Date: 2023-07-03T08:36:57-04:00 New Revision: f292ca136240a9c694aa280ad7fd0b961930804a URL: https://github.com/llvm/llvm-project/commit/f292ca136240a9c694aa280ad7fd0b961930804a DIFF: https://github.com/llvm/llvm-project/commit/f292ca136240a9c694aa280ad7fd0b961

[Lldb-commits] [PATCH] D154268: [lldb] Skip apple accelerator table test in DWARF 5 mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG379b59d1b0f3: [lldb] Skip apple accelerator table test in DWARF 5 mode (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154268/new/ htt

[Lldb-commits] [lldb] 379b59d - [lldb] Skip apple accelerator table test in DWARF 5 mode

Author: Felipe de Azevedo Piovezan Date: 2023-07-03T08:35:55-04:00 New Revision: 379b59d1b0f3e1ddc421f706e9de65e52acad0cb URL: https://github.com/llvm/llvm-project/commit/379b59d1b0f3e1ddc421f706e9de65e52acad0cb DIFF: https://github.com/llvm/llvm-project/commit/379b59d1b0f3e1ddc421f706e9de65e52

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein marked an inline comment as done. hokein added a comment. Now this patch only contains the removal part of the API (I have cleaned all usages of `writeFileAtomically` API, except a remaining one in lldb https://reviews.llvm.org/D154329). Comment at: lldb/tools/lldb-ser

[Lldb-commits] [PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein updated this revision to Diff 536698. hokein added a comment. Restrict the patch to only remove the writeFileAtomically API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153740/new/ https://reviews.llvm.org/D153740 Files: llvm/include/llv

[Lldb-commits] [PATCH] D154329: [lldb] Replace llvm::writeFileAtomically with llvm::writeToOutput API.

hokein created this revision. hokein added reviewers: avl, JDevlieghere. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D154329 Files: l

[Lldb-commits] [PATCH] D154201: [lldb][AArch64] Fix tagged watch test on Graviton 3

DavidSpickett added a comment. > I suspect that's what most people using write watchpoints would actually > want, outside of this issue of false watchpoint hits. Seems like the sensible route. The other option is understanding every instruction's behaviour, which is in theory possible but I wo