[Lldb-commits] [PATCH] D152494: [lldb][Android] Fix adb shell cat

splhack created this revision. splhack added a reviewer: clayborg. Herald added a subscriber: danielkiss. Herald added a project: All. splhack edited the summary of this revision. splhack added reviewers: labath, lanza. splhack published this revision for review. Herald added a project: LLDB. Heral

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord updated this revision to Diff 529769. bulbazord added a comment. Changed a bit of formatting to follow LLVM style more closely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151919/new/ https://reviews.llvm.org/D151919 Files: lldb/sour

[Lldb-commits] [PATCH] D152476: [lldb] Remove lldb's DWARFAbbreviationDeclarationSet in favor of llvm's

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, fdeazeve, rastogishubham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb's and llvm's implementations of DW

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

This revision was automatically updated to reflect the committed changes. Closed by commit rG643ba926c1f6: [lldb][NFCI] Remove use of ConstString from OptionValueProperties (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210

[Lldb-commits] [lldb] 643ba92 - [lldb][NFCI] Remove use of ConstString from OptionValueProperties

Author: Alex Langford Date: 2023-06-08T15:19:27-07:00 New Revision: 643ba926c1f618401c86dc37e659df795db2e1a0 URL: https://github.com/llvm/llvm-project/commit/643ba926c1f618401c86dc37e659df795db2e1a0 DIFF: https://github.com/llvm/llvm-project/commit/643ba926c1f618401c86dc37e659df795db2e1a0.diff

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1a7b7f6d55e: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/ne

[Lldb-commits] [lldb] b1a7b7f - [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

Author: Alex Langford Date: 2023-06-08T15:13:55-07:00 New Revision: b1a7b7f6d55ed33166008a4d23d598582237b69d URL: https://github.com/llvm/llvm-project/commit/b1a7b7f6d55ed33166008a4d23d598582237b69d DIFF: https://github.com/llvm/llvm-project/commit/b1a7b7f6d55ed33166008a4d23d598582237b69d.diff

[Lldb-commits] [lldb] d29b567 - [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

Author: Alex Langford Date: 2023-06-08T15:11:22-07:00 New Revision: d29b5673822d2ce7be85c789fd9809f096ec5adc URL: https://github.com/llvm/llvm-project/commit/d29b5673822d2ce7be85c789fd9809f096ec5adc DIFF: https://github.com/llvm/llvm-project/commit/d29b5673822d2ce7be85c789fd9809f096ec5adc.diff

[Lldb-commits] [PATCH] D152310: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rGd29b5673822d: [lldb][NFCI] Remove use of ConstString from OptionValueLanguage (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152310/n

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

JDevlieghere added a comment. In D152364#4406704 , @saugustine wrote: > What other progress reporting needs rate limiting? > > To the best of my knowledge, we have only identified one location--this one. > So I'm not sure a fully general solution is in

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

saugustine added a comment. What other progress reporting needs rate limiting? To the best of my knowledge, we have only identified one location--this one. So I'm not sure a fully general solution is in order here under the YAGNI principle. I favor rate limiting close to the source because gen

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1ebfc5de34e: [lldb] Unconditionally increment depth when printing children (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/n

[Lldb-commits] [lldb] b1ebfc5 - [lldb] Unconditionally increment depth when printing children

Author: Augusto Noronha Date: 2023-06-08T13:30:30-07:00 New Revision: b1ebfc5de34ef4c91aa6f163989de600fb5227f8 URL: https://github.com/llvm/llvm-project/commit/b1ebfc5de34ef4c91aa6f163989de600fb5227f8 DIFF: https://github.com/llvm/llvm-project/commit/b1ebfc5de34ef4c91aa6f163989de600fb5227f8.dif

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 529709. augusto2112 marked an inline comment as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files: lld

[Lldb-commits] [PATCH] D152364: [lldb] Rate limit progress reports -- different approach [WIP-ish]

JDevlieghere added a comment. Continuing some of the discussion from D150805 here as it mostly relates to this patch: In D150805#4402906 , @labath wrote: > I agree that we should have a rate limiting mechanism very clo

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

JDevlieghere accepted this revision. JDevlieghere added a comment. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210/new/ https://reviews.llvm.org/D152210 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D152326: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bae706682d5: [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 4bae706 - [lldb][NFCI] DecodedThread::TraceItemStorage::error should own its own data

Author: Alex Langford Date: 2023-06-08T12:19:14-07:00 New Revision: 4bae706682d5b621884ff2f7014ba4eb8cb636aa URL: https://github.com/llvm/llvm-project/commit/4bae706682d5b621884ff2f7014ba4eb8cb636aa DIFF: https://github.com/llvm/llvm-project/commit/4bae706682d5b621884ff2f7014ba4eb8cb636aa.diff

[Lldb-commits] [PATCH] D152409: [lldb] Never print children if the max depth has been reached

augusto2112 updated this revision to Diff 529673. augusto2112 added a comment. Remove failure check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152409/new/ https://reviews.llvm.org/D152409 Files: lldb/include/lldb/DataFormatters/ValueObjectPri

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83cb2123be48: [lldb][NFC]Update debug (eh-frame) tests to work with new dwarwin MC changes (authored by oontvoo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 83cb212 - [lldb][NFC]Update debug (eh-frame) tests to work with new dwarwin MC changes

Author: Vy Nguyen Date: 2023-06-08T13:11:34-04:00 New Revision: 83cb2123be487302070562c45e6eb4955b22c2b4 URL: https://github.com/llvm/llvm-project/commit/83cb2123be487302070562c45e6eb4955b22c2b4 DIFF: https://github.com/llvm/llvm-project/commit/83cb2123be487302070562c45e6eb4955b22c2b4.diff LOG

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449 __

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

oontvoo updated this revision to Diff 529654. oontvoo added a comment. updated commit msg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449 Files: lldb/test/Shell/Unwind/prefer-debug-over-eh-frame.test

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

oontvoo updated this revision to Diff 529653. oontvoo added a comment. Removed XFAIL: system-darwin from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449 Files: lldb/test/Shell/Unwind/prefer-debug-o

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

fdeazeve added a comment. Thanks for looking into this! I think we should just remove the XFAIL instead, for the reasons you mentioned in the other patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152449/new/ https://reviews.llvm.org/D152449

[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4c67a682f9: [lldb][test] LogTest: Fix stack overflow (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152454/new/ https://reviews.l

[Lldb-commits] [lldb] 9c4c67a - [lldb][test] LogTest: Fix stack overflow

Author: Michael Buch Date: 2023-06-08T17:10:32+01:00 New Revision: 9c4c67a682f9d9b2cca183fcb9533bf709ffa723 URL: https://github.com/llvm/llvm-project/commit/9c4c67a682f9d9b2cca183fcb9533bf709ffa723 DIFF: https://github.com/llvm/llvm-project/commit/9c4c67a682f9d9b2cca183fcb9533bf709ffa723.diff

[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152454/new/ https://reviews.llvm.org/D152454

[Lldb-commits] [PATCH] D152454: [lldb][test] LogTest: Fix stack overflow

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The expected function name requires 18 bytes of storage. Caught by the public ASAN buildbot Repository: rG LLVM G

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/DataFormatters/ValueObjectPrinter.cpp:610 if (child_sp.get()) { ValueObjectPrinter child_printer( I would probably factor out: ``` if (does_consume_ptr_depth) --cu

[Lldb-commits] [PATCH] D152449: [lldb][NFC]Update debug (eh-frame) tests to preserve old behaviour.

oontvoo created this revision. oontvoo added a reviewer: fdeazeve. Herald added a project: All. oontvoo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Details: D144999 potentially changes the debug forma

[Lldb-commits] [PATCH] D152324: [lldb][NFCI] Change return type of PersistentExpressionState::GetNextPersistentVariableName

fdeazeve accepted this revision. fdeazeve added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangPersistentVariables.cpp:129-134 llvm::SmallString<64> name; { llvm::raw_svector_ostream os(name); os << GetPersistentVariablePrefix(is_err

[Lldb-commits] [PATCH] D152315: [lldb][NFCI] Refactor TypeSystemClang::GetBasicTypeEnumeration

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152315/new/ https://reviews.llvm.org/D152315 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D152210: [lldb][NFCI] Remove use of ConstString from OptionValueProperties

fdeazeve accepted this revision. fdeazeve added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152210/new/ https://reviews.llvm.org/D152210 __