[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

This revision was automatically updated to reflect the committed changes. Closed by commit rGfda53ad9374b: [lldb] Support Universal Mach-O binaries with a fat64 header (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] fda53ad - [lldb] Support Universal Mach-O binaries with a fat64 header

Author: Jonas Devlieghere Date: 2023-03-28T15:46:26-07:00 New Revision: fda53ad9374b60fc83f1a6065ae3e7985182a5d2 URL: https://github.com/llvm/llvm-project/commit/fda53ad9374b60fc83f1a6065ae3e7985182a5d2 DIFF: https://github.com/llvm/llvm-project/commit/fda53ad9374b60fc83f1a6065ae3e7985182a5d2.d

[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks for checking! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147012/new/ https://reviews.llvm.org/D147012 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp:205 +const lldb::offset_t slice_file_offset = +fat_arch.GetOffset() + file_of

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord abandoned this revision. bulbazord added a comment. I'm abandoning this approach in favor of what Pavel suggested: https://reviews.llvm.org/D147084 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147009/new/ https://reviews.llvm.org/D14700

[Lldb-commits] [PATCH] D147084: [lldb] Move ObjectFileJIT to lldbExpression

bulbazord created this revision. bulbazord added reviewers: labath, JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In the spirit of not having lldbExpression rely

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. In D145803#4220124 , @wolfgangp wrote: > In D145803#4219894 , @probinson > wrote: > >> This is pretty different from the "always desugar to the canonical type" >> habit that has alway

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

bulbazord planned changes to this revision. bulbazord added a comment. In D147009#4227163 , @labath wrote: > I already regret getting involved in this, but here it goes... Your effort and participation is greatly appreciated. I'm sorry if this is frustr

[Lldb-commits] [PATCH] D147001: [lldb] TestInferiorCrashing.py should check for crash reason

This revision was automatically updated to reflect the committed changes. Closed by commit rG9efb4db29dcc: [lldb] TestInferiorCrashing.py should check for crash reason (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147001/new/

[Lldb-commits] [lldb] 9efb4db - [lldb] TestInferiorCrashing.py should check for crash reason

Author: Alex Langford Date: 2023-03-28T12:19:10-07:00 New Revision: 9efb4db29dcc94b32710884e5af3f4e0b38263a6 URL: https://github.com/llvm/llvm-project/commit/9efb4db29dcc94b32710884e5af3f4e0b38263a6 DIFF: https://github.com/llvm/llvm-project/commit/9efb4db29dcc94b32710884e5af3f4e0b38263a6.diff

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 509089. kuilpd added a comment. Wrong previous diff. Added asserts in default cases, added checks for architecture instead of address size, added a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D14696

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 509080. kuilpd added a comment. Added asserts in default cases, added checks for architecture instead of address size, added a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/inclu

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd marked 8 inline comments as done. kuilpd added inline comments. Comment at: lldb/source/Expression/IRMemoryMap.cpp:113-114 lldbassert(process_sp->GetAddressByteSize() == 4 || end_of_memory != 0xull); bulbazord wrote: > I th

[Lldb-commits] [PATCH] D147006: [lldb] Fix value printing for a specific case

This revision was automatically updated to reflect the committed changes. Closed by commit rG51dd8a20c1c3: [lldb] Fix value printing for a specific case (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147006/new/ https://rev

[Lldb-commits] [lldb] 51dd8a2 - [lldb] Fix value printing for a specific case

Author: Dave Lee Date: 2023-03-28T09:38:46-07:00 New Revision: 51dd8a20c1c32c60d03719e0e40bbc8e6c125477 URL: https://github.com/llvm/llvm-project/commit/51dd8a20c1c32c60d03719e0e40bbc8e6c125477 DIFF: https://github.com/llvm/llvm-project/commit/51dd8a20c1c32c60d03719e0e40bbc8e6c125477.diff LOG:

[Lldb-commits] [PATCH] D143062: [lldb] Allow evaluating expressions in C++20 mode

aprantl added inline comments. Comment at: lldb/source/Target/Language.cpp:272 + case eLanguageTypeC_plus_plus_17: + case eLanguageTypeC_plus_plus_20: case eLanguageTypeObjC_plus_plus: Can you check if we already have a similar function in Dwarf.h in LLVM?

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

yinghuitan accepted this revision. yinghuitan added a comment. This revision is now accepted and ready to land. LGTM. I have patched and verified this diff indeed fixed the performance issue in our internal service with 3000~4000 threads. Thanks for fixing it! Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp:205 +const lldb::offset_t slice_file_offset = +fat_arch.GetOffset() + file_of

[Lldb-commits] [PATCH] D147012: [lldb] Support Universal Mach-O binaries with a fat64 header

aprantl added inline comments. Comment at: lldb/source/Plugins/ObjectContainer/Universal-Mach-O/ObjectContainerUniversalMachO.cpp:205 +const lldb::offset_t slice_file_offset = +fat_arch.GetOffset() + file_offset; +if (fat_arch.GetOffset() < file_size

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

labath added a comment. Thank you for your understanding. Let me know if you need anything from me. In the long-term I'd like to factor this signal code such that there is a single common code which maps all signals (or at least the most common ones) to their default disposition, description an

[Lldb-commits] [PATCH] D147045: [lldb] Drop RegisterInfoInterface::GetDynamicRegisterInfo

labath created this revision. labath added a reviewer: DavidSpickett. Herald added a subscriber: pengfei. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. "Dynamic register info" is a very overloaded term, and this particular instance of it was o

[Lldb-commits] [PATCH] D147009: [lldb] Remove lldbExpression's dependency on ObjectFileJIT

labath added a comment. I already regret getting involved in this, but here it goes... Do you actually expect we will have multiple ObjectFile subclasses implementing the `ObjectFileCreateInstanceWithDelegate` interface? Because if not, then I think this is just a very roundabout way of being a

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

labath marked 2 inline comments as done. labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:376-386 +bool handled = llvm::any_of(m_processes, [&](NativeProcessLinux *process) { + return process->TryHandleWaitStatus(pid, sta

[Lldb-commits] [PATCH] D146977: [lldb-server/linux] Use waitpid(-1) to collect inferior events

labath updated this revision to Diff 508957. labath marked an inline comment as done. labath added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146977/new/ https://reviews.llvm.org/D146977 Files: lldb/include/