[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. yep, there's no need for the realpath Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138345/new/ https://reviews.llvm.org/D138345

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

aprantl added a comment. Generally, I think this can be useful information. I don't have any better suggestion, but I'd like to ask the room if we think that `` is a good message for the end users. (`Forward-declared type`, `type missing from debug info`, ...?) Comment at: l

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

kastiglione updated this revision to Diff 476652. kastiglione added a comment. Fix commit wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138348/new/ https://reviews.llvm.org/D138348 Files: lldb/bindings/interface/SBFileSpec.i Index: lld

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

aprantl added inline comments. Comment at: lldb/include/lldb/API/SBType.h:212 + /// Returns true for types that were incomplete in the debug information but + /// should have been a complete. When the debugger constructs types, we must + /// have enough information to reconstr

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @labath thanks, I believe a more correct fix here https://reviews.llvm.org/D138348 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D138348: [lldb] Fix SBFileSpec.fullpath

kastiglione created this revision. kastiglione added reviewers: mib, labath. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reimplement of `SBFileSpec.fullpath` to (indirectly) use `FileSpec::GetPat

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

aprantl added a comment. I still have a few more questions about the interface design here. May main goal is to eliminate as much mutable state and objects being passed by reference as makes sense (and no more :-). In that vain I'm trying to get rid of all Set...() methods and all places where

[Lldb-commits] [PATCH] D138345: [test][lldb-vscode] Un-realpath coreFile test.

rupprecht created this revision. rupprecht added a reviewer: wallace. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TestVSCode_coreFile looks for an exe/core file in the same directory as the test.

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

rupprecht created this revision. rupprecht added reviewers: wallace, clayborg. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't think the intent of this test is to make sure we only have one com

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. The next step for this is to modify the ValueObject::MaybeCalculateCompleteType() to see if we get a type that has been forcefully completed and if it has, replace it with the real type. But that will require that Module::FindFirstType() works reliably and it currently

[Lldb-commits] [PATCH] D138248: [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG288843a161f7: [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

This revision was automatically updated to reflect the committed changes. mib marked an inline comment as done. Closed by commit rG7e01924e4e56: [lldb/Plugins] Improve error reporting with reading memory in Scripted Process (authored by mib). Changed prior to commit: https://reviews.llvm.org/D1

[Lldb-commits] [lldb] 7e01924 - [lldb/Plugins] Improve error reporting with reading memory in Scripted Process

Author: Med Ismail Bennani Date: 2022-11-18T13:56:48-08:00 New Revision: 7e01924e4e5634a6fa7d500574aeca58c8f36873 URL: https://github.com/llvm/llvm-project/commit/7e01924e4e5634a6fa7d500574aeca58c8f36873 DIFF: https://github.com/llvm/llvm-project/commit/7e01924e4e5634a6fa7d500574aeca58c8f36873.

[Lldb-commits] [lldb] 27a26e7 - [lldb/Python] Unify PythonFormat & GetPythonValueFormatString (NFC)

Author: Med Ismail Bennani Date: 2022-11-18T13:56:48-08:00 New Revision: 27a26e7ab7d8a8b47c63f68bd1801fc2f9342637 URL: https://github.com/llvm/llvm-project/commit/27a26e7ab7d8a8b47c63f68bd1801fc2f9342637 DIFF: https://github.com/llvm/llvm-project/commit/27a26e7ab7d8a8b47c63f68bd1801fc2f9342637.

[Lldb-commits] [lldb] 288843a - [lldb/Python] Make use of PythonObject and PythonFormat in callbacks (NFC)

Author: Med Ismail Bennani Date: 2022-11-18T13:56:48-08:00 New Revision: 288843a161f71148d7028e5153038006dd87e363 URL: https://github.com/llvm/llvm-project/commit/288843a161f71148d7028e5153038006dd87e363 DIFF: https://github.com/llvm/llvm-project/commit/288843a161f71148d7028e5153038006dd87e363.

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added a comment. would somebody be willing to lgtm the workaround while we investigate further since this is currently breaking a fairly typical debugging session? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione updated this revision to Diff 476550. kastiglione added a comment. Add license in .cpp too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.org/D138315 Files: lldb/include/lldb/Core/Debugger.h lldb/in

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione updated this revision to Diff 476549. kastiglione added a comment. Add license. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.org/D138315 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/l

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

aeubanks added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.h:1 +#include "lldb/Interpreter/CommandObject.h" + license? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https:/

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl, jingham, labath, werat, cmtice. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implements `dwim-print`, a prin

[Lldb-commits] [PATCH] D129898: [test] Allow libc++ namespaces besides `__1`

rupprecht added a comment. In D129898#3656303 , @rupprecht wrote: > In D129898#3656268 , @JDevlieghere > wrote: > >> Seems like there's another instance of this in >> `TestForwardDeclFromStdModule.py`. > > Added

[Lldb-commits] [PATCH] D138237: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG58d38b3ff8c3: [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] 58d38b3 - [lldb] Restore default setting of LLDB_INCLUDE_TESTS in standalone builds

Author: Alex Langford Date: 2022-11-18T09:05:08-08:00 New Revision: 58d38b3ff8c3c4dd816d2047acf65fa97c0b6fb8 URL: https://github.com/llvm/llvm-project/commit/58d38b3ff8c3c4dd816d2047acf65fa97c0b6fb8 DIFF: https://github.com/llvm/llvm-project/commit/58d38b3ff8c3c4dd816d2047acf65fa97c0b6fb8.diff

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

rupprecht created this revision. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, arichardson. Herald added a pro

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 _

[Lldb-commits] [lldb] 5704598 - [LLDB][AArch64] Add BF16BF16, SME2p1 and SVE2p1 to disassembler test

Author: David Spickett Date: 2022-11-18T16:17:40Z New Revision: 57045982e92eeff7b52402eee3fba72dda0274c8 URL: https://github.com/llvm/llvm-project/commit/57045982e92eeff7b52402eee3fba72dda0274c8 DIFF: https://github.com/llvm/llvm-project/commit/57045982e92eeff7b52402eee3fba72dda0274c8.diff LOG

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl requested changes to this revision. avl added a comment. This revision now requires changes to proceed. I think we need to create a test case. I tried(still trying) to create one, but it seems this assertions should always be satisfied : "assert(Ref > InputDIE.getOffset());". That might be a

[Lldb-commits] [lldb] a8bec61 - [lldb] Fix that empty target.run-args are not actually used when launching process

Author: Raphael Isemann Date: 2022-11-18T16:48:56+01:00 New Revision: a8bec6117998cd4a9ff6798381cd0df9c9edb982 URL: https://github.com/llvm/llvm-project/commit/a8bec6117998cd4a9ff6798381cd0df9c9edb982 DIFF: https://github.com/llvm/llvm-project/commit/a8bec6117998cd4a9ff6798381cd0df9c9edb982.dif

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8bec6117998: [lldb] Fix that empty target.run-args are not actually used when launching… (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D138276: TableGen: require tablegen cl::opts to be registered explicitly

nhaehnle created this revision. Herald added subscribers: libc-commits, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle,

[Lldb-commits] [PATCH] D138271: Fix license header in TraceHTR.h

pietroalbini created this revision. Herald added a project: All. pietroalbini requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It seems like the license header got mangled somehow, joining multiple lines together and splitting some lines acr

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. And another problem with this patch: there's another pattern (or multiple different patterns?) in the code, that result in around 3x clang memory usage increase after this patch. The result of `-print-stats` doesn't make it clear where the additional allocations come fro