[Lldb-commits] [lldb] 7bf3cb3 - [lldb] Fix issue with re.Pattern availability

Author: Dave Lee Date: 2022-11-07T19:33:57-08:00 New Revision: 7bf3cb3ee871b6707b7f5114a7fde61485df450e URL: https://github.com/llvm/llvm-project/commit/7bf3cb3ee871b6707b7f5114a7fde61485df450e DIFF: https://github.com/llvm/llvm-project/commit/7bf3cb3ee871b6707b7f5114a7fde61485df450e.diff LOG:

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bf3cb3ee871: [lldb] Fix issue with re.Pattern availability (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://rev

Re: [Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

Given the broad impact of this in our code I'm inclined to revert the patch to unblock us. The test case I have so far is still too large, but I hope to get something shareable tomorrow. On Tue, 8 Nov 2022, 04:03 Matheus Izvekov via Phabricator, < revi...@reviews.llvm.org> wrote: > mizvekov added

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. @alexfh Thanks! While there is a huge increase in the amount of UsingTypes, it seems the total amount is still reasonable and does not explain the perf hit. Perhaps this is a case of bad hashing and they are all falling into the same bucket? cc @sam.mcall for awarene

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. In D136565#3913065 , @mizvekov wrote: > In D136565#3911884 , @alexfh wrote: > >> Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d >>

[Lldb-commits] [lldb] 32a2af4 - [CMake] Fix -Wstrict-prototypes

Author: Sam James Date: 2022-11-08T01:37:04Z New Revision: 32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d URL: https://github.com/llvm/llvm-project/commit/32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d DIFF: https://github.com/llvm/llvm-project/commit/32a2af44e1e882f13d1cc2817f0a8d4d8b375d4d.diff LOG: [CM

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu updated this revision to Diff 473834. zequanwu added a comment. Adding a test for incomplete record type as class static member. It returns error, because its type not required to be completed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.h:90 void Dump(Stream &stream); + static void RequireCompleteType(CompilerType type); I forgot about this the first time around, but it'd be nice if this code c

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu updated this revision to Diff 473829. zequanwu added a comment. Removed `PdbAstBuilder::RequireCompleteType` from `PdbAstBuilder::CreateArrayType` as it's not necessary at all. 1. When the element type info is missing, its size info is missing in pdb, which is 0. Thus we can't calculat

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione updated this revision to Diff 473812. kastiglione added a comment. Switch to getting the type dynamically instead of by name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 Files: lldb/pack

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione updated this revision to Diff 473811. kastiglione added a comment. Use short circuit to avoid eager eval of `re.SRE_Pattern` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 Files: lldb/packa

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione added a comment. > Anyway to test this ? I don't have a Python 3.6 to test with. I did test locally which caught an issue, so I am at least confident it won't regress anything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

mib accepted this revision. mib added a comment. LGTM! Anyway to test this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

rastogishubham accepted this revision. rastogishubham added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 __

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione updated this revision to Diff 473768. kastiglione added a comment. Simplify the fallback expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137582/new/ https://reviews.llvm.org/D137582 Files: lldb/packages/Python/lldbsuite/tes

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Followup to D134378 . With PrintingPolicy::SuppressScope, we'd also n

[Lldb-commits] [PATCH] D137582: [lldb] Fix issue with re.Pattern availability

kastiglione created this revision. kastiglione added reviewers: mib, rastogishubham, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `re.Pattern` is introduced in Python 3.7. To support

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

mizvekov added a comment. In D136565#3911884 , @alexfh wrote: > Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d > causes > compilation timeout on some of our internal files. Hi

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

JDevlieghere added a comment. I like the new approach, it's much easier to follow. I also like the wrapper class to abstract over the common operations. It just seems like there are some remnants of the canonical wp approach that we no longer need. Comment at: lldb/include/ll

[Lldb-commits] [PATCH] D137464: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()

This revision was automatically updated to reflect the committed changes. Closed by commit rGec1bd2546d34: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription() (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] ec1bd25 - [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()

Author: Arthur Eubanks Date: 2022-11-07T10:29:09-08:00 New Revision: ec1bd2546d343aad0d4d8d02c695493f59567553 URL: https://github.com/llvm/llvm-project/commit/ec1bd2546d343aad0d4d8d02c695493f59567553 DIFF: https://github.com/llvm/llvm-project/commit/ec1bd2546d343aad0d4d8d02c695493f59567553.diff

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

wallace accepted this revision. wallace added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if

[Lldb-commits] [PATCH] D137564: [ARM] Move Triple::getARMCPUForArch into ARMTargetParser

tmatheson created this revision. tmatheson added reviewers: lenary, pratlucas, DavidSpickett. Herald added subscribers: hiraditya, kristof.beyls, dschuff. Herald added a project: All. tmatheson requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, Mas

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp:244 // Optional clang/llvm target triple. + // This must be provided if the trace will be created not using the CLI or on a machine other than where the

[Lldb-commits] [PATCH] D137509: [NFC][intelpt] Improve IntelPT trace bundle documentation

jj10306 updated this revision to Diff 473628. jj10306 marked an inline comment as done. jj10306 added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137509/new/ https://reviews.llvm.org/D137509 Files: lldb/source/Plugi

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

alexfh added a comment. Hi Matheus, 279fe6281d2ca5b2318c7437316c28750feaac8d causes compilation timeout on some of our internal files. We're trying to get a test case we can share, but so far the only information I can provid