jj10306 updated this revision to Diff 473628.
jj10306 marked an inline comment as done.
jj10306 added a comment.
address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137509/new/
https://reviews.llvm.org/D137509
Files:
lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
Index: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
===================================================================
--- lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
+++ lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
@@ -241,6 +241,8 @@
"pid": integer,
"triple"?: string,
// Optional clang/llvm target triple.
+ // This must be provided if the trace will be created not using the
+ // CLI or on a machine other than where the target was traced.
"threads": [
// A list of known threads for the given process. When context switch
// data is provided, LLDB will automatically create threads for the
Index: lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
===================================================================
--- lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
+++ lldb/source/Plugins/Trace/intel-pt/TraceIntelPTBundleLoader.cpp
@@ -241,6 +241,8 @@
"pid": integer,
"triple"?: string,
// Optional clang/llvm target triple.
+ // This must be provided if the trace will be created not using the
+ // CLI or on a machine other than where the target was traced.
"threads": [
// A list of known threads for the given process. When context switch
// data is provided, LLDB will automatically create threads for the
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
