[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the changes. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191/new/ https://reviews.llvm.org/D137191 ___ lld

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

mib updated this revision to Diff 472497. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D135547 Files: lldb/include/lldb/Core/StructuredDataImpl.h lldb/include/lldb/Utility/StructuredData.h lldb/source/Commands/CommandObjectProcess.cpp lldb/so

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

mib added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:584 static ObjectSP ParseJSONFromFile(const FileSpec &file, Status &error); + static bool IsRecordType(const ObjectSP object_sp); }; @JDevlieghere Not sure if it would be worth

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

mib updated this revision to Diff 472475. mib added a comment. Address @JDevlieghere comments: - Fix indentation bug on nested structures - Add tests - Use string literals for expected string in tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135547/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord updated this revision to Diff 472468. bulbazord added a comment. Address feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137191/new/ https://reviews.llvm.org/D137191 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Symbol/TypeSystem.h lldb/include/lldb/Ta

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu created this revision. zequanwu added reviewers: rnk, tejohnson, mehdi_amini. Herald added subscribers: pmatos, asb, ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, emaste. Herald added a reviewer: MaskRay. Herald added projects: lld-macho, All. Herald added a reviewer: lld-

[Lldb-commits] [PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov added a comment. In D127695#3860316 , @rjmccall wrote: > I see, thank you. I know you've marked this a WIP, but it's always good to > describe these things in the patch description; that's what it's for. Done! I have also removed the WIP. While

[Lldb-commits] [PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov retitled this revision from "[clang] Implement Template Specialization Resugaring" to "[clang] Template Specialization Resugaring - TypeDecl". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 472416. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

tschuett added inline comments. Comment at: lldb/source/Target/Statistics.cpp:266 +auto stats = ts->ReportStatistics(); +if (stats.hasValue()) { + module_stat_obj->try_emplace("TypeSystemInfo", stats.getValue()); clayborg wrote: > Remove

[Lldb-commits] [lldb] 9c9afbb - [lldb] Document QSetDetachOnError packet

Author: Felipe de Azevedo Piovezan Date: 2022-11-01T14:09:33-07:00 New Revision: 9c9afbb76f82004efef4bb1be843661f8d89bcaa URL: https://github.com/llvm/llvm-project/commit/9c9afbb76f82004efef4bb1be843661f8d89bcaa DIFF: https://github.com/llvm/llvm-project/commit/9c9afbb76f82004efef4bb1be843661f8

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9afbb76f82: [lldb] Document QSetDetachOnError packet (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136958/new/ https://reviews.llv

[Lldb-commits] [PATCH] D136958: [lldb] Document QSetDetachOnError packet

fdeazeve added a comment. In D136958#3896820 , @jasonmolenda wrote: > debugserver often can't tell the difference between these (when you run a > process on a local system, lldb actually does the posix_spawn and then tells > debugserver to attach to it

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

tschuett added inline comments. Comment at: lldb/include/lldb/Core/Module.h:817 + void ForEachTypeSystem(std::function const &callback); + Maybe `llvm::function_ref`? https://llvm.org/doxygen/classllvm_1_1function__ref_3_01Ret_07Params_8_8_8_08_4.html Reposi

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Target/Statistics.cpp:258 debug_index_time += module_stat.debug_index_time; debug_info_size += module_stat.debug_info_size

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord added a comment. I have a pull request to apple's fork to show how this is used for swift: https://github.com/apple/llvm-project/pull/5540 I primarily wanted this portion to be upstream so that the patch is easier to maintain downstream, but it could be useful for clang-produced TypeS

[Lldb-commits] [PATCH] D137191: [lldb] Add information on type systems to statistics dump command

bulbazord created this revision. bulbazord added reviewers: clayborg, JDevlieghere, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Context: I plan on using this change primarily downstream in

[Lldb-commits] [PATCH] D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

kastiglione accepted this revision. kastiglione added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135616/new/ https://reviews.llvm.org/D135616 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

kastiglione accepted this revision. kastiglione added a comment. looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137137/new/ https://reviews.llvm.org/D137137 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

JDevlieghere added a comment. The change looks good but I'd like to see a few more unit tests to cover edge cases (empty array, dict, etc), Comment at: lldb/unittests/Utility/StructuredDataTest.cpp:40-43 + const std::string expected = + " Array :\n3.14\n1.23

[Lldb-commits] [PATCH] D135616: [lldb/Utility] Fix StructuredData::ParseJSONValue for null items

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135616/new/ https://reviews.llvm.org/D135616 ___

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

This revision was automatically updated to reflect the committed changes. Closed by commit rGa715b1bde910: [lldb] Don't crash when printing static enum members with bool as underlying… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] a715b1b - [lldb] Don't crash when printing static enum members with bool as underlying type

Author: Arthur Eubanks Date: 2022-11-01T09:28:54-07:00 New Revision: a715b1bde91077b313b9c36d9ecbc0c83a0edac2 URL: https://github.com/llvm/llvm-project/commit/a715b1bde91077b313b9c36d9ecbc0c83a0edac2 DIFF: https://github.com/llvm/llvm-project/commit/a715b1bde91077b313b9c36d9ecbc0c83a0edac2.diff

[Lldb-commits] [PATCH] D135622: [lldb] Add a "diagnostics dump" command

stella.stamenova added a comment. The newly added test is failing on the windows buildbot: https://lab.llvm.org/buildbot/#/builders/83/builds/25446 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135622/new/ https://reviews.llvm.org/D135622 ___

[Lldb-commits] [PATCH] D136697: Add formatting support for VSCode logpoints message

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8995649afa: Add formatting support for VSCode logpoints message (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136697/new/ https:

[Lldb-commits] [lldb] 6c89956 - Add formatting support for VSCode logpoints message

Author: Jeffrey Tan Date: 2022-11-01T08:43:30-07:00 New Revision: 6c8995649afac04a9eb0e71affd997e493c9b93a URL: https://github.com/llvm/llvm-project/commit/6c8995649afac04a9eb0e71affd997e493c9b93a DIFF: https://github.com/llvm/llvm-project/commit/6c8995649afac04a9eb0e71affd997e493c9b93a.diff L

[Lldb-commits] [PATCH] D137045: [lldb] Don't crash when printing static enum members with bool as underlying type

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7612 + ->getIntegerType() + ->isSpecificBuiltinType(BuiltinT

[Lldb-commits] [PATCH] D137057: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

This revision was automatically updated to reflect the committed changes. Closed by commit rGe9c34618c904: [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection (authored by seehearfeel, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [lldb] e9c3461 - [LLDB][LoongArch] Add LoongArch ArchSpec and subtype detection

Author: Tiezhu Yang Date: 2022-11-01T17:06:04+08:00 New Revision: e9c34618c904e0b22b6c9fec1f4a410e7484b8d3 URL: https://github.com/llvm/llvm-project/commit/e9c34618c904e0b22b6c9fec1f4a410e7484b8d3 DIFF: https://github.com/llvm/llvm-project/commit/e9c34618c904e0b22b6c9fec1f4a410e7484b8d3.diff L