[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

2022-09-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); kastiglione wrote: >

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

2022-09-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added a reviewer: rsmith. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to D117383 , fixing the assumption

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

2022-09-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:74 + if (name.consume_front("std::")) +name.consume_front("__1::"); + return name.consume_front(type) && name.startswith("<"); rsmith wrote: > This

[Lldb-commits] [lldb] 75f05fc - [lldb][bindings] Fix module_access handling of regex

2022-09-03 Thread Dave Lee via lldb-commits
Author: Dave Lee Date: 2022-09-03T10:33:26-07:00 New Revision: 75f05fccbbdd91393bdc7b6183b9dd2b1e859f8e URL: https://github.com/llvm/llvm-project/commit/75f05fccbbdd91393bdc7b6183b9dd2b1e859f8e DIFF: https://github.com/llvm/llvm-project/commit/75f05fccbbdd91393bdc7b6183b9dd2b1e859f8e.diff LOG:

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

2022-09-03 Thread Dave Lee via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75f05fccbbdd: [lldb][bindings] Fix module_access handling of regex (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

2022-09-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione updated this revision to Diff 457804. kastiglione added a comment. Add a test for subscripting a target.modules using regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 Files: lldb/bindin

[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

2022-09-03 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Split the read thread support from Communication into a dedicated ThreadedCommunication subclas

[Lldb-commits] [PATCH] D133240: [Formatters][NFCI] Replace 'is_regex' arguments with an enum.

2022-09-03 Thread Will Hawkins via Phabricator via lldb-commits
hawkinsw added inline comments. Comment at: lldb/include/lldb/DataFormatters/FormattersContainer.h:46 /// just matching by comparing with m_type_name string. - bool m_is_regex; + lldb::FormatterMatchType m_match_type; I am really intrigued by this entire p