[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1189-1192 + std::string pid_prefix; + if (GetID() != LLDB_INVALID_PROCESS_ID && + m_gdb_comm.GetMultiprocessSupported

[Lldb-commits] [PATCH] D131837: [lldb] [gdb-remote] Initial support for multiple ContinueDelegates

mgorny added a comment. In D131837#3732971 , @labath wrote: > This sort of makes sense to me, but it's not clear to me how is this > selection logic going to apply to packets other than stop-replies. All of the > forked processes are going to share the

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

clayborg added inline comments. Comment at: lldb/source/API/SBModuleSpec.cpp:137 LLDB_INSTRUMENT_VA(this, uuid, uuid_len) - m_opaque_up->GetUUID() = UUID::fromOptionalData(uuid, uuid_len); + m_opaque_up->GetUUID() = UUID::fromData(uuid, uuid_len); return m_opaque_up->GetU

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Minidump files have UUID values that are zeroed out. We will need to do something for these that can sense all zeroes and return a default constructed one. Co

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

jingham created this revision. jingham added reviewers: JDevlieghere, clayborg, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. At present, there are two ways to get data into a UUID object, an u

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 453829. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D132187: [LLDB] Remove duplicate loop in FindMatchingModuleSpec.

zequanwu abandoned this revision. zequanwu added a comment. Herald added a subscriber: JDevlieghere. NVM, didn't see `exact_arch_match` is false in the second search. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132187/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D132187: [LLDB] Remove duplicate loop in FindMatchingModuleSpec.

zequanwu created this revision. zequanwu added a reviewer: labath. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The removed loop is the same as the one above it. If previous one success, it returns.

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

cassanova updated this revision to Diff 453808. cassanova added a comment. Removed the full CMake invocation for the fuzzer build configuration. Added the information on OSS Fuzz to its own section. Changed build directory in fuzzer execution command to use a relative path. Removed reference to

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

cassanova added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:12 + +Building the LLDB fuzzers requires a build configuration that has the address sanitizer and sanitizer coverage. This CMake invocation will configure a build directory that can be used to build th

[Lldb-commits] [PATCH] D131335: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. In D131335#3732877 , @labath wrote: > In D131335#3726204 , @Michael137 > wrote: > >> Thanks for taking the time to look at this >> >>> I would like to understand what (if any) are the

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

mib added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:28-33 +To build a fuzzer, run the desired ninja command for the fuzzer(s) you want to build: + +:: + $ ninja lldb-target-fuzzer + $ ninja lldb-commandinterpreter-fuzzer + $ ninja lldb-expression-fuzzer

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:28-33 +To build a fuzzer, run the desired ninja command for the fuzzer(s) you want to build: + +:: + $ ninja lldb-target-fuzzer + $ ninja lldb-commandinterpreter-fuzzer + $ ninja lldb-expressio

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

JDevlieghere added inline comments. Comment at: lldb/docs/resources/fuzzing.rst:14-26 +:: + $ cmake \ +-G Ninja \ +-DCMAKE_BUILD_TYPE='Release' \ +-DLLVM_USE_SANITIZER='Address' \ +-DLLVM_USE_SANITIZE_COVERAGE=On \ +-DLLVM_BUILD_RUNTIME=

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny marked an inline comment as done. mgorny added a comment. In D131160#3732668 , @labath wrote: > Thanks for taking care of the posix part. > > I'm sort of warming up to the idea of reusing pending callback machinery for > this. Besides avoiding the

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

Michael137 added a comment. In D131974#3732727 , @labath wrote: > In D131974#3726618 , @labath wrote: > >> For me this wins on simplicity grounds alone. >> >> In D131974#3726475

[Lldb-commits] [PATCH] D131758: [lldb] [gdb-remote] Include PID in vCont packets if multiprocess

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:1189-1192 + std::string pid_prefix; + if (GetID() != LLDB_INVALID_PROCESS_ID && +

[Lldb-commits] [PATCH] D131837: [lldb] [gdb-remote] Initial support for multiple ContinueDelegates

labath added a comment. This sort of makes sense to me, but it's not clear to me how is this selection logic going to apply to packets other than stop-replies. All of the forked processes are going to share the same pty, so it's going to be literally impossible to distinguish the `O` packets, f

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

mib added a comment. Left few comments :) Comment at: lldb/docs/resources/fuzzing.rst:12 + +Building the LLDB fuzzers requires a build configuration that has the address sanitizer and sanitizer coverage. This CMake invocation will configure a build directory that can be used

[Lldb-commits] [PATCH] D131335: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

labath added a comment. In D131335#3726204 , @Michael137 wrote: > Thanks for taking the time to look at this > >> I would like to understand what (if any) are the issues with extending the >> approach #2 to cover non-member functions as well. For what i

[Lldb-commits] [PATCH] D131974: [lldb][ClangExpression] Add asm() label to all FunctionDecls we create from DWARF

labath added a comment. In D131974#3726618 , @labath wrote: > For me this wins on simplicity grounds alone. > > In D131974#3726475 , @Michael137 > wrote: > >> - Check mangled name and storage class before attachi

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

labath added inline comments. Comment at: lldb/include/lldb/Utility/SharedCluster.h:52 ClusterManager() : m_objects() {} - - llvm::SmallVector m_objects; + llvm::SmallPtrSet m_objects; std::mutex m_mutex; JDevlieghere wrote: > labath wrote: > > JDevlieghe

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. Thanks for taking care of the posix part. I'm sort of warming up to the idea of reusing pending callback machinery for this. Besides avoiding the awkward naming problem, it also avoid another somewhat strange situation where our EventHandle offer additional actions on t

[Lldb-commits] [PATCH] D132148: [lldb][docs] Add documentation for LLDB fuzzers

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds a new page to the

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} mstorsjo wrote: > mstorsjo wr

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

labath added a comment. Thank you, Martin and Alvin for trying this out. Setting `LLDB_USE_LLDB_SERVER` definitely increases the number of tests that use lldb-server, but I wouldn't really say it's necessary, as I would expect that a change like this either works, or fails spectacularly. Can I

[Lldb-commits] [PATCH] D131159: [lldb] Use WSAEventSelect for MainLoop polling on windows

labath updated this revision to Diff 453686. labath added a comment. Switch to the implementation which uses persistent WSAEvents for listening. I have no idea whether this makes a difference in practice, but it /feels/ more efficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D131996: Use a SmallPtrSet rather than a SmallVector in ClusterManager.

This revision was automatically updated to reflect the committed changes. Closed by commit rG33722848fcb5: Use a SmallPtrSet rather than a SmallVector in ClusterManager. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D131996?vs=453127&id=453685#toc Repository: rG LL

[Lldb-commits] [lldb] 3372284 - Use a SmallPtrSet rather than a SmallVector in ClusterManager.

Author: Jim Ingham Date: 2022-08-18T09:34:28-07:00 New Revision: 33722848fcb5b569ab3a388cae15f31acf9a9c5e URL: https://github.com/llvm/llvm-project/commit/33722848fcb5b569ab3a388cae15f31acf9a9c5e DIFF: https://github.com/llvm/llvm-project/commit/33722848fcb5b569ab3a388cae15f31acf9a9c5e.diff LO

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117383/new/ https://reviews.llvm.org/D117383 ___

[Lldb-commits] [PATCH] D130942: [LLDB][DWARF] Set MSInheritanceAttr for record decl when it's using Microsoft compatible ABI.

mstorsjo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1754 + m_ast.getASTContext(), + clang::MSInheritanceAttr::Spelling::Keyword_unspecified_inheritance)); +} mstorsjo wrote: > rnk wrote:

[Lldb-commits] [PATCH] D132062: [lldb] [gdb-remote] Clean up the API of GDBRemoteCommunication

mgorny planned changes to this revision. mgorny added a comment. Actually, this makes little sense without un-publicizing the inherited methods first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132062/new/ https://reviews.llvm.org/D132062 ___