[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

stellaraccident accepted this revision. stellaraccident added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 452884. fixathon added a comment. Address the style issue by removing "using", and specifying std:: namespace explicitly. Note, lldb style guide does not appear to prohibit the import of individual members from another namespace in a non-header file. Never

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

This revision was automatically updated to reflect the committed changes. Closed by commit rG11f45f36dcf5: [lldb] Fetching symbols in the background with dsymForUUID (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D131328?vs=452786&id=

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d36a82d0a3d: [lldb] Flush the global thread pool in Debugger::Terminate (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [lldb] 11f45f3 - [lldb] Fetching symbols in the background with dsymForUUID

Author: Jonas Devlieghere Date: 2022-08-15T17:57:24-07:00 New Revision: 11f45f36dcf54b0fe8e54ce5e410e24f3b9b5a1e URL: https://github.com/llvm/llvm-project/commit/11f45f36dcf54b0fe8e54ce5e410e24f3b9b5a1e DIFF: https://github.com/llvm/llvm-project/commit/11f45f36dcf54b0fe8e54ce5e410e24f3b9b5a1e.d

[Lldb-commits] [lldb] 8d36a82 - [lldb] Flush the global thread pool in Debugger::Terminate

Author: Jonas Devlieghere Date: 2022-08-15T17:57:23-07:00 New Revision: 8d36a82d0a3d118329b9f24b33e58d0a28360891 URL: https://github.com/llvm/llvm-project/commit/8d36a82d0a3d118329b9f24b33e58d0a28360891 DIFF: https://github.com/llvm/llvm-project/commit/8d36a82d0a3d118329b9f24b33e58d0a28360891.d

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova updated this revision to Diff 452853. cassanova added a comment. Added the queue-specific breakpoints to their own test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131605/new/ https://reviews.llvm.org/D131605 Files: lldb/test/API/ma

[Lldb-commits] [PATCH] D131407: [lldb] Flush the global thread pool in Debugger::Terminate

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131407/new/ https://reviews.llvm.org/D131407 ___ lldb-com

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

JDevlieghere added a comment. In D131900#3724366 , @fixathon wrote: > I am going to clean up the code in the entire file where **raw pointers** > should be **shared_ptr** (because they get cast to shared_ptr anyways). Also > planning to convert the **na

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

tstellar added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by LLVM (e.g. googletest)") stel

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

cassanova added inline comments. Comment at: lldb/test/API/macosx/queues/TestQueues.py:201-206 +# Run the executable until the stopper function and get the breakpoint +# that's created from that. Then set the queue name of the breakpoint +# to be the name

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

JDevlieghere added a comment. Great. Thanks for closing the loop on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131821/new/ https://reviews.llvm.org/D131821 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon updated this revision to Diff 452809. fixathon marked an inline comment as done. fixathon added a comment. Convert raw pointers to shared_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 Files

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment. I am going to clean up the code in the entire file where **raw pointers** should be **shared_ptr** (because they get cast to shared_ptr anyways). Also planning to convert the **naked n

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

stellaraccident added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:1257 + +set(LLVM_THIRD_PARTY_DIR ${CMAKE_CURRENT_SOURCE_DIR}/../third-party CACHE STRING +"Directory containing third party software used by LLVM (e.g. googletest)") --

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

lattner accepted this revision. lattner added a comment. This revision is now accepted and ready to land. I didn't review the patch in detail, but +1 this is a great step forward to reorganize the repo! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

tstellar created this revision. tstellar added reviewers: stellaraccident, rnk, lattner, probinson, jyknight, phosek. Herald added subscribers: Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, mstorsjo, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufen

[Lldb-commits] [PATCH] D131328: [lldb] Support fetching symbols with dsymForUUID in the background

JDevlieghere updated this revision to Diff 452786. JDevlieghere added a comment. Rebase on top of D131303 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131328/new/ https://reviews.llvm.org/D131328 Files: lldb/include/lldb/Core/Debugger.h lldb/incl

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

emrekultursay added a comment. In D131821#3723474 , @JDevlieghere wrote: > I applied your patch and ran the test and for me it's passing: Thanks Jonas, I believe https://reviews.llvm.org/D127999 (and follow-ups) fixed the bug I was observing. I was syn

[Lldb-commits] [lldb] 570e10c - [lldb] Fix warning: comparison of integers of different signs

Author: Jonas Devlieghere Date: 2022-08-15T11:25:46-07:00 New Revision: 570e10cb9def153812f13ef1945f9ef388ab3e3e URL: https://github.com/llvm/llvm-project/commit/570e10cb9def153812f13ef1945f9ef388ab3e3e DIFF: https://github.com/llvm/llvm-project/commit/570e10cb9def153812f13ef1945f9ef388ab3e3e.d

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So any functions that are "StructureData:: *" raw pointers in this source code should switch over to returning on of the StruturedData definitions from StructuredData.h: class

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

kazu added a comment. Oops, sorry about the breakage. Thank you for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D131605: [lldb][tests] Test queue-specific breakpoints

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/macosx/queues/TestQueues.py:133 +"The breakpoint for queue %s has not been hit" % (queue_breakpoi

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa5124327a01: [LLDB][NFC] Reliability Fixes for FormatEntity (authored by fixathon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131850/new/ https://revie

[Lldb-commits] [lldb] fa51243 - [LLDB][NFC] Reliability Fixes for FormatEntity

Author: Slava Gurevich Date: 2022-08-15T10:16:47-07:00 New Revision: fa5124327a01ef060f2c5a301e9600892bb63280 URL: https://github.com/llvm/llvm-project/commit/fa5124327a01ef060f2c5a301e9600892bb63280 DIFF: https://github.com/llvm/llvm-project/commit/fa5124327a01ef060f2c5a301e9600892bb63280.diff

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

aprantl added a comment. In D131335#3722595 , @Michael137 wrote: > As @labath mentioned, we do force clang to preserve the linkage name via > `asm()`, but only for class member functions. This was added in > `675767a5910d2ec77ef8b51c78fe312cf9022896` (

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

This revision was automatically updated to reflect the committed changes. Closed by commit rG350755d94d6b: [llvm] Include utils/unittest before projects and runtimes (authored by JDevlieghere). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131850/new/ https://reviews.llvm.org/D131850 ___

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

JDevlieghere accepted this revision. JDevlieghere added a comment. In D131664#3715513 , @DavidSpickett wrote: > @JDevlieghere Unless this is still used in your downstream? Thanks for checking. It's not used downstream, so this LGTM. Repository: rG L

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/InstrumentationRuntime/TSan/InstrumentationRuntimeTSan.cpp:227 static StructuredData::Array *ConvertToStructuredArray( ValueObjectSP return_value_sp, const std::string &items_name, fixat

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added inline comments. Comment at: lldb/source/Host/posix/MainLoopPosix.cpp:74-82 + in_events.reserve(loop.m_read_fds.size() + 1); } Status MainLoopPosix::RunImpl::Poll() { - in_events.resize(loop.m_read_fds.size()); + in_events.resize(loop.m_read_fds.size() + 1);

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny updated this revision to Diff 452714. mgorny added a comment. Rebase on top of D131159 and partially implement the Linux counterpart. Note that I have only covered `sys/event.h` for now and that I haven't tested the updated Windows code. CHANGES SINCE

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rGac1bedd58435: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131

[Lldb-commits] [lldb] ac1bedd - [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

Author: Michael Buch Date: 2022-08-15T17:35:39+01:00 New Revision: ac1bedd584359567266b1c41ac26734556031b9f URL: https://github.com/llvm/llvm-project/commit/ac1bedd584359567266b1c41ac26734556031b9f DIFF: https://github.com/llvm/llvm-project/commit/ac1bedd584359567266b1c41ac26734556031b9f.diff

[Lldb-commits] [PATCH] D131795: [LLDB] Fix the 'default' switch case in GetCompatibleArchs()

fixathon planned changes to this revision. fixathon added inline comments. Comment at: lldb/test/API/functionalities/gdb_remote_client/TestPlatformMacOSX.py:22 def qHostInfo(self): -return "cputype:16777223;cpusubtype:2;ostype:%s;vendor:apple;os_version:10.

[Lldb-commits] [PATCH] D131900: [LLDB][NFC] Fix memory leak in IntstumentationRuntimeTSan.cpp

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

Michael137 updated this revision to Diff 452704. Michael137 added a comment. - Fix parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 Files: lldb/tools/debugserver/source/RNBRemote.cpp Index:

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

fdeazeve accepted this revision. fdeazeve added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131901/new/ https://reviews.llvm.org/D131901 ___

[Lldb-commits] [PATCH] D131901: [lldb][debugserver] Revert "Use llvm::all_of (NFC)" for debugserver

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Commit 6d9cd9199a6fdeab0412117bcefc28f625510b61

[Lldb-commits] [PATCH] D131664: [LLDB][ARM] Remove unused LoadPseudoRegistersFromFrame function

DavidSpickett added a comment. @JDevlieghere ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131664/new/ https://reviews.llvm.org/D131664 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D131821: Add test that shows the problem with D118814

JDevlieghere added a comment. I applied your patch and ran the test and for me it's passing: lldb version 16.0.0git (g...@github.com:llvm/llvm-project.git revision 0c90d5f7e967aee8ab6e5e971e25921e631a40ac) clang revision 0c90d5f7e967aee8ab6e5e971e25921e631a40ac llvm revision 0c90d5f7e9

[Lldb-commits] [PATCH] D131850: [LLDB][NFC] Reliability Fixes for FormatEntity

fixathon created this revision. fixathon added reviewers: clayborg, JDevlieghere, DavidSpickett, jasonmolenda. Herald added a project: All. fixathon published this revision for review. fixathon added inline comments. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. =

[Lldb-commits] [PATCH] D131783: [LLDB][JIT] Set processor for ARM architecture

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Thanks! LGTM. You might see some test failures for TestFPEval if anyone is testing on AIX/PPC/etc. but I think it's fine to go ahead and wait for the buildbots to complain if th

[Lldb-commits] [PATCH] D131772: [LLDB] Remove __future__ imports from examples

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f947abf94e1: [LLDB] Remove __future__ imports from examples (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131772/new/ https://

[Lldb-commits] [lldb] 9f947ab - [LLDB] Remove __future__ imports from examples

Author: David Spickett Date: 2022-08-15T09:04:25Z New Revision: 9f947abf94e16fa7c759ab56a4fb030d6ef25961 URL: https://github.com/llvm/llvm-project/commit/9f947abf94e16fa7c759ab56a4fb030d6ef25961 DIFF: https://github.com/llvm/llvm-project/commit/9f947abf94e16fa7c759ab56a4fb030d6ef25961.diff LOG

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added a comment. As @labath mentioned, we do force clang to preserve the linkage name via `asm()`, but only for class member functions. This was added in `675767a5910d2ec77ef8b51c78fe312cf9022896` (https://reviews.llvm.org/D40283) to also support `abi_tag`! But that didn't cover temp

[Lldb-commits] [PATCH] D131761: [LLDB] Remove __future__ imports from tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG193259cbcec7: [LLDB] Remove __future__ imports from tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131761/new/ https://rev

[Lldb-commits] [lldb] 193259c - [LLDB] Remove __future__ imports from tests

Author: David Spickett Date: 2022-08-15T08:54:06Z New Revision: 193259cbcec77add8e189c4dedeefb15fef50d5e URL: https://github.com/llvm/llvm-project/commit/193259cbcec77add8e189c4dedeefb15fef50d5e DIFF: https://github.com/llvm/llvm-project/commit/193259cbcec77add8e189c4dedeefb15fef50d5e.diff LOG

[Lldb-commits] [lldb] 4025a8a - [NFC][trace][intel pt] add simple documentation line

Author: Walter Erquinigo Date: 2022-08-15T00:56:12-07:00 New Revision: 4025a8ae934f77ec21558c40aa82937bfe74a7c3 URL: https://github.com/llvm/llvm-project/commit/4025a8ae934f77ec21558c40aa82937bfe74a7c3 DIFF: https://github.com/llvm/llvm-project/commit/4025a8ae934f77ec21558c40aa82937bfe74a7c3.di