fixathon planned changes to this revision. fixathon marked 2 inline comments as done. fixathon added a comment.
I am going to clean up the code in the entire file where **raw pointers** should be **shared_ptr** (because they get cast to shared_ptr anyways). Also planning to convert the **naked new** and the 2-step **shared_ptr** creation to **make_shared<>** ; the former is less-safe for potential leaks, and the latter is strictly better. @JDevlieghere Yes, some of these planned raw pointer changes could be **unique_ptr**, but these types are already typedef-ed in StructuredData.h as **shared_ptr** and I'd like to preserve the style in the absence of specific know performance issues in this code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131900/new/ https://reviews.llvm.org/D131900 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
