[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

Michael137 marked 3 inline comments as done. Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Language.h:317 + /// function names. + /// + /// \param[in] mangled_names List of mangled names to generate aprantl wrote: >

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:1515 +void CPlusPlusLanguage::CollectAlternateFunctionNamesItanium( +std::vector &results, ConstString name, +const SymbolContext &sc) const { apran

[Lldb-commits] [PATCH] D131335: WIP: [lldb] abi_tag support 3/3 - Use mangle tree API to determine approximate mangled matches

Michael137 updated this revision to Diff 452547. Michael137 marked 5 inline comments as done. Michael137 added a comment. - Use ConstString::GetLength where possible - Add more comments - Rebase - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D131333: [lldb] abi_tag support 2/3 - Make FindBestAlternateFunctionMangledName local to the C++ language plugin

Michael137 updated this revision to Diff 452546. Michael137 added a comment. - Return `std::vector` instead of using an output argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131333/new/ https://reviews.llvm.org/D131333 Files: lldb/includ

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere added inline comments. Comment at: lldb/CMakeLists.txt:128 +set(LLDB_INCLUDE_UNITTESTS ON) +if (NOT TARGET llvm_gtest) + set(LLDB_INCLUDE_UNITTESTS OFF) mgorny wrote: > If LLDB is built through `LLVM_ENABLE_PROJECTS`, then LLDB's CMakeLists are > i