Michael137 added inline comments.
================
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:1515
+void CPlusPlusLanguage::CollectAlternateFunctionNamesItanium(
+ std::vector<ConstString> &results, ConstString name,
+ const SymbolContext &sc) const {
----------------
aprantl wrote:
> why not return the vector?
We're adding to it in a loop in `CollectAlternateFunctionNames`. Of course we
could push the loop into `CollectAlternateFunctionNamesItanium` and
`CollectAlternateFunctionNamesMangled` but imo that makes the functions less
readable
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131335/new/
https://reviews.llvm.org/D131335
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
