jgorbe added inline comments.
Comment at: lldb/source/DataFormatters/FormatManager.cpp:595
+ {
+std::lock_guard guard(m_language_categories_mutex);
+m_language_categories_map[lang_type] =
hawkinsw wrote:
> Forgive me if I am speaking out of turn, but do
jingham added a comment.
Mostly reworking the paragraph on breakpoint hiding.
Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:2088
+The "liveness" of these settings is one way, from name to breakpoint.
+If you use break modify to change an option that is also con
jingham updated this revision to Diff 434222.
jingham added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127038/new/
https://reviews.llvm.org/D127038
Files:
lldb/source/Commands/CommandObjectBreakpoint.cpp
I
mib added a comment.
Thanks for writing that! I'm sure many users will find it very useful.
Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:2088
+The "liveness" of these settings is one way, from name to breakpoint.
+If you use break modify to change an option th
jingham added a comment.
More generally, you can tell which elements of the exe_ctx you need to check in
any given command by looking at requirements for the command which are passed
into the constructor for the command. Any entity that's required there, you
don't need to check for, but otherw
jingham created this revision.
jingham added reviewers: kastiglione, mib, JDevlieghere, clayborg.
Herald added a project: All.
jingham requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
breakpoint names have a bunch of uses, some obvious and s
cassanova added inline comments.
Comment at: lldb/source/Commands/CommandObjectMemory.cpp:597-598
+ABISP abi;
+if (Process * proc = m_exe_ctx.GetProcessPtr())
+ abi = proc->GetABI();
+
kastiglione wrote:
> Should `memory read` emit an error if there'
mib accepted this revision.
mib added a comment.
This revision is now accepted and ready to land.
LGTM with some minor feedbacks :) !
Comment at: lldb/source/Commands/CommandObjectMemory.cpp:597
+ABISP abi;
+if (Process * proc = m_exe_ctx.GetProcessPtr())
+ abi = p
kastiglione added inline comments.
Comment at: lldb/source/Commands/CommandObjectMemory.cpp:597-598
+ABISP abi;
+if (Process * proc = m_exe_ctx.GetProcessPtr())
+ abi = proc->GetABI();
+
Should `memory read` emit an error if there's no process (and n
cassanova created this revision.
cassanova added reviewers: JDevlieghere, mib.
cassanova added a project: LLDB.
Herald added a project: All.
cassanova requested review of this revision.
Herald added a subscriber: lldb-commits.
Adds a check to ensure that a process exists before attempting to get i
wallace created this revision.
wallace added a reviewer: jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
For some context, The context switch data contains information of which threads
were
exe
jj10306 added a comment.
feedback-v2
Comment at: lldb/source/Plugins/Process/Linux/Perf.cpp:183
+Expected>
+PerfEvent::ReadFlushedOutDataCyclicBuffer(size_t offset, size_t size) {
+ CollectionState previous_state = m_collection_state;
Do we need the offset/siz
hawkinsw added inline comments.
Comment at: lldb/source/DataFormatters/FormatManager.cpp:595
+ {
+std::lock_guard guard(m_language_categories_mutex);
+m_language_categories_map[lang_type] =
Forgive me if I am speaking out of turn, but do we need to check
wallace created this revision.
wallace added a reviewer: jj10306.
Herald added a project: All.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The process triple should only be needed when LLDB can't identify the correct
triple on i
wallace updated this revision to Diff 434093.
wallace added a comment.
update test files
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126394/new/
https://reviews.llvm.org/D126394
Files:
lldb/include/lldb/Target/Trace.h
lldb/include/lldb/Utili
Author: Jim Ingham
Date: 2022-06-03T11:34:53-07:00
New Revision: 8cc8b36f24d6f3133c44e238a657309620eedc19
URL:
https://github.com/llvm/llvm-project/commit/8cc8b36f24d6f3133c44e238a657309620eedc19
DIFF:
https://github.com/llvm/llvm-project/commit/8cc8b36f24d6f3133c44e238a657309620eedc19.diff
LO
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8cc8b36f24d6: CommandObjectRegexCommand shouldn't put
two commands on the history stack. (authored by jingham).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/
jingham updated this revision to Diff 434082.
jingham added a comment.
Fix a comment that hadn't been correct for a while...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126789/new/
https://reviews.llvm.org/D126789
Files:
lldb/source/Commands/C
wallace updated this revision to Diff 434081.
wallace edited the summary of this revision.
wallace added a comment.
Herald added subscribers: mgrang, mgorny.
finish diff
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126394/new/
https://reviews.llvm
jingham added inline comments.
Comment at: lldb/source/Commands/CommandObjectRegexCommand.cpp:74-76
// Pass in true for "no context switching". The command that called us
// should have set up the context appropriately, we shouldn't have to
// redo that.
---
jingham added inline comments.
Comment at: lldb/source/Commands/CommandObjectRegexCommand.cpp:74-76
// Pass in true for "no context switching". The command that called us
// should have set up the context appropriately, we shouldn't have to
// redo that.
---
mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste.
Herald added a subscriber: arichardson.
Herald added a project: All.
mgorny requested review of this revision.
Implement support for the "t" action that is used to stop a thread.
Normally this action is used only in
mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste.
Herald added a subscriber: arichardson.
Herald added a project: All.
mgorny requested review of this revision.
Sponsored by: The FreeBSD Foundation
https://reviews.llvm.org/D126982
Files:
lldb/packages/Python/l
This revision was automatically updated to reflect the committed changes.
Closed by commit rGaed179f5f557: [lldb] [Process/FreeBSD] Do not send SIGSTOP
to stopped process (authored by mgorny).
Herald added a project: LLDB.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:/
Author: Michał Górny
Date: 2022-06-03T15:19:09+02:00
New Revision: aed179f5f557664d6deb26ef6fdc6aa944af41af
URL:
https://github.com/llvm/llvm-project/commit/aed179f5f557664d6deb26ef6fdc6aa944af41af
DIFF:
https://github.com/llvm/llvm-project/commit/aed179f5f557664d6deb26ef6fdc6aa944af41af.diff
mgorny updated this revision to Diff 434008.
mgorny added a comment.
Update the test following changes in the dependent patches.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126615/new/
https://reviews.llvm.org/D126615
Files:
lldb/test/Shell/Process/Inputs/signal.c
lldb/test/Shell
mgorny updated this revision to Diff 434007.
mgorny added a comment.
Use `vCont;t` instead of `vCtrlC` to stop other threads for better gdbserver
compatibility. Defer enabling non-stop until after the `?` status query, to
workaround a bug in gdbserver.
CHANGES SINCE LAST ACTION
https://revie
mgorny updated this revision to Diff 434006.
mgorny added a comment.
Send `OK` before the asynchronous stop reason to `k` packet. Support `vCont;t`
(as a special case) in non-stop mode.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D125575/new/
https://reviews.llvm.org/D125575
Files:
28 matches
Mail list logo
