hawkinsw added inline comments.
================
Comment at: lldb/source/DataFormatters/FormatManager.cpp:595
+ {
+ std::lock_guard<std::recursive_mutex> guard(m_language_categories_mutex);
+ m_language_categories_map[lang_type] =
----------------
Forgive me if I am speaking out of turn, but do we need to check again here for
whether `lang_type` is in the map? In other words, it seems possible that (in
some zany situation) while we are doing the memory allocation (line 593)
someone else has come along and added that category since we released the lock
on it in 592.
I hope that this is helpful. Please (again) forgive me if I am speaking out of
turn.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126240/new/
https://reviews.llvm.org/D126240
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
