[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny updated this revision to Diff 431124. mgorny added a comment. Fix missing `OK` response for c/C/vCont/… packets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125575/new/ https://reviews.llvm.org/D125575 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h lldb/packag

[Lldb-commits] [PATCH] D126109: [lldb] Fix broken bad-address-breakpoint test

hawkinsw created this revision. hawkinsw added reviewers: teemperor, JDevlieghere. Herald added a project: All. hawkinsw requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. After changing the "fallback" behavior when a user sets a breakpoint wi

[Lldb-commits] [PATCH] D126103: Remove `friend` classes from TypeCategoryMap

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126103/new/ https://reviews.llvm.org/D126103 ___

[Lldb-commits] [PATCH] D126103: Remove `friend` classes from TypeCategoryMap

jgorbe created this revision. jgorbe added reviewers: labath, JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. Herald added a project: LLDB. As far as I can tell, the only thing those `friend` classes access is the `ValueSP` typedef. Given that this is a map-is

[Lldb-commits] [lldb] b369762 - Convert the test file for TestIgnoredExceptions.py to the mach_vm API.

Author: Jim Ingham Date: 2022-05-20T15:16:24-07:00 New Revision: b369762beb70dfef22c7e793aed79b94d7dc0757 URL: https://github.com/llvm/llvm-project/commit/b369762beb70dfef22c7e793aed79b94d7dc0757 DIFF: https://github.com/llvm/llvm-project/commit/b369762beb70dfef22c7e793aed79b94d7dc0757.diff LO

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. I realize the reason for the failure. It would appear that there are tests that are otherwise affected by the change in the behavior introduced here. I will take care of updating these tests as quickly as possible. I am sorry for the trouble, @JDevlieghere ! Reposito

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. I am going to investigate why the buildbot failed. When I ran the tests locally everything ran fine. I am terribly, terribly sorry! @JDevlieghere -- If you could help me debug the failure, or point me to the documentation on how to read buildbot output, that would be g

[Lldb-commits] [PATCH] D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput

This revision was automatically updated to reflect the committed changes. Closed by commit rGd252d9231c4a: [lldb] Fix spurious assertion in PrintCommandOutput (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] d252d92 - [lldb] Fix spurious assertion in PrintCommandOutput

Author: Jonas Devlieghere Date: 2022-05-20T14:15:01-07:00 New Revision: d252d9231c4a5008a69c6791db498aaf95bda8e7 URL: https://github.com/llvm/llvm-project/commit/d252d9231c4a5008a69c6791db498aaf95bda8e7 DIFF: https://github.com/llvm/llvm-project/commit/d252d9231c4a5008a69c6791db498aaf95bda8e7.d

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGa3c3482ceb52: [lldb] Consider binary as module of last resort (authored by hawkinsw, committed by JDevlieghere). Reposito

[Lldb-commits] [lldb] a3c3482 - [lldb] Consider binary as module of last resort

Author: Will Hawkins Date: 2022-05-20T14:01:05-07:00 New Revision: a3c3482ceb529206b0ae4e7782e5496da5e0879d URL: https://github.com/llvm/llvm-project/commit/a3c3482ceb529206b0ae4e7782e5496da5e0879d DIFF: https://github.com/llvm/llvm-project/commit/a3c3482ceb529206b0ae4e7782e5496da5e0879d.diff

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. In D124731#3528269 , @JDevlieghere wrote: > Please let me know if you need someone to land this on your behalf. Unfortunately, I do! Sorry! I have not yet completed the committer process. I still feel too new. Thanks for the m

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

aprantl added a comment. > How do we usually add tests for STL data structures? I guess that matrix bot sort of covers this. https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-matrix/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126080/new

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere added a comment. Please let me know if you need someone to land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 ___ lldb-commi

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/dwp.s:22-23 # SYMBOLS-NEXT: Block{{.*}}, ranges = [0x-0x0001) -# SYMBOLS-NEXT: Variable{{.*}}, name = "x", {{.*}}, location = -# SYMBOLS-NEXT: DW_LLE_startx_length (0x

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu updated this revision to Diff 431022. zequanwu marked 3 inline comments as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125509/new/ https://reviews.llvm.org/D125509 Files: lldb/include/

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126080/new/ https://reviews.llvm.org/D126080 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

aprantl added a comment. That seemed to have done the trick. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126080/new/ https://reviews.llvm.org/D126080 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D126081: [lldb] Fix spurious lldb_assert in PrintCommandOutput

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, mib. Herald added a project: All. JDevlieghere requested review of this revision. When the string passed to PrintCommandOutput doesn't end with a newline, `writte`n will exceed `size` and result in an lldbassert

[Lldb-commits] [lldb] 9385a6d - Add some diagnostics to diagnose bot-only failures for TestIgnoredExceptions.py

Author: Jim Ingham Date: 2022-05-20T11:38:37-07:00 New Revision: 9385a6d6eaa3f4caebdee2eb53b5bf4ca1f1b832 URL: https://github.com/llvm/llvm-project/commit/9385a6d6eaa3f4caebdee2eb53b5bf4ca1f1b832 DIFF: https://github.com/llvm/llvm-project/commit/9385a6d6eaa3f4caebdee2eb53b5bf4ca1f1b832.diff LO

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf4570ce442b4: Adapt C++ std::string dataformatter for D125496 (authored by aprantl). Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] f4570ce - Adapt C++ std::string dataformatter for D125496

Author: Adrian Prantl Date: 2022-05-20T11:25:42-07:00 New Revision: f4570ce442b492d436a0e314c6ea14bf299af0d3 URL: https://github.com/llvm/llvm-project/commit/f4570ce442b492d436a0e314c6ea14bf299af0d3 DIFF: https://github.com/llvm/llvm-project/commit/f4570ce442b492d436a0e314c6ea14bf299af0d3.diff

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

aprantl added a comment. I'm going to land this quickly to get the bots going again, but a thorough review would still be very much appreciated! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126080/new/ https://reviews.llvm.org/D126080 ___ l

[Lldb-commits] [PATCH] D126080: Adapt C++ std::string dataformatter for D125496

aprantl created this revision. aprantl added reviewers: ldionne, shafik, jingham. aprantl added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. aprantl requested review of this revision. https://reviews.llvm.org/D125496 changed the layout of std::string witho

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan updated this revision to Diff 431008. yinghuitan added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126013/new/ https://reviews.llvm.org/D126013 Files: lldb/test/API/tools/lldb-vscode/optimized/Make

[Lldb-commits] [PATCH] D126078: [lldb] Improve formatting of dlopen error messages (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126078/new/ https://reviews.llvm.org/D126078 ___

[Lldb-commits] [PATCH] D126013: Add [opt] suffix to optimized stack frame in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:762 + } else { +EmplaceSafeString(object, "name", frame.GetFunctionName()); + } clayborg wrote: > We should probably get the function name with "const char *func_name = > fr

[Lldb-commits] [PATCH] D126078: [lldb] Improve formatting of dlopen error messages (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a subscriber: emaste. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ensure there's a space between "utili

[Lldb-commits] [PATCH] D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1cf154dd476: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] a1cf154 - [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)

Author: Jonas Devlieghere Date: 2022-05-20T09:36:58-07:00 New Revision: a1cf154dd476e021a4c7924e49fac85da01cecf8 URL: https://github.com/llvm/llvm-project/commit/a1cf154dd476e021a4c7924e49fac85da01cecf8 DIFF: https://github.com/llvm/llvm-project/commit/a1cf154dd476e021a4c7924e49fac85da01cecf8.d

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

jingham accepted this revision. jingham added a comment. GetPropertyAtIndexAsArg isn't actually documented, so we don't know what the original intent for the return value was. But in almost all the cases where we look up a property using this function, when we use the enum directly we discard

[Lldb-commits] [PATCH] D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, good catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126076/new/ https://reviews.llvm.org/D126076 ___ lldb-commits ma

[Lldb-commits] [PATCH] D126076: [lldb] Set correct register number for cpsr (GENERIC_REGNUM_FLAGS)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Report the correct register number (GENERIC_REGNUM_FLAGS) for cpsr. This fixes TestLldbGdbServer.py on Apple Silicon. https://reviews.llv

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

JDevlieghere accepted this revision. JDevlieghere added a comment. No worries, thank you for your patience. This LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 _

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Passes the test suite on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126057/new/ https://reviews.llvm.org/D126057 __

[Lldb-commits] [lldb] 80c836e - [lldb] Disable scripted_crashlog_json.test on Apple Silicon

Author: Jonas Devlieghere Date: 2022-05-20T08:24:46-07:00 New Revision: 80c836ec557acd8ffb9fd6b3483dc75c4bcf0b11 URL: https://github.com/llvm/llvm-project/commit/80c836ec557acd8ffb9fd6b3483dc75c4bcf0b11 DIFF: https://github.com/llvm/llvm-project/commit/80c836ec557acd8ffb9fd6b3483dc75c4bcf0b11.d

[Lldb-commits] [PATCH] D125575: [lldb] [llgs] Implement non-stop style stop notification packets

mgorny updated this revision to Diff 430968. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125575/new/ https://reviews.llvm.org/D125575 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h lldb/packages/Python/lldbsuite/test/tools/lldb-server/

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

teemperor added a comment. Don't have access to a macOS machine that can run the tests, so maybe someone should give this a spin before landing :) Comment at: lldb/source/Interpreter/OptionValueProperties.cpp:257 const OptionValueArray *array = value->GetAsArray(); - if (a

[Lldb-commits] [PATCH] D126057: [lldb] Fix that empty target.run-args are not actually used when launching process

teemperor created this revision. teemperor added reviewers: JDevlieghere, kastiglione. teemperor added a project: LLDB. Herald added a project: All. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. `GetPropertyAtIndexAsArgs` returns true on success and false on