yinghuitan added inline comments.
================
Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:762
+ } else {
+ EmplaceSafeString(object, "name", frame.GetFunctionName());
+ }
----------------
clayborg wrote:
> We should probably get the function name with "const char *func_name =
> frame.GetFunctionName();" before the entire "if (is_optimized)" and use it
> here, and above
Thanks, seems we have this potential crash in existing code already. I will fix
it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126013/new/
https://reviews.llvm.org/D126013
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
