[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2f3b6020fbf: [NFC] Don't bother with unstripped binary w/ dSYM, don't DebugSymbols twice (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [lldb] d2f3b60 - [NFC] Don't bother with unstripped binary w/ dSYM, don't DebugSymbols twice

Author: Jason Molenda Date: 2022-05-16T15:30:39-07:00 New Revision: d2f3b6020fbfa2dd56ebd03c942acda961c421e2 URL: https://github.com/llvm/llvm-project/commit/d2f3b6020fbfa2dd56ebd03c942acda961c421e2 DIFF: https://github.com/llvm/llvm-project/commit/d2f3b6020fbfa2dd56ebd03c942acda961c421e2.diff

[Lldb-commits] [lldb] 9defb3b - [lldb] Prevent underflow in crashlog.py

Author: Jonas Devlieghere Date: 2022-05-16T15:00:36-07:00 New Revision: 9defb3b4b4a3ab5a95c449471aaa930cf63a7106 URL: https://github.com/llvm/llvm-project/commit/9defb3b4b4a3ab5a95c449471aaa930cf63a7106 DIFF: https://github.com/llvm/llvm-project/commit/9defb3b4b4a3ab5a95c449471aaa930cf63a7106.d

[Lldb-commits] [PATCH] D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG9defb3b4b4a3: [lldb] Prevent underflow in crashlog.py (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125716/new/ https://reviews.llvm.org/D125716 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D125716: [lldb] Prevent Overflow (Underflow) error in crashlog.py

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Avoid a OverflowError when the pc is zero. This can happen for "unknown frames" where the crashlog generator reports a zero pc. We could omit them a

[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125616/new/ https://reviews.llvm.org/D125616 ___

[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

jasonmolenda updated this revision to Diff 429782. jasonmolenda added a comment. Update to address Jonas' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125616/new/ https://reviews.llvm.org/D125616 Files: lldb/source/Plugins/SymbolVendo

[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

jasonmolenda added inline comments. Comment at: lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:154-155 + // Check to see if we have the file on the local filesystem. + if (!module_spec.GetFileSpec().GetPath().empty() && + FileSystem::Instance().Exist

[Lldb-commits] [PATCH] D124499: Rename conflict testcase

yinghuitan abandoned this revision. yinghuitan added a comment. Seems that this is a duplication to Pavel Labath's commit f513b5fc47df5c040a257ab6f4643942828fa610 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D125616: [NFC] two small perf fixes for when using a DebugSymbols DBGShellCommands to find a dSYM

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp:155 + // add the symbol ObjectFile to this Module. + if (dsym_objfile_sp.get() && !module_sp->GetSymbolFileFileSpec()) { +module_sp->SetSymbolFileFileS

[Lldb-commits] [PATCH] D115277: [lldb] Workaround for type-like entities defined in a lexical block

krisb abandoned this revision. krisb added a comment. Herald added a project: All. Abandon for now. Issue on gitlab: https://github.com/llvm/llvm-project/issues/54475 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115277/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D125219: [lldb][NFC] Simplify GenerateOptionUsage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a94e3801dd7: [lldb][NFC] Simplify GenerateOptionUsage (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125219/new/ https://review

[Lldb-commits] [lldb] 4a94e38 - [lldb][NFC] Simplify GenerateOptionUsage

Author: David Spickett Date: 2022-05-16T10:57:34Z New Revision: 4a94e3801dd721c0083c1259d019a1540388d9d3 URL: https://github.com/llvm/llvm-project/commit/4a94e3801dd721c0083c1259d019a1540388d9d3 DIFF: https://github.com/llvm/llvm-project/commit/4a94e3801dd721c0083c1259d019a1540388d9d3.diff LOG

[Lldb-commits] [PATCH] D125218: [lldb][NFC] Make cmd a reference in GenerateOptionUsage

This revision was automatically updated to reflect the committed changes. Closed by commit rGe473e79cd194: [lldb][NFC] Make cmd a reference in GenerateOptionUsage (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125218/new/

[Lldb-commits] [lldb] e473e79 - [lldb][NFC] Make cmd a reference in GenerateOptionUsage

Author: David Spickett Date: 2022-05-16T10:46:56Z New Revision: e473e79cd194d7a74158ff7e8b97076a7f71c511 URL: https://github.com/llvm/llvm-project/commit/e473e79cd194d7a74158ff7e8b97076a7f71c511 DIFF: https://github.com/llvm/llvm-project/commit/e473e79cd194d7a74158ff7e8b97076a7f71c511.diff LOG