[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:1035 + // or if we have a synthetic child provider. We don't want to call + // "v.GetNumChildren()" on all objects as class, struct and union types don't + // need to be completed if they are ne

[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

clayborg created this revision. Herald added a subscriber: arphaman. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Prior to this fix if we have a really large array or collection class, we would end

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace marked 4 inline comments as done. wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:248 // "name": , -// Tracing technology name, e.g. intel-pt, arm-coresight. +// Tracing technology name, e.g. intel-pt, arm-etm. // "descri

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 428511. wallace added a comment. Now the tracedThreads field returned by the GetState request must have the list of all the threads of the process if per-core mode is enabled. This will avoid having to make that field optional. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 428496. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124858/new/ https://reviews.llvm.org/D124858 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Utility/T

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

clayborg accepted this revision. clayborg added a comment. lgtm! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125107/new/ https://reviews.llvm.org/D125107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] 63865e1 - Add the "sent break" message to the "gdb-remote packets" channel

Author: Jim Ingham Date: 2022-05-10T13:28:50-07:00 New Revision: 63865e1fce624422a526f0de603aa87b7dddb49a URL: https://github.com/llvm/llvm-project/commit/63865e1fce624422a526f0de603aa87b7dddb49a DIFF: https://github.com/llvm/llvm-project/commit/63865e1fce624422a526f0de603aa87b7dddb49a.diff LO

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

kastiglione added a comment. @DavidSpickett I might do some follow up work, if so I will add coverage then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.llvm.org/D125154 ___

[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

kastiglione updated this revision to Diff 428481. kastiglione added a comment. add to TestHelp.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125154/new/ https://reviews.llvm.org/D125154 Files: lldb/source/Commands/CommandObjectTarget.cpp ll

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We can't change any public API calls since other tools might link against the existing API, but we can add new variants to the API. Inline fixes have been suggested. =

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

jj10306 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:234 +IntelPTSingleBufferTrace::GetTraceBuffer(size_t offset, size_t size, + bool flush) { std::vector data(size, 0); --

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: clayborg, labath. Herald added a project: All. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This CL allows to use minidump save-core functionality (

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:228-234 + return m_per_thread_process_trace_up->TraceStart(tid); } Error IntelPTCollector::OnThreadDestroyed(lldb::tid_t tid) { - if (IsProcessTracingEnabled() && m_process_tra

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_static-member-anonymous-namespace.s:18 +# static int s; +# int m = 14159265; +# }; siggi-alpheus wrote: > I wonder why I couldn't get the query to work against an initialize