[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3483203 , @clayborg wrote: > If the string pool caches the hash value, we could actually write out the > hash in the cache file to speed up loading. The patch doing that is D124704 (e

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

JDevlieghere added a comment. Could this go in LLDBStandalone.cmake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/ https://reviews.llvm.org/D124314 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] 9c8179f - LocationListLookup test case failing on lldb-arm-ubuntu

Author: Jason Molenda Date: 2022-04-29T15:00:20-07:00 New Revision: 9c8179f9ce10158d6a9f28ec932e2facfde413d8 URL: https://github.com/llvm/llvm-project/commit/9c8179f9ce10158d6a9f28ec932e2facfde413d8 DIFF: https://github.com/llvm/llvm-project/commit/9c8179f9ce10158d6a9f28ec932e2facfde413d8.diff

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

jingham marked 6 inline comments as done. jingham added inline comments. Comment at: lldb/include/lldb/Target/Language.h:225 + // symbol was really B::A::my_function. We want that to be + // a match. But we wouldn't want this to match AnotherB::A::my_function. The + // use

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

jingham updated this revision to Diff 426170. jingham added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124579/new/ https://reviews.llvm.org/D124579 Files: lldb/include/lldb/Target/Language.h lldb/source/C

[Lldb-commits] [PATCH] D124597: Select the correct DWARF location list entry when looking for variable locations

jasonmolenda added a comment. In D124597#3483197 , @clayborg wrote: > I wonder if this will help optimized code debugging at all!? Good catch It came up in a kernel debugging session iirc; it was the case of a function doing a noreturn call, and when yo

[Lldb-commits] [PATCH] D124597: Select the correct DWARF location list entry when looking for variable locations

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e56c4961a10: Decr pc when looking for DWARF loc list entry mid-stack (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D124597?vs=425703&id=426166#toc Repository: rG LLVM

[Lldb-commits] [lldb] 6e56c49 - Decr pc when looking for DWARF loc list entry mid-stack

Author: Jason Molenda Date: 2022-04-29T14:34:06-07:00 New Revision: 6e56c4961a106b8fde69ffcf9f803fe0890722fa URL: https://github.com/llvm/llvm-project/commit/6e56c4961a106b8fde69ffcf9f803fe0890722fa DIFF: https://github.com/llvm/llvm-project/commit/6e56c4961a106b8fde69ffcf9f803fe0890722fa.diff

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/Language.h:225 + // symbol was really B::A::my_function. We want that to be + // a match. But we wouldn't want this

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

clayborg added a comment. In D122974#3482720 , @llunak wrote: > In D122974#3482556 , @labath wrote: > >> Interesting. I don't know if I missed this somewhere, but could explain what >> kind of a map operation can

[Lldb-commits] [PATCH] D124597: Select the correct DWARF location list entry when looking for variable locations

clayborg accepted this revision. clayborg added a comment. I wonder if this will help optimized code debugging at all!? Good catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124597/new/ https://reviews.llvm.org/D124597 _

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a84a8618439: [lldb] Fix initialization of LazyBool/bool variables… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https:

[Lldb-commits] [lldb] 2a84a86 - [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

Author: Martin Storsjö Date: 2022-04-29T21:33:37+03:00 New Revision: 2a84a86184392a7e18a958f36db0b2b3da6ae2bd URL: https://github.com/llvm/llvm-project/commit/2a84a86184392a7e18a958f36db0b2b3da6ae2bd DIFF: https://github.com/llvm/llvm-project/commit/2a84a86184392a7e18a958f36db0b2b3da6ae2bd.diff

[Lldb-commits] [PATCH] D124572: Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

This revision was automatically updated to reflect the committed changes. Closed by commit rG268089b6ac4b: Fix the encoding and decoding of UniqueCStringMap objects when saved to… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 268089b - Fix the encoding and decoding of UniqueCStringMap objects when saved to cache files.

Author: Greg Clayton Date: 2022-04-29T11:31:47-07:00 New Revision: 268089b6ac4bca2c87b272a61d7dcc6ad3e752e4 URL: https://github.com/llvm/llvm-project/commit/268089b6ac4bca2c87b272a61d7dcc6ad3e752e4 DIFF: https://github.com/llvm/llvm-project/commit/268089b6ac4bca2c87b272a61d7dcc6ad3e752e4.diff

[Lldb-commits] [PATCH] D119997: Add a little test for simple breaking on overloaded functions by name

jingham added a comment. Herald added a project: All. This was submitted (dd8490d207d3a1612091abbea04bf660f133a89f ) but I neglected to put the "Differential Revision" tag in the commit message so automation didn't pick that u

[Lldb-commits] [PATCH] D124028: Add some docs on how to use container commands to the python reference doc

This revision was automatically updated to reflect the committed changes. Closed by commit rGaa7470a1b313: Add a paragraph showing how to use container commands. (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D124028?vs=423691&id=426128#toc Repository: rG LLVM Githu

[Lldb-commits] [lldb] aa7470a - Add a paragraph showing how to use container commands.

Author: Jim Ingham Date: 2022-04-29T11:11:52-07:00 New Revision: aa7470a1b31346f3509ba4b831be39fa1d327772 URL: https://github.com/llvm/llvm-project/commit/aa7470a1b31346f3509ba4b831be39fa1d327772 DIFF: https://github.com/llvm/llvm-project/commit/aa7470a1b31346f3509ba4b831be39fa1d327772.diff LO

[Lldb-commits] [PATCH] D124029: Add a mutex to the ThreadPlanStackMap to prevent it getting corrupted

This revision was automatically updated to reflect the committed changes. Closed by commit rGdca2bc408186: Add a mutex to the ThreadPlanStackMap class. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124029/new/ https://reviews.

[Lldb-commits] [lldb] dca2bc4 - Add a mutex to the ThreadPlanStackMap class.

Author: Jim Ingham Date: 2022-04-29T11:07:22-07:00 New Revision: dca2bc408186667346ab3bbb951adab44feba5bd URL: https://github.com/llvm/llvm-project/commit/dca2bc408186667346ab3bbb951adab44feba5bd DIFF: https://github.com/llvm/llvm-project/commit/dca2bc408186667346ab3bbb951adab44feba5bd.diff LO

[Lldb-commits] [PATCH] D124597: Select the correct DWARF location list entry when looking for variable locations

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. The change seems correct. Since the test only requires -01, and the test code is quite straightforward, the test seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D117383: [lldb] Expose std::pair children for unordered_map

jingham added a comment. Herald added a project: All. Sorry for the delay here. This output is definitely nicer than the previous version, so this change is desirable. If you really are switching on unordered_map vrs. unordered_set behavior, can you check the backend ValueObject's type to det

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for these cleanups. In actual fact, the values set for options in the constructor for CommandOptions are never used, only the values in OptionParsingStarted matter. But it's still c

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7abfaa0a815a: [lldb] Define LLDB_VERSION_PATCH correctly (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [lldb] 7abfaa0 - [lldb] Define LLDB_VERSION_PATCH correctly

Author: Dimitry Andric Date: 2022-04-29T19:29:51+02:00 New Revision: 7abfaa0a815a37ef6abd3ad7eb169007bdc36619 URL: https://github.com/llvm/llvm-project/commit/7abfaa0a815a37ef6abd3ad7eb169007bdc36619 DIFF: https://github.com/llvm/llvm-project/commit/7abfaa0a815a37ef6abd3ad7eb169007bdc36619.diff

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Ah, tests for help that I asked for in another review... Excellent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123500/new/ https://reviews

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

dim updated this revision to Diff 426110. dim added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add llvm/utils/gn/secondary/lldb/include/lldb/Version/BUILD.gn while we're here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D123204: [lldb] Fix initialization of LazyBool/bool variables m_overwrite/m_overwrite_lazy. NFCI.

mstorsjo added a comment. Ping @jingham Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123204/new/ https://reviews.llvm.org/D123204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D123502: [lldb][NFC] Refactor printing of short options in help

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks like it will do the job, and this version is definitely easier to read. Were there any tests for the help output? If not, maybe we should add one. Other than that, LGTM. Repository:

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426080. upsj added a comment. improve handling of disabled libedit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cmake lldb/cmake/

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426072. upsj added a comment. revert remaining unnecessary change from initial diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cm

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426071. upsj added a comment. fix broken build without libedit, improve find module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124673/new/ https://reviews.llvm.org/D124673 Files: cmake/Modules/FindLibEdit.cm

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3482556 , @labath wrote: > Interesting. I don't know if I missed this somewhere, but could explain what > kind of a map operation can lldb perform without computing the hash at least > once? All of them :). Computing

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj updated this revision to Diff 426068. upsj added a comment. Herald added a subscriber: JDevlieghere. The previous setup didn't work for clang-query, so I added a CMake IMPORTED target for LibEdit and used it everywhere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Good catch. Seems like there's another reference to this in `llvm/utils/gn/secondary/lldb/include/lldb/Version/BUILD.gn` but otherwise LGTM. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

upsj created this revision. upsj added reviewers: mgorny, MaskRay. Herald added subscribers: StephenFan, hiraditya. Herald added a project: All. upsj requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Currently, LLVM's LineEd

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

labath added a comment. In D122974#3482540 , @llunak wrote: > In D122974#3481852 , @labath wrote: > >> In D122974#3481269 , @llunak wrote: >> >>> But what if I don't want

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

llunak added a comment. In D122974#3481852 , @labath wrote: > In D122974#3481269 , @llunak wrote: > >> But what if I don't want StringMap to compute the hash at all? There's still >> that 10-15% of CPU time spent

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

dim created this revision. dim added reviewers: JDevlieghere, labath. Herald added a project: All. dim requested review of this revision. Herald added a project: LLDB. In commit ccf1469a4cdb lldb got its own generated Version.

[Lldb-commits] [PATCH] D124670:

DavidSpickett added a comment. For https://github.com/llvm/llvm-project/issues/54337. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124670/new/ https://reviews.llvm.org/D124670 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D124670:

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. TODO: This would require packaging (https://github.com/pypa/packaging) to be added as a third party module, i

[Lldb-commits] [lldb] f8463da - [lldb] Allow EXE or exe in toolchain-msvc.test

Author: David Spickett Date: 2022-04-29T12:22:33Z New Revision: f8463da4a329b839cfd01d7f80ae72e18f3c061e URL: https://github.com/llvm/llvm-project/commit/f8463da4a329b839cfd01d7f80ae72e18f3c061e DIFF: https://github.com/llvm/llvm-project/commit/f8463da4a329b839cfd01d7f80ae72e18f3c061e.diff LOG

[Lldb-commits] [lldb] cacaa44 - Reland "[lldb] Use shutil.which in Shell tests find_executable"

Author: David Spickett Date: 2022-04-29T11:25:09Z New Revision: cacaa445c3a3a2551a6e2aef51414e47def9cc06 URL: https://github.com/llvm/llvm-project/commit/cacaa445c3a3a2551a6e2aef51414e47def9cc06 DIFF: https://github.com/llvm/llvm-project/commit/cacaa445c3a3a2551a6e2aef51414e47def9cc06.diff LOG

[Lldb-commits] [lldb] d9247cc - Revert "[lldb] Use shutil.which in Shell tests find_executable"

Author: David Spickett Date: 2022-04-29T11:02:59Z New Revision: d9247cc84825539d346c74eb1379c6cb948d3a71 URL: https://github.com/llvm/llvm-project/commit/d9247cc84825539d346c74eb1379c6cb948d3a71 DIFF: https://github.com/llvm/llvm-project/commit/d9247cc84825539d346c74eb1379c6cb948d3a71.diff LOG

[Lldb-commits] [PATCH] D124604: [lldb] Use shutil.which in Shell tests find_executable

This revision was automatically updated to reflect the committed changes. Closed by commit rG713752610edd: [lldb] Use shutil.which in Shell tests find_executable (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124604/new/

[Lldb-commits] [lldb] 7137526 - [lldb] Use shutil.which in Shell tests find_executable

Author: David Spickett Date: 2022-04-29T10:01:26Z New Revision: 713752610edd3d8766f56e2704bb7241434cd15b URL: https://github.com/llvm/llvm-project/commit/713752610edd3d8766f56e2704bb7241434cd15b DIFF: https://github.com/llvm/llvm-project/commit/713752610edd3d8766f56e2704bb7241434cd15b.diff LOG

[Lldb-commits] [PATCH] D124601: [lldb] Use shutil.which instead of distutils find_executable

This revision was automatically updated to reflect the committed changes. Closed by commit rG14869bd2dfab: [lldb] Use shutil.which instead of distutils find_executable (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124601/

[Lldb-commits] [lldb] 14869bd - [lldb] Use shutil.which instead of distutils find_executable

Author: David Spickett Date: 2022-04-29T08:41:34Z New Revision: 14869bd2dfabb7a808e57e17dd45eef7665dd737 URL: https://github.com/llvm/llvm-project/commit/14869bd2dfabb7a808e57e17dd45eef7665dd737 DIFF: https://github.com/llvm/llvm-project/commit/14869bd2dfabb7a808e57e17dd45eef7665dd737.diff LOG

[Lldb-commits] [PATCH] D123954: [lldb] Add setting for max depth of value object printing (NFC)

DavidSpickett accepted this revision. DavidSpickett added a comment. All my comments were addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123954/new/ https://reviews.llvm.org/D123954 ___ lldb-co

[Lldb-commits] [PATCH] D122974: prevent ConstString from calling djbHash() more than once

labath added a comment. In D122974#3481269 , @llunak wrote: > In D122974#3480686 , @dblaikie > wrote: > >> In D122974#3424654 , @JDevlieghere >> wrote: >> >>> > > ... >