clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed.
================ Comment at: lldb/include/lldb/Target/Language.h:225 + // symbol was really B::A::my_function. We want that to be + // a match. But we wouldn't want this to match AnotherB::A::my_function. The + // user is specifying a truncated path, not a truncated set of characters. ---------------- The comment should be adding something extra to "A" right? See suggested code change ================ Comment at: lldb/source/Core/Module.cpp:753-754 + llvm::StringRef full_name = sc.GetFunctionName().GetStringRef(); + if (full_name.empty() && sc.symbol) + full_name = sc.symbol->GetName().GetStringRef(); + // We always keep unnamed symbols: ---------------- Remove this, SymbolContext::GetFunctionName() already returns the symbol name if there is no block with inlined function name or concrete function name. ================ Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:330-359 +// size_t from = 0; +// llvm::StringRef demangled_ref = demangled.GetStringRef(); +// size_t dem_len = demangled_ref.size(); +// size_t path_len = path.size(); +// +// // The path string might appear more than once in the demangled string. A +// // silly example is: ---------------- shafik wrote: > dead code? delete commented out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124579/new/ https://reviews.llvm.org/D124579 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
