[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1635 + +def __fetch_events__(self): +event = lldb.SBEvent() This contains way too

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

mib updated this revision to Diff 416396. mib added a comment. Reformat CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121977/new/ https://reviews.llvm.org/D121977 Files: lldb/packages/Python/lldbsuite/test/lldbutil.py lldb/test/API/functionalities/progress_reporting/TestProgressRep

[Lldb-commits] [PATCH] D121977: [lldb/test] Add progress events listener helper class to lldbutil

mib created this revision. mib added reviewers: labath, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a generic helper class that will listen for progress event in a backgr

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. Pretty nice improvement! Now you need to reference this doc from the main page. See this reference patch https://reviews.llvm.org/D82064. According to it, you need to move this doc

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

ldionne accepted this revision. ldionne added a comment. LGTM, thanks for fixing the documentation quirks in libc++/libunwind! And sorry this went under my Radar last week :-). @tonic Is this OK with you? I don't want to override your "request for changes" by committing this. Repository: rG

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

shafik added a comment. In D121831#3390152 , @aprantl wrote: > Did you check if we have other helper expressions with the same problem? Yes, I could not find any other instances like this. They are not straight forward to find but I think I found all th

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. I will remove ondemand test flavor/category and add more new testcases next. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lld

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu created this revision. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This creates inline functions decls in the TUs where the funcitons are inlined. Repository: rG LLVM Github Monorepo h

[Lldb-commits] [lldb] 74b45f9 - [lldb] Migrate ProcessGDBRemote to ReportWarning

Author: Jonas Devlieghere Date: 2022-03-17T15:13:48-07:00 New Revision: 74b45f91b8bf7231f76c5676c4bedc9a667012e8 URL: https://github.com/llvm/llvm-project/commit/74b45f91b8bf7231f76c5676c4bedc9a667012e8 DIFF: https://github.com/llvm/llvm-project/commit/74b45f91b8bf7231f76c5676c4bedc9a667012e8.d

[Lldb-commits] [PATCH] D120948: Disable LLDB index cache for .o files with no UUID.

clayborg updated this revision to Diff 416334. clayborg added a comment. Address operator == inline suggestion for CacheSignature Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120948/new/ https://reviews.llvm.org/D120948 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan updated this revision to Diff 416333. yinghuitan marked 4 inline comments as done. yinghuitan added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 Files:

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked 19 inline comments as done. yinghuitan added inline comments. Comment at: lldb/source/Symbol/SymbolFileOnDemand.cpp:28 + +uint32_t SymbolFileOnDemand::CalculateAbilities() { + if (!this->m_debug_info_enabled) { clayborg wrote: > We might consid

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn updated this revision to Diff 416287. zrthxn added a comment. Switched to RST Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121935/new/ https://reviews.llvm.org/D121935 Files: lldb/docs/intel_pt.rst Index: lldb/docs/intel_pt.rst

[Lldb-commits] [PATCH] D121942: Switched to RST

zrthxn created this revision. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121942 Files: lldb/docs/intel_pt.rst lldb/source/Plugins

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

aprantl added a comment. Did you check if we have other helper expressions with the same problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121831/new/ https://reviews.llvm.org/D121831 ___ lldb-commi

[Lldb-commits] [lldb] f93d861 - [lldb] Fix ^C handling in IOHandlerProcessSTDIO

Author: Pavel Labath Date: 2022-03-17T11:52:19-07:00 New Revision: f93d861349f923f6b7ca1a425d3632eec1ff2a72 URL: https://github.com/llvm/llvm-project/commit/f93d861349f923f6b7ca1a425d3632eec1ff2a72 DIFF: https://github.com/llvm/llvm-project/commit/f93d861349f923f6b7ca1a425d3632eec1ff2a72.diff

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf93d861349f9: [lldb] Fix ^C handling in IOHandlerProcessSTDIO (authored by labath, committed by JDevlieghere). Changed prior to commit: https://re

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added a comment. Re @labath > How many tests/bugs are we talking about here? Were there more than say ten > distinct bugs caught there? It found 2~3 bugs, like source regex breakpoint (breakpoint set -p "source"), regex breakpoint filter by language (breakpoint set -r -L c++) etc.

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

wallace requested changes to this revision. wallace added a comment. Thank you very much for helping out with the documentaiton! As Jonas said, move the file to lldb/docs/intel_pt.rst and modify the necessary bits (some CMake changes) so that the documentation eventually appears in https://lldb

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn added a comment. In D121935#3389954 , @JDevlieghere wrote: > Can we include this in the `docs` folder instead? Having READMEs spread > throughout the sources isn't going to be particularly discoverable. Sure can. Should I also use RST instead of

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Can we include this in the `docs` folder instead? Having READMEs spread throughout the sources isn't going to be particularly discoverable. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D121935: added intel-pt build instructions for lldb

zrthxn created this revision. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121935 Files: lldb/source/Plugins/Trace/intel-pt/README.md

[Lldb-commits] [PATCH] D121900: [lldb] Add more documentation on test variants

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121900/new/ https://reviews.llvm.org/D121900 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D121831: Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33d74170a36e: [LLDB] Modifying expression code in MakeLoadImageUtilityFunction to be more… (authored by shafik). Herald added a project: LLDB. Repos

[Lldb-commits] [lldb] 33d7417 - [LLDB] Modifying expression code in MakeLoadImageUtilityFunction to be more consistent

Author: Shafik Yaghmour Date: 2022-03-17T08:52:56-07:00 New Revision: 33d74170a36e3b801e93152effa59f19d9abb3a0 URL: https://github.com/llvm/llvm-project/commit/33d74170a36e3b801e93152effa59f19d9abb3a0 DIFF: https://github.com/llvm/llvm-project/commit/33d74170a36e3b801e93152effa59f19d9abb3a0.dif

[Lldb-commits] [lldb] 7ed1abd - [lldb] Skip invalid-condition.test on Windows

Author: Jonas Devlieghere Date: 2022-03-17T08:34:12-07:00 New Revision: 7ed1abd4a6c1fd506423723932ca7dc70efc5a99 URL: https://github.com/llvm/llvm-project/commit/7ed1abd4a6c1fd506423723932ca7dc70efc5a99 DIFF: https://github.com/llvm/llvm-project/commit/7ed1abd4a6c1fd506423723932ca7dc70efc5a99.d

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121912/new/ https://reviews.llvm.org/D121912

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

DavidSpickett added a comment. I also found this in the process of looking at https://github.com/llvm/llvm-project/issues/53673 (different issue same area). Bisected it to the same change you got, and this fixes things for me too. Do you know if the pexpect test will cleanup the debugee process

[Lldb-commits] [PATCH] D121912: [lldb] Fix ^C handling in IOHandlerProcessSTDIO

labath created this revision. labath added a reviewer: JDevlieghere. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. D120762 accidentally moved the interrupt check into the block which was reading stdio. This

[Lldb-commits] [PATCH] D121900: [lldb] Add more documentation on test variants

labath created this revision. labath added reviewers: JDevlieghere, clayborg, jingham. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. This formalizes some of the discussion on D121631 . Repository: rG LLVM

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

labath added a comment. (Please run clang-format before submitting) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121844/new/ https://reviews.llvm.org/D121844 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

labath accepted this revision. labath added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList &ValueList::operator=(const ValueList &rhs) { +const ValueList &ValueList::operator=(const ValueList &rhs) { // NOLINT(modernize-use-equals-default) m_v