labath accepted this revision.
labath added inline comments.
================
Comment at: lldb/source/Core/Value.cpp:667
-const ValueList &ValueList::operator=(const ValueList &rhs) {
+const ValueList &ValueList::operator=(const ValueList &rhs) { //
NOLINT(modernize-use-equals-default)
m_values = rhs.m_values;
----------------
shafik wrote:
> I have to look into why we return a `const &` here. We do this in a few other
> places too.
I don't think there's a good reason for that. Most people aren't aware that
built-in assignment operators return lvalues. And some of the people who are
aware of that think that it's a bad idea, so they make sure their operators
don't do it...
================
Comment at: lldb/source/Host/macosx/cfcpp/CFCMutableArray.cpp:18
CFCMutableArray::CFCMutableArray(const CFCMutableArray &rhs)
- : CFCReleaser<CFMutableArrayRef>(rhs) // NOTE: this won't make a copy of
the
+ : CFCReleaser<CFMutableArrayRef>(rhs) //
NOLINT(modernize-use-equals-default)
+ // NOTE: this won't make a copy of
the
----------------
Why suppress this?
================
Comment at: lldb/source/Target/ExecutionContext.cpp:416
ExecutionContextRef::ExecutionContextRef(const ExecutionContextRef &rhs)
- : m_target_wp(rhs.m_target_wp), m_process_wp(rhs.m_process_wp),
- m_thread_wp(rhs.m_thread_wp), m_tid(rhs.m_tid),
- m_stack_id(rhs.m_stack_id) {}
+
+ = default;
----------------
You may need to manually delete this line to get sensible clang-formatting.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121844/new/
https://reviews.llvm.org/D121844
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
