[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/debug_loc.s:28-29 # CHECK: Variable{{.*}}, name = "x0", {{.*}}, scope = parameter, location = # CHECK-NEXT: [0x, 0x0001): DW_OP_reg5 RDI # CHECK-NEXT: [0x

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3b9bb5a1847: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] e3b9bb5 - [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

Author: Med Ismail Bennani Date: 2022-02-18T14:16:09-08:00 New Revision: e3b9bb5a1847483338190c82ee63a962e82696fd URL: https://github.com/llvm/llvm-project/commit/e3b9bb5a1847483338190c82ee63a962e82696fd DIFF: https://github.com/llvm/llvm-project/commit/e3b9bb5a1847483338190c82ee63a962e82696fd.

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120100/new/ https://reviews.llvm.org/D120100 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D120100: [lldb/bindings] Expose the progress reporting machinery to the SWIG interface

mib updated this revision to Diff 410023. mib retitled this revision from "[lldb] Expose eBroadcastBitProgress to the SWIG SBAPI" to "[lldb/bindings] Expose the progress reporting machinery to the SWIG interface". mib edited the summary of this revision. mib added a comment. Instead of moving th

[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI

JDevlieghere added a comment. In D120100#3331656 , @labath wrote: > I'm not sure how we ended up with the .i files in the first place, but maybe > a good solution to this problem would be to ditch those and generate bindings > from .h files directly. >

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

JDevlieghere updated this revision to Diff 409963. JDevlieghere added a comment. Use Pavel's //not-as-cool// solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120101/new/ https://reviews.llvm.org/D120101 Files: lldb/source/Commands/CommandObjectRegexCommand.cpp lldb/source/Co

[Lldb-commits] [lldb] e4a03b2 - [lldb] Default initialize CommandOptions fields (NFC)

Author: Jonas Devlieghere Date: 2022-02-18T09:07:25-08:00 New Revision: e4a03b26898e9ca5917a425fc4b089bf5ba19272 URL: https://github.com/llvm/llvm-project/commit/e4a03b26898e9ca5917a425fc4b089bf5ba19272 DIFF: https://github.com/llvm/llvm-project/commit/e4a03b26898e9ca5917a425fc4b089bf5ba19272.d

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham added a comment. Yes, that looks great. Thanks for persisting! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119548/new/ https://reviews.llvm.org/D119548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D119737: [lldb] Add llvm_unreachable in RichManglingContext

This revision was automatically updated to reflect the committed changes. Closed by commit rGf20f9f5a32c0: [lldb] Add llvm_unreachable in RichManglingContext (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119737/new/ https:

[Lldb-commits] [lldb] f20f9f5 - [lldb] Add llvm_unreachable in RichManglingContext

Author: Dave Lee Date: 2022-02-18T08:38:03-08:00 New Revision: f20f9f5a32c02e7df3fc9a9d48643471dc6d41a5 URL: https://github.com/llvm/llvm-project/commit/f20f9f5a32c02e7df3fc9a9d48643471dc6d41a5 DIFF: https://github.com/llvm/llvm-project/commit/f20f9f5a32c02e7df3fc9a9d48643471dc6d41a5.diff LOG:

[Lldb-commits] [PATCH] D119831: [lldb] Add support for a "global" lldbinit file

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c99a3469d9c: [lldb] Add support for a "global" lldbinit file (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119831/new/ https://review

[Lldb-commits] [lldb] 6c99a34 - [lldb] Add support for a "global" lldbinit file

Author: Pavel Labath Date: 2022-02-18T12:30:22+01:00 New Revision: 6c99a3469d9c0a48fb2a9fec845d284ef39338ee URL: https://github.com/llvm/llvm-project/commit/6c99a3469d9c0a48fb2a9fec845d284ef39338ee DIFF: https://github.com/llvm/llvm-project/commit/6c99a3469d9c0a48fb2a9fec845d284ef39338ee.diff

[Lldb-commits] [lldb] a59014b - Revert "Fix race condition when launching and attaching."

Author: Pavel Labath Date: 2022-02-18T12:11:37+01:00 New Revision: a59014b759050af93e0ab214dcbf0cc2dd75bb75 URL: https://github.com/llvm/llvm-project/commit/a59014b759050af93e0ab214dcbf0cc2dd75bb75 DIFF: https://github.com/llvm/llvm-project/commit/a59014b759050af93e0ab214dcbf0cc2dd75bb75.diff

[Lldb-commits] [PATCH] D120100: [lldb] Expose eBroadcastBitProgress to the SWIG SBAPI

labath added a comment. I'm not sure how we ended up with the .i files in the first place, but maybe a good solution to this problem would be to ditch those and generate bindings from .h files directly. It may mean that we need to put `#ifndef SWIG` around some code, but I'd say that beats mai

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

labath added a comment. In D119963#3329973 , @jingham wrote: > There was a question on the dev list a while ago about to print out all the > valid ranges of a variable. That's a useful bit of info if you're trying to > figure out where you could break

[Lldb-commits] [PATCH] D111634: [lldb] Print embedded nuls in char arrays (PR44649)

labath added a comment. Yeah, I suppose that makes sense. Like, I don't think we can ever have a single solution that does exactly what people would expect in every possible situation. The only counterargument I can think of is "but gdb does it that way", but I don't think that's a particularly

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. In D119548#3330773 , @ilya-nozhkin wrote: > In D119548#3330226 , @clayborg > wrote: > >> Try out the https://reviews.llvm.org/D119797 patch and see if this fixes >> this issue? I have ju

[Lldb-commits] [PATCH] D120101: [lldb] Fix (unintentional) recursion in CommandObjectRegexCommand

labath added a comment. Wouldn't want to miss a good bikeshed. Logarithms are cool, but I think something like this (untested) snippet would be simpler Input.split(Parts, '%'); Result << Parts[0]; for (llvm::StringRef Part : drop_begin(Parts)) { if (!Part.consumeInteger(10, Idx) && Idx

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

labath added a comment. There's also a timeout in TestVSCode_coreFile.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119797/new/ https://reviews.llvm.org/D119797 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

labath added a comment. TestVSCode_attach.py is still failing. Are you able to fix that quickly or shall we revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119797/new/ https://review

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

clayborg added a comment. Fixed buildbots with: commit 38054556a08884aa15d3ebc720e2f43d0cb5a944 (HEAD -> main, origin/main, origin/HEAD) Author: Greg Clayton Date: Thu Feb 17 23:59:15 2022 -0800 Fix buildbots after https://reviews.llvm.org/D119797 This value error

[Lldb-commits] [lldb] 3805455 - Fix buildbots after https://reviews.llvm.org/D119797

Author: Greg Clayton Date: 2022-02-17T23:59:15-08:00 New Revision: 38054556a08884aa15d3ebc720e2f43d0cb5a944 URL: https://github.com/llvm/llvm-project/commit/38054556a08884aa15d3ebc720e2f43d0cb5a944 DIFF: https://github.com/llvm/llvm-project/commit/38054556a08884aa15d3ebc720e2f43d0cb5a944.diff