[Lldb-commits] [lldb] 0f29319 - [lldb] Determine the main binary in JSON crashlogs

Author: Jonas Devlieghere Date: 2022-02-14T21:24:02-08:00 New Revision: 0f29319e56459eb26a3bf7fb86e45e63f43a168e URL: https://github.com/llvm/llvm-project/commit/0f29319e56459eb26a3bf7fb86e45e63f43a168e DIFF: https://github.com/llvm/llvm-project/commit/0f29319e56459eb26a3bf7fb86e45e63f43a168e.d

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

ilya-nozhkin added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:9 +#include #include Incompatible with MSVC. Maybe use std::chrono instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11979

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin added a comment. In D119548#3321452 , @clayborg wrote: > Can anyone try out the following patch and see if this stops the race > condition > > https://reviews.llvm.org/D119797 > > It might solve the problem. Yeah, now the test passes and VS

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham added a comment. In D119548#3321397 , @ilya-nozhkin wrote: > In D119548#3321357 , @jingham wrote: > >> SBTarget.Launch calls Target::Launch. That sets up a hijacker for the "stop >> at the first instruc

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

clayborg added a comment. Can anyone try out the following patch and see if this stops the race condition https://reviews.llvm.org/D119797 It might solve the problem. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119548/new/ https://reviews.llvm.org/D119548 __

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace, ilya-nozhkin. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We discovered that when using "launchCommands" or "attachComman

[Lldb-commits] [lldb] 0e0e381 - This test seems to pass on Linux, remove the x-fail.

Author: Jim Ingham Date: 2022-02-14T16:58:57-08:00 New Revision: 0e0e381a1547c641a54b2131665d8a38855371b4 URL: https://github.com/llvm/llvm-project/commit/0e0e381a1547c641a54b2131665d8a38855371b4 DIFF: https://github.com/llvm/llvm-project/commit/0e0e381a1547c641a54b2131665d8a38855371b4.diff LO

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin added a comment. In D119548#3321376 , @clayborg wrote: > FYI: I have a patch coming up that will add the ability to not have to play > with the async mode when launching or attaching. I will try and post that > diff here, it should be up to

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin added a comment. In D119548#3321357 , @jingham wrote: > SBTarget.Launch calls Target::Launch. That sets up a hijacker for the "stop > at the first instruction" event regardless of the Sync mode. The problem that it sets up this hijacker to

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

clayborg added a comment. FYI: I have a patch coming up that will add the ability to not have to play with the async mode when launching or attaching. I will try and post that diff here, it should be up today. We were running into a race condition when we used "launchCommands" or "attachComman

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Note, however, that if you are doing a Synchronous launch, you won't ever get an event telling you the process has stopped. Maybe that's what is causing the actual confusion? If

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

jingham added a comment. I'm a little confused by the analysis so far. SBTarget.Launch calls Target::Launch. That sets up a hijacker for the "stop at the first instruction" event regardless of the Sync mode. Once that succeeds, if the Debugger is set for Synchronous execution Target::Launch

[Lldb-commits] [PATCH] D119297: "thread until": make sure the current function is valid before asking it questions

This revision was automatically updated to reflect the committed changes. Closed by commit rG793924dd5f2a: Fix an incorrect assumption in "thread until": code with debug info is not… (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D119297?vs=406995&id=408660#toc Reposi

[Lldb-commits] [lldb] 793924d - Fix an incorrect assumption in "thread until": code with debug info is not always in a function.

Author: Jim Ingham Date: 2022-02-14T15:53:24-08:00 New Revision: 793924dd5f2ad0663f77a09f09d11adaa4ce2b91 URL: https://github.com/llvm/llvm-project/commit/793924dd5f2ad0663f77a09f09d11adaa4ce2b91 DIFF: https://github.com/llvm/llvm-project/commit/793924dd5f2ad0663f77a09f09d11adaa4ce2b91.diff LO

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

This revision was automatically updated to reflect the committed changes. Closed by commit rG635f03fe976e: Add a repeat command option for "thread backtrace --count N". (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119046/new/

[Lldb-commits] [lldb] 635f03f - Add a repeat command option for "thread backtrace --count N".

Author: Jim Ingham Date: 2022-02-14T15:48:06-08:00 New Revision: 635f03fe976e250cc64999663f47716412dfa029 URL: https://github.com/llvm/llvm-project/commit/635f03fe976e250cc64999663f47716412dfa029 DIFF: https://github.com/llvm/llvm-project/commit/635f03fe976e250cc64999663f47716412dfa029.diff LO

[Lldb-commits] [PATCH] D119755: [crashlog] Change heuristic to stripping the meta data from crashlogs

This revision was automatically updated to reflect the committed changes. Closed by commit rG343662a02878: [crashlog] Change heuristic to stripping the meta data from crashlogs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D119756: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog

This revision was automatically updated to reflect the committed changes. Closed by commit rGd52866e1a82d: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] d52866e - [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog

Author: Jonas Devlieghere Date: 2022-02-14T12:18:12-08:00 New Revision: d52866e1a82dab57ad1b58a8bf21ca63eae2e155 URL: https://github.com/llvm/llvm-project/commit/d52866e1a82dab57ad1b58a8bf21ca63eae2e155 DIFF: https://github.com/llvm/llvm-project/commit/d52866e1a82dab57ad1b58a8bf21ca63eae2e155.d

[Lldb-commits] [lldb] 343662a - [crashlog] Change heuristic to stripping the meta data from crashlogs

Author: Jonas Devlieghere Date: 2022-02-14T12:18:12-08:00 New Revision: 343662a0287845eceba068df6ce59eddcbe7beb1 URL: https://github.com/llvm/llvm-project/commit/343662a0287845eceba068df6ce59eddcbe7beb1 DIFF: https://github.com/llvm/llvm-project/commit/343662a0287845eceba068df6ce59eddcbe7beb1.d

[Lldb-commits] [PATCH] D119756: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119756/new/ https://reviews.llvm.org/D119756 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D119755: [crashlog] Change heuristic to stripping the meta data from crashlogs

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119755/new/ https://reviews.llvm.org/D119755 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D119756: [lldb] Stop forwarding LLDB_DEFAULT_PYTHON_VERSION in crashlog

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. JDevlieghere requested review of this revision. Title says it all https://reviews.llvm.org/D119756 Files: lldb/examples/python/crashlog.py Index: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D119755: [crashlog] Change heuristic to stripping the meta data from crashlogs

JDevlieghere created this revision. JDevlieghere added a reviewer: mib. JDevlieghere requested review of this revision. Instead of pro-actively trying to determine if the first line in a crashlog contains meta data, change the heuristic to trying to parse the whole file first. If that fails, str

[Lldb-commits] [PATCH] D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a394367c124: Alt mechanism to find the first loadable seg in a Mach-O binary (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11960

[Lldb-commits] [lldb] 4a39436 - Alt mechanism to find the first loadable seg in a Mach-O binary

Author: Jason Molenda Date: 2022-02-14T11:12:58-08:00 New Revision: 4a394367c124172dff26ef5042ecd6fa666a6e07 URL: https://github.com/llvm/llvm-project/commit/4a394367c124172dff26ef5042ecd6fa666a6e07 DIFF: https://github.com/llvm/llvm-project/commit/4a394367c124172dff26ef5042ecd6fa666a6e07.diff

[Lldb-commits] [lldb] d0fb3ea - [lldb] Fix use-after-move in SymbolFile/NativePDB

Author: Fangrui Song Date: 2022-02-14T11:03:26-08:00 New Revision: d0fb3eab74aaa357037fd2632f912e71222c5586 URL: https://github.com/llvm/llvm-project/commit/d0fb3eab74aaa357037fd2632f912e71222c5586 DIFF: https://github.com/llvm/llvm-project/commit/d0fb3eab74aaa357037fd2632f912e71222c5586.diff

[Lldb-commits] [lldb] 7ec32da - [lldb] Enable test for `getelementptr` const args for Windows

Author: Andy Yankovsky Date: 2022-02-14T18:48:51Z New Revision: 7ec32dad2b01ffcd47b7f99f5ebba9130ab9e00b URL: https://github.com/llvm/llvm-project/commit/7ec32dad2b01ffcd47b7f99f5ebba9130ab9e00b DIFF: https://github.com/llvm/llvm-project/commit/7ec32dad2b01ffcd47b7f99f5ebba9130ab9e00b.diff LOG

[Lldb-commits] [PATCH] D119737: [lldb] Add llvm_unreachable in RichManglingContext

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119737/new/ https://reviews.llvm.org/D119737 ___

[Lldb-commits] [PATCH] D119737: [lldb] Add llvm_unreachable in RichManglingContext

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `llvm_unreachable` to prevent warnings/errors in gcc and msvc. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D119723: Cleanup LLVMDWARFDebugInfo

ayermolo added a comment. bolt part looks fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119723/new/ https://reviews.llvm.org/D119723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D119734: [lldb] Add a positive test for `getelementptr` constant args

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e0ef179d883: [lldb] Add a positive test for `getelementptr` constant args (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119734/new/ ht

[Lldb-commits] [lldb] 2e0ef17 - [lldb] Add a positive test for `getelementptr` constant args

Author: Andy Yankovsky Date: 2022-02-14T18:04:37Z New Revision: 2e0ef179d8838de06bf694ae6ca43c2b24847a8c URL: https://github.com/llvm/llvm-project/commit/2e0ef179d8838de06bf694ae6ca43c2b24847a8c DIFF: https://github.com/llvm/llvm-project/commit/2e0ef179d8838de06bf694ae6ca43c2b24847a8c.diff LOG

[Lldb-commits] [PATCH] D119602: Add additional method for ObjectFileMachO to find the first loadable segment in a Mach-O binary

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119602/new/ https://reviews.llvm.org/D119602 ___

[Lldb-commits] [lldb] 27166e9 - [lldb] Skip TestIOHandlerPythonREPLSigint if *host* is linux

Author: Jonas Devlieghere Date: 2022-02-14T09:38:07-08:00 New Revision: 27166e95e70254e292c31a2aa16582a56b787c42 URL: https://github.com/llvm/llvm-project/commit/27166e95e70254e292c31a2aa16582a56b787c42 DIFF: https://github.com/llvm/llvm-project/commit/27166e95e70254e292c31a2aa16582a56b787c42.d

[Lldb-commits] [PATCH] D119734: [lldb] Add a positive test for `getelementptr` constant args

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Thank you! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119734/new/ https://reviews.llvm.org/D119734

[Lldb-commits] [lldb] 00cd6c0 - [Preprocessor] Reduce the memory overhead of `#define` directives (Recommit)

Author: Alex Lorenz Date: 2022-02-14T09:27:44-08:00 New Revision: 00cd6c04202acf71f74c670b2dd4343929d1f45f URL: https://github.com/llvm/llvm-project/commit/00cd6c04202acf71f74c670b2dd4343929d1f45f DIFF: https://github.com/llvm/llvm-project/commit/00cd6c04202acf71f74c670b2dd4343929d1f45f.diff L

[Lldb-commits] [PATCH] D119734: [lldb] Add a positive test for `getelementptr` constant args

werat created this revision. werat added a reviewer: shafik. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The IR interpreter supports const operands to the `GetElementPtr` IR instruction, so it should be able to evaluate expression

[Lldb-commits] [PATCH] D119616: [lldb] Replace asserts on .Success() with assertSuccess()

This revision was automatically updated to reflect the committed changes. Closed by commit rG779bbbf27fe6: [lldb] Replace asserts on .Success() with assertSuccess() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119616/new/

[Lldb-commits] [lldb] 779bbbf - [lldb] Replace asserts on .Success() with assertSuccess()

Author: Dave Lee Date: 2022-02-14T08:31:17-08:00 New Revision: 779bbbf27fe631154bdfaac7a443f198d4654688 URL: https://github.com/llvm/llvm-project/commit/779bbbf27fe631154bdfaac7a443f198d4654688 DIFF: https://github.com/llvm/llvm-project/commit/779bbbf27fe631154bdfaac7a443f198d4654688.diff LOG:

[Lldb-commits] [PATCH] D119616: [lldb] Replace asserts on .Success() with assertSuccess()

kastiglione added a comment. > That's probably because it was introduced only recently Thanks for adding it! I just learned about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119616/new/ https://reviews.llvm.org/D119616 _

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin added a comment. In D119548#3318995 , @labath wrote: > I think that could be achieved by "hijacking" the process events in the case > of a synchronous launch, similar to how we do it for synchronous resumes > (compare Process::Resume and Pr

[Lldb-commits] [PATCH] D119723: Cleanup LLVMDWARFDebugInfo

serge-sans-paille created this revision. serge-sans-paille added reviewers: RKSimon, MaskRay, mehdi_amini, lenary. Herald added subscribers: ayermolo, cmtice, rupprecht, arphaman, hiraditya. Herald added a reviewer: jhenderson. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Heral

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin updated this revision to Diff 408401. ilya-nozhkin added a comment. Moved the body of this giant lambda to a separate method. Also, renamed the locking method because "do with locked synchronization" looks like the synchronized mode will be locked. "Do with locked synchronicity" look

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. Ah, I'm sorry. It seems I misunderstood the nature of the problem. Let me try again. In your description of the problem, I think the problematic part is the sequencing of steps 5 and 6. You're saying that the main thread returns from a "synchronous" launch operation eve

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

ilya-nozhkin added a comment. In D119548#3318806 , @labath wrote: > it still seems like there is a zillion of other things that the two processes > (event handler thread and stop hook executor) race on. Stop hooks are executed in the event handler threa

[Lldb-commits] [PATCH] D119548: [lldb] Fix race condition between lldb-vscode and stop hooks executor

labath added a comment. I'm not sure this is fixing the problem at the right level. I mean, even if you fix the race on the synchronicity flag, it still seems like there is a zillion of other things that the two processes (event handler thread and stop hook executor) race on. Isn't the right f

[Lldb-commits] [PATCH] D119616: [lldb] Replace asserts on .Success() with assertSuccess()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Thanks for doing this. > assertSuccess seems not to be well known That's probably because it was introduced only recently (for all the reasons that you mention). Repository: rG LLVM Githu

[Lldb-commits] [lldb] ad1feef - [lldb] Remove some uses of getPointerElementType()

Author: Nikita Popov Date: 2022-02-14T09:44:37+01:00 New Revision: ad1feef7b2097090df0d41ad4c35c688dbe1c34a URL: https://github.com/llvm/llvm-project/commit/ad1feef7b2097090df0d41ad4c35c688dbe1c34a DIFF: https://github.com/llvm/llvm-project/commit/ad1feef7b2097090df0d41ad4c35c688dbe1c34a.diff

[Lldb-commits] [lldb] 2df9430 - [lldb] Remove uses of PointerType::getElementType()

Author: Nikita Popov Date: 2022-02-14T09:34:24+01:00 New Revision: 2df9430fbfaf40ecce5f902651e2725aaa4c275b URL: https://github.com/llvm/llvm-project/commit/2df9430fbfaf40ecce5f902651e2725aaa4c275b DIFF: https://github.com/llvm/llvm-project/commit/2df9430fbfaf40ecce5f902651e2725aaa4c275b.diff